2024-02-12 14:51:43

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

This series adds the missing pieces to the coreboot bus and the module
alias generation to allow coreboot modules to be automatically loaded
when matching devices are detected.

The configs for cbmem coreboot entries are then enabled in the arm64
defconfig, as modules, to allow reading logs from coreboot on arm64
Chromebooks, which is useful for debugging the boot process.

Changes in v4:
- Added driver_data to device_id struct
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Merged all "add to module device table" commits into a single commit
which also changes the coreboot_driver struct to contain an id table
and avoid unused variable warnings for the id tables.

Changes in v2:
- Added commits for vpd, memconsole and framebuffer drivers to add them
to the module device table

---
Nícolas F. R. A. Prado (4):
firmware: coreboot: Generate modalias uevent for devices
firmware: coreboot: Generate aliases for coreboot modules
firmware: coreboot: Replace tag with id table in driver struct
arm64: defconfig: Enable support for cbmem entries in the coreboot table

arch/arm64/configs/defconfig | 3 +++
drivers/firmware/google/cbmem.c | 8 +++++++-
drivers/firmware/google/coreboot_table.c | 20 +++++++++++++++++++-
drivers/firmware/google/coreboot_table.h | 3 ++-
drivers/firmware/google/framebuffer-coreboot.c | 8 +++++++-
drivers/firmware/google/memconsole-coreboot.c | 8 +++++++-
drivers/firmware/google/vpd.c | 8 +++++++-
include/linux/mod_devicetable.h | 10 ++++++++++
scripts/mod/devicetable-offsets.c | 3 +++
scripts/mod/file2alias.c | 10 ++++++++++
10 files changed, 75 insertions(+), 6 deletions(-)
---
base-commit: 0f067394dd3b2af3263339cf7183bdb6ee0ac1f8
change-id: 20240117-coreboot-mod-defconfig-826b01e242d9

Best regards,
--
Nícolas F. R. A. Prado <[email protected]>



2024-02-12 14:51:47

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH v4 1/4] firmware: coreboot: Generate modalias uevent for devices

Generate a modalias uevent for devices in the coreboot bus to allow
userspace to automatically load the corresponding modules.

Acked-by: Brian Norris <[email protected]>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Reviewed-by: Brian Norris <[email protected]>
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
drivers/firmware/google/coreboot_table.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/google/coreboot_table.c
index 2a4469bf1b81..c1b9a9e8e8ed 100644
--- a/drivers/firmware/google/coreboot_table.c
+++ b/drivers/firmware/google/coreboot_table.c
@@ -53,11 +53,20 @@ static void coreboot_bus_remove(struct device *dev)
driver->remove(device);
}

+static int coreboot_bus_uevent(const struct device *dev, struct kobj_uevent_env *env)
+{
+ struct coreboot_device *device = CB_DEV(dev);
+ u32 tag = device->entry.tag;
+
+ return add_uevent_var(env, "MODALIAS=coreboot:t%08X", tag);
+}
+
static struct bus_type coreboot_bus_type = {
.name = "coreboot",
.match = coreboot_bus_match,
.probe = coreboot_bus_probe,
.remove = coreboot_bus_remove,
+ .uevent = coreboot_bus_uevent,
};

static void coreboot_device_release(struct device *dev)

--
2.43.0


2024-02-12 14:52:01

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH v4 2/4] firmware: coreboot: Generate aliases for coreboot modules

Generate aliases for coreboot modules to allow automatic module probing.

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Reviewed-by: Brian Norris <[email protected]>
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
include/linux/mod_devicetable.h | 10 ++++++++++
scripts/mod/devicetable-offsets.c | 3 +++
scripts/mod/file2alias.c | 10 ++++++++++
3 files changed, 23 insertions(+)

diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index f458469c5ce5..7a9a07ea451b 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -960,4 +960,14 @@ struct vchiq_device_id {
char name[32];
};

+/**
+ * struct coreboot_device_id - Identifies a coreboot table entry
+ * @tag: tag ID
+ * @driver_data: driver specific data
+ */
+struct coreboot_device_id {
+ __u32 tag;
+ kernel_ulong_t driver_data;
+};
+
#endif /* LINUX_MOD_DEVICETABLE_H */
diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devicetable-offsets.c
index e91a3c38143b..518200813d4e 100644
--- a/scripts/mod/devicetable-offsets.c
+++ b/scripts/mod/devicetable-offsets.c
@@ -274,5 +274,8 @@ int main(void)
DEVID(vchiq_device_id);
DEVID_FIELD(vchiq_device_id, name);

+ DEVID(coreboot_device_id);
+ DEVID_FIELD(coreboot_device_id, tag);
+
return 0;
}
diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index 4829680a0a6d..5d1c61fa5a55 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -1494,6 +1494,15 @@ static int do_vchiq_entry(const char *filename, void *symval, char *alias)
return 1;
}

+/* Looks like: coreboot:tN */
+static int do_coreboot_entry(const char *filename, void *symval, char *alias)
+{
+ DEF_FIELD(symval, coreboot_device_id, tag);
+ sprintf(alias, "coreboot:t%08X", tag);
+
+ return 1;
+}
+
/* Does namelen bytes of name exactly match the symbol? */
static bool sym_is(const char *name, unsigned namelen, const char *symbol)
{
@@ -1575,6 +1584,7 @@ static const struct devtable devtable[] = {
{"ishtp", SIZE_ishtp_device_id, do_ishtp_entry},
{"cdx", SIZE_cdx_device_id, do_cdx_entry},
{"vchiq", SIZE_vchiq_device_id, do_vchiq_entry},
+ {"coreboot", SIZE_coreboot_device_id, do_coreboot_entry},
};

/* Create MODULE_ALIAS() statements.

--
2.43.0


2024-02-12 14:52:17

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH v4 3/4] firmware: coreboot: Replace tag with id table in driver struct

Switch the plain 'tag' field in struct coreboot_driver for the newly
created coreboot_device_id struct, which also contains a tag field and
has the benefit of allowing modalias generation, and update all coreboot
drivers accordingly.

While at it, also add the id table for each driver to the module device
table to allow automatically loading the module.

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Reviewed-by: Brian Norris <[email protected]>
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
drivers/firmware/google/cbmem.c | 8 +++++++-
drivers/firmware/google/coreboot_table.c | 11 ++++++++++-
drivers/firmware/google/coreboot_table.h | 3 ++-
drivers/firmware/google/framebuffer-coreboot.c | 8 +++++++-
drivers/firmware/google/memconsole-coreboot.c | 8 +++++++-
drivers/firmware/google/vpd.c | 8 +++++++-
6 files changed, 40 insertions(+), 6 deletions(-)

diff --git a/drivers/firmware/google/cbmem.c b/drivers/firmware/google/cbmem.c
index 88e587ba1e0d..c2bffdc352a3 100644
--- a/drivers/firmware/google/cbmem.c
+++ b/drivers/firmware/google/cbmem.c
@@ -114,6 +114,12 @@ static int cbmem_entry_probe(struct coreboot_device *dev)
return 0;
}

+static const struct coreboot_device_id cbmem_ids[] = {
+ { .tag = LB_TAG_CBMEM_ENTRY },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(coreboot, cbmem_ids);
+
static struct coreboot_driver cbmem_entry_driver = {
.probe = cbmem_entry_probe,
.drv = {
@@ -121,7 +127,7 @@ static struct coreboot_driver cbmem_entry_driver = {
.owner = THIS_MODULE,
.dev_groups = dev_groups,
},
- .tag = LB_TAG_CBMEM_ENTRY,
+ .id_table = cbmem_ids,
};
module_coreboot_driver(cbmem_entry_driver);

diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/google/coreboot_table.c
index c1b9a9e8e8ed..33971cf33112 100644
--- a/drivers/firmware/google/coreboot_table.c
+++ b/drivers/firmware/google/coreboot_table.c
@@ -28,8 +28,17 @@ static int coreboot_bus_match(struct device *dev, struct device_driver *drv)
{
struct coreboot_device *device = CB_DEV(dev);
struct coreboot_driver *driver = CB_DRV(drv);
+ const struct coreboot_device_id *id;

- return device->entry.tag == driver->tag;
+ if (!driver->id_table)
+ return 0;
+
+ for (id = driver->id_table; id->tag; id++) {
+ if (device->entry.tag == id->tag)
+ return 1;
+ }
+
+ return 0;
}

static int coreboot_bus_probe(struct device *dev)
diff --git a/drivers/firmware/google/coreboot_table.h b/drivers/firmware/google/coreboot_table.h
index d814dca33a08..86427989c57f 100644
--- a/drivers/firmware/google/coreboot_table.h
+++ b/drivers/firmware/google/coreboot_table.h
@@ -13,6 +13,7 @@
#define __COREBOOT_TABLE_H

#include <linux/device.h>
+#include <linux/mod_devicetable.h>

/* Coreboot table header structure */
struct coreboot_table_header {
@@ -93,7 +94,7 @@ struct coreboot_driver {
int (*probe)(struct coreboot_device *);
void (*remove)(struct coreboot_device *);
struct device_driver drv;
- u32 tag;
+ const struct coreboot_device_id *id_table;
};

/* Register a driver that uses the data from a coreboot table. */
diff --git a/drivers/firmware/google/framebuffer-coreboot.c b/drivers/firmware/google/framebuffer-coreboot.c
index 5c84bbebfef8..07c458bf64ec 100644
--- a/drivers/firmware/google/framebuffer-coreboot.c
+++ b/drivers/firmware/google/framebuffer-coreboot.c
@@ -80,13 +80,19 @@ static void framebuffer_remove(struct coreboot_device *dev)
platform_device_unregister(pdev);
}

+static const struct coreboot_device_id framebuffer_ids[] = {
+ { .tag = CB_TAG_FRAMEBUFFER },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(coreboot, framebuffer_ids);
+
static struct coreboot_driver framebuffer_driver = {
.probe = framebuffer_probe,
.remove = framebuffer_remove,
.drv = {
.name = "framebuffer",
},
- .tag = CB_TAG_FRAMEBUFFER,
+ .id_table = framebuffer_ids,
};
module_coreboot_driver(framebuffer_driver);

diff --git a/drivers/firmware/google/memconsole-coreboot.c b/drivers/firmware/google/memconsole-coreboot.c
index 74b5286518ee..24c97a70aa80 100644
--- a/drivers/firmware/google/memconsole-coreboot.c
+++ b/drivers/firmware/google/memconsole-coreboot.c
@@ -96,13 +96,19 @@ static void memconsole_remove(struct coreboot_device *dev)
memconsole_exit();
}

+static const struct coreboot_device_id memconsole_ids[] = {
+ { .tag = CB_TAG_CBMEM_CONSOLE },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(coreboot, memconsole_ids);
+
static struct coreboot_driver memconsole_driver = {
.probe = memconsole_probe,
.remove = memconsole_remove,
.drv = {
.name = "memconsole",
},
- .tag = CB_TAG_CBMEM_CONSOLE,
+ .id_table = memconsole_ids,
};
module_coreboot_driver(memconsole_driver);

diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index ee6e08c0592b..8e4216714b29 100644
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -306,13 +306,19 @@ static void vpd_remove(struct coreboot_device *dev)
kobject_put(vpd_kobj);
}

+static const struct coreboot_device_id vpd_ids[] = {
+ { .tag = CB_TAG_VPD },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(coreboot, vpd_ids);
+
static struct coreboot_driver vpd_driver = {
.probe = vpd_probe,
.remove = vpd_remove,
.drv = {
.name = "vpd",
},
- .tag = CB_TAG_VPD,
+ .id_table = vpd_ids,
};
module_coreboot_driver(vpd_driver);


--
2.43.0


2024-02-12 15:16:13

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH v4 4/4] arm64: defconfig: Enable support for cbmem entries in the coreboot table

Enable the cbmem driver and dependencies in order to support reading
cbmem entries from the coreboot table, which are used to store logs from
coreboot on arm64 Chromebooks, and provide useful information for
debugging the boot process on those devices.

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Reviewed-by: Brian Norris <[email protected]>
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
arch/arm64/configs/defconfig | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 361c31b5d064..49121133f045 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -255,6 +255,9 @@ CONFIG_INTEL_STRATIX10_RSU=m
CONFIG_MTK_ADSP_IPC=m
CONFIG_QCOM_QSEECOM=y
CONFIG_QCOM_QSEECOM_UEFISECAPP=y
+CONFIG_GOOGLE_FIRMWARE=y
+CONFIG_GOOGLE_CBMEM=m
+CONFIG_GOOGLE_COREBOOT_TABLE=m
CONFIG_EFI_CAPSULE_LOADER=y
CONFIG_IMX_SCU=y
CONFIG_IMX_SCU_PD=y

--
2.43.0


2024-02-15 03:37:54

by Tzung-Bi Shih

[permalink] [raw]
Subject: Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

On Mon, Feb 12, 2024 at 09:50:04AM -0500, N?colas F. R. A. Prado wrote:
> This series adds the missing pieces to the coreboot bus and the module
> alias generation to allow coreboot modules to be automatically loaded
> when matching devices are detected.
>
> The configs for cbmem coreboot entries are then enabled in the arm64
> defconfig, as modules, to allow reading logs from coreboot on arm64
> Chromebooks, which is useful for debugging the boot process.
>
> [...]
>
> ---
> N?colas F. R. A. Prado (4):
> firmware: coreboot: Generate modalias uevent for devices
> firmware: coreboot: Generate aliases for coreboot modules
> firmware: coreboot: Replace tag with id table in driver struct
> arm64: defconfig: Enable support for cbmem entries in the coreboot table
>
> arch/arm64/configs/defconfig | 3 +++

Hi Catalin and Will,

Is it OK to you if I pick the 4th patch (which touches the above files) to
chrome-platform-firmware tree for the next merge window?

> include/linux/mod_devicetable.h | 10 ++++++++++
> scripts/mod/devicetable-offsets.c | 3 +++
> scripts/mod/file2alias.c | 10 ++++++++++

Hi Masahiro,

Is it OK to you if I pick the 2nd patch (which touches the above files) to
chrome-platform-firmware tree for the next merge window?

2024-02-15 05:52:13

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH v4 2/4] firmware: coreboot: Generate aliases for coreboot modules

On Mon, Feb 12, 2024 at 11:51 PM Nícolas F. R. A. Prado
<[email protected]> wrote:
>
> Generate aliases for coreboot modules to allow automatic module probing.
>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
> Reviewed-by: Brian Norris <[email protected]>
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>


Acked-by: Masahiro Yamada <[email protected]>



--
Best Regards
Masahiro Yamada

2024-02-15 06:01:56

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

On Thu, Feb 15, 2024 at 12:37 PM Tzung-Bi Shih <[email protected]> wrote:
>
> On Mon, Feb 12, 2024 at 09:50:04AM -0500, Nícolas F. R. A. Prado wrote:
> > This series adds the missing pieces to the coreboot bus and the module
> > alias generation to allow coreboot modules to be automatically loaded
> > when matching devices are detected.
> >
> > The configs for cbmem coreboot entries are then enabled in the arm64
> > defconfig, as modules, to allow reading logs from coreboot on arm64
> > Chromebooks, which is useful for debugging the boot process.
> >
> > [...]
> >
> > ---
> > Nícolas F. R. A. Prado (4):
> > firmware: coreboot: Generate modalias uevent for devices
> > firmware: coreboot: Generate aliases for coreboot modules
> > firmware: coreboot: Replace tag with id table in driver struct
> > arm64: defconfig: Enable support for cbmem entries in the coreboot table
> >
> > arch/arm64/configs/defconfig | 3 +++
>
> Hi Catalin and Will,
>
> Is it OK to you if I pick the 4th patch (which touches the above files) to
> chrome-platform-firmware tree for the next merge window?
>
> > include/linux/mod_devicetable.h | 10 ++++++++++
> > scripts/mod/devicetable-offsets.c | 3 +++
> > scripts/mod/file2alias.c | 10 ++++++++++
>
> Hi Masahiro,
>
> Is it OK to you if I pick the 2nd patch (which touches the above files) to
> chrome-platform-firmware tree for the next merge window?


Yes.


I gave Acked-by to 2/4 so it makes your life easier.




--
Best Regards
Masahiro Yamada

2024-02-17 00:58:17

by Tzung-Bi Shih

[permalink] [raw]
Subject: Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

On Mon, Feb 12, 2024 at 09:50:04AM -0500, N?colas F. R. A. Prado wrote:
> This series adds the missing pieces to the coreboot bus and the module
> alias generation to allow coreboot modules to be automatically loaded
> when matching devices are detected.
>
> The configs for cbmem coreboot entries are then enabled in the arm64
> defconfig, as modules, to allow reading logs from coreboot on arm64
> Chromebooks, which is useful for debugging the boot process.
>
> [...]

Applied, thanks!

[1/4] firmware: coreboot: Generate modalias uevent for devices
commit: c2b28f6806d2a26a8d46c0f02d4852bf9904929d
[2/4] firmware: coreboot: Generate aliases for coreboot modules
commit: f1cebae1dbf85f9de65c13a2d9f5cc3be7e51dc4
[3/4] firmware: coreboot: Replace tag with id table in driver struct
commit: 8a0a62941a042612f7487f6c4ff291f9054ff214

2024-03-04 14:02:56

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

On Mon, Mar 4, 2024, at 14:56, Nícolas F. R. A. Prado wrote:
> On Mon, Feb 12, 2024 at 09:50:04AM -0500, Nícolas F. R. A. Prado wrote:
>> Nícolas F. R. A. Prado (4):
>> firmware: coreboot: Generate modalias uevent for devices
>> firmware: coreboot: Generate aliases for coreboot modules
>> firmware: coreboot: Replace tag with id table in driver struct
>> arm64: defconfig: Enable support for cbmem entries in the coreboot table
>
> is it ok for Tzung-Bi to merge this last patch for the defconfig through the
> chrome-platform-firmware tree?

I would much prefer to see this patch get sent to [email protected]
so I can pick it up through the soc tree. I'm usually not worried
about bisection issues with defconfig changes since most users
have their own .config anyway, and in this case I don't see
any strict dependency and would just merge the patch directly.

Arnd

2024-03-04 14:20:41

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

On Mon, Feb 12, 2024 at 09:50:04AM -0500, N?colas F. R. A. Prado wrote:
> This series adds the missing pieces to the coreboot bus and the module
> alias generation to allow coreboot modules to be automatically loaded
> when matching devices are detected.
>
> The configs for cbmem coreboot entries are then enabled in the arm64
> defconfig, as modules, to allow reading logs from coreboot on arm64
> Chromebooks, which is useful for debugging the boot process.
>
> Changes in v4:
> - Added driver_data to device_id struct
> - Link to v3: https://lore.kernel.org/r/[email protected]
>
> Changes in v3:
> - Merged all "add to module device table" commits into a single commit
> which also changes the coreboot_driver struct to contain an id table
> and avoid unused variable warnings for the id tables.
>
> Changes in v2:
> - Added commits for vpd, memconsole and framebuffer drivers to add them
> to the module device table
>
> ---
> N?colas F. R. A. Prado (4):
> firmware: coreboot: Generate modalias uevent for devices
> firmware: coreboot: Generate aliases for coreboot modules
> firmware: coreboot: Replace tag with id table in driver struct
> arm64: defconfig: Enable support for cbmem entries in the coreboot table

Hi Arnd,

is it ok for Tzung-Bi to merge this last patch for the defconfig through the
chrome-platform-firmware tree?

Thanks,
N?colas

>
> arch/arm64/configs/defconfig | 3 +++
> drivers/firmware/google/cbmem.c | 8 +++++++-
> drivers/firmware/google/coreboot_table.c | 20 +++++++++++++++++++-
> drivers/firmware/google/coreboot_table.h | 3 ++-
> drivers/firmware/google/framebuffer-coreboot.c | 8 +++++++-
> drivers/firmware/google/memconsole-coreboot.c | 8 +++++++-
> drivers/firmware/google/vpd.c | 8 +++++++-
> include/linux/mod_devicetable.h | 10 ++++++++++
> scripts/mod/devicetable-offsets.c | 3 +++
> scripts/mod/file2alias.c | 10 ++++++++++
> 10 files changed, 75 insertions(+), 6 deletions(-)
> ---
> base-commit: 0f067394dd3b2af3263339cf7183bdb6ee0ac1f8
> change-id: 20240117-coreboot-mod-defconfig-826b01e242d9
>
> Best regards,
> --
> N?colas F. R. A. Prado <[email protected]>
>

2024-03-04 18:50:14

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

On Mon, Mar 04, 2024 at 03:02:21PM +0100, Arnd Bergmann wrote:
> On Mon, Mar 4, 2024, at 14:56, N?colas F. R. A. Prado wrote:
> > On Mon, Feb 12, 2024 at 09:50:04AM -0500, N?colas F. R. A. Prado wrote:
> >> N?colas F. R. A. Prado (4):
> >> firmware: coreboot: Generate modalias uevent for devices
> >> firmware: coreboot: Generate aliases for coreboot modules
> >> firmware: coreboot: Replace tag with id table in driver struct
> >> arm64: defconfig: Enable support for cbmem entries in the coreboot table
> >
> > is it ok for Tzung-Bi to merge this last patch for the defconfig through the
> > chrome-platform-firmware tree?
>
> I would much prefer to see this patch get sent to [email protected]
> so I can pick it up through the soc tree. I'm usually not worried
> about bisection issues with defconfig changes since most users
> have their own .config anyway, and in this case I don't see
> any strict dependency and would just merge the patch directly.

Sounds good, I'll send it separately there. And you're right, the patch doesn't
have any dependency.

Thanks,
N?colas

Subject: Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

Hello:

This series was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <[email protected]>:

On Mon, 12 Feb 2024 09:50:04 -0500 you wrote:
> This series adds the missing pieces to the coreboot bus and the module
> alias generation to allow coreboot modules to be automatically loaded
> when matching devices are detected.
>
> The configs for cbmem coreboot entries are then enabled in the arm64
> defconfig, as modules, to allow reading logs from coreboot on arm64
> Chromebooks, which is useful for debugging the boot process.
>
> [...]

Here is the summary with links:
- [v4,1/4] firmware: coreboot: Generate modalias uevent for devices
https://git.kernel.org/chrome-platform/c/c2b28f6806d2
- [v4,2/4] firmware: coreboot: Generate aliases for coreboot modules
https://git.kernel.org/chrome-platform/c/f1cebae1dbf8
- [v4,3/4] firmware: coreboot: Replace tag with id table in driver struct
https://git.kernel.org/chrome-platform/c/8a0a62941a04
- [v4,4/4] arm64: defconfig: Enable support for cbmem entries in the coreboot table
(no matching commit)

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



Subject: Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

Hello:

This series was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <[email protected]>:

On Mon, 12 Feb 2024 09:50:04 -0500 you wrote:
> This series adds the missing pieces to the coreboot bus and the module
> alias generation to allow coreboot modules to be automatically loaded
> when matching devices are detected.
>
> The configs for cbmem coreboot entries are then enabled in the arm64
> defconfig, as modules, to allow reading logs from coreboot on arm64
> Chromebooks, which is useful for debugging the boot process.
>
> [...]

Here is the summary with links:
- [v4,1/4] firmware: coreboot: Generate modalias uevent for devices
https://git.kernel.org/chrome-platform/c/c2b28f6806d2
- [v4,2/4] firmware: coreboot: Generate aliases for coreboot modules
https://git.kernel.org/chrome-platform/c/f1cebae1dbf8
- [v4,3/4] firmware: coreboot: Replace tag with id table in driver struct
https://git.kernel.org/chrome-platform/c/8a0a62941a04
- [v4,4/4] arm64: defconfig: Enable support for cbmem entries in the coreboot table
(no matching commit)

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html