2024-03-26 06:00:39

by Bard Liao

Subject: [PATCH] soundwire: bus: don't clear SDCA_CASCADE bit

From: Pierre-Louis Bossart <[email protected]>

The SDCA_CASCADE bit is a SoundWire 1.2 addition. It is technically in
the DP0_INT register, but SDCA interrupts shall not be handled as part
of the DP0 interrupt processing.

The existing code has clear comments that we don't want to touch the
SDCA_CASCADE bit, but it's actually cleared due to faulty logic dating
from SoundWire 1.0

In theory clearing this bit should have no effect: a cascade bit
remains set while all ORed status are set, but better safe than sorry.

Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Chao Song <[email protected]>
Signed-off-by: Bard Liao <[email protected]>
---
drivers/soundwire/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index f3fec15c3112..05b2db00d9cd 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -1474,7 +1474,7 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status)
}

do {
- clear = status & ~SDW_DP0_INTERRUPTS;
+ clear = status & ~(SDW_DP0_INTERRUPTS | SDW_DP0_SDCA_CASCADE);

if (status & SDW_DP0_INT_TEST_FAIL) {
dev_err(&slave->dev, "Test fail for port 0\n");
--
2.34.1

2024-03-28 18:21:50

by Vinod Koul

Subject: Re: [PATCH] soundwire: bus: don't clear SDCA_CASCADE bit

On Tue, 26 Mar 2024 06:00:21 +0000, Bard Liao wrote:
> The SDCA_CASCADE bit is a SoundWire 1.2 addition. It is technically in
> the DP0_INT register, but SDCA interrupts shall not be handled as part
> of the DP0 interrupt processing.
>
> The existing code has clear comments that we don't want to touch the
> SDCA_CASCADE bit, but it's actually cleared due to faulty logic dating
> from SoundWire 1.0
>
> [...]

Applied, thanks!

[1/1] soundwire: bus: don't clear SDCA_CASCADE bit
commit: b3a6809e623c03371ba51845129cdec3ebb7896e

Best regards,
--
~Vinod