2024-04-15 10:09:22

by Colin Ian King

Subject: [PATCH][next] net/handshake: remove redundant assignment to variable ret

The variable is being assigned an value and then is being re-assigned
a new value in the next statement. The assignment is redundant and can
be removed.

Cleans up clang scan build warning:
net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never
read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
net/handshake/tlshd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/handshake/tlshd.c b/net/handshake/tlshd.c
index d697f68c598c..d6f52839827e 100644
--- a/net/handshake/tlshd.c
+++ b/net/handshake/tlshd.c
@@ -213,7 +213,6 @@ static int tls_handshake_accept(struct handshake_req *req,
if (!hdr)
goto out_cancel;

- ret = -EMSGSIZE;
ret = nla_put_s32(msg, HANDSHAKE_A_ACCEPT_SOCKFD, fd);
if (ret < 0)
goto out_cancel;
--
2.39.2

2024-04-15 12:02:09

by Jason Xing

Subject: Re: [PATCH][next] net/handshake: remove redundant assignment to variable ret

On Mon, Apr 15, 2024 at 6:08 PM Colin Ian King <[email protected]> wrote:
>
> The variable is being assigned an value and then is being re-assigned
> a new value in the next statement. The assignment is redundant and can
> be removed.
>
> Cleans up clang scan build warning:
> net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never
> read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Jason Xing <[email protected]>

2024-04-15 13:55:46

by Chuck Lever

Subject: Re: [PATCH][next] net/handshake: remove redundant assignment to variable ret

On Mon, Apr 15, 2024 at 11:07:13AM +0100, Colin Ian King wrote:
> The variable is being assigned an value and then is being re-assigned
> a new value in the next statement. The assignment is redundant and can
> be removed.
>
> Cleans up clang scan build warning:
> net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never
> read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> net/handshake/tlshd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/handshake/tlshd.c b/net/handshake/tlshd.c
> index d697f68c598c..d6f52839827e 100644
> --- a/net/handshake/tlshd.c
> +++ b/net/handshake/tlshd.c
> @@ -213,7 +213,6 @@ static int tls_handshake_accept(struct handshake_req *req,
> if (!hdr)
> goto out_cancel;
>
> - ret = -EMSGSIZE;
> ret = nla_put_s32(msg, HANDSHAKE_A_ACCEPT_SOCKFD, fd);
> if (ret < 0)
> goto out_cancel;
> --
> 2.39.2
>
>

Acked-by: Chuck Lever <[email protected]>

--
Chuck Lever

2024-04-17 00:21:17

by patchwork-bot+netdevbpf

Subject: Re: [PATCH][next] net/handshake: remove redundant assignment to variable ret

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Mon, 15 Apr 2024 11:07:13 +0100 you wrote:
> The variable is being assigned an value and then is being re-assigned
> a new value in the next statement. The assignment is redundant and can
> be removed.
>
> Cleans up clang scan build warning:
> net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never
> read [deadcode.DeadStores]
>
> [...]

Here is the summary with links:
- [next] net/handshake: remove redundant assignment to variable ret
https://git.kernel.org/netdev/net-next/c/c2b640529ec7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html