2024-04-28 10:22:01

by Borislav Petkov

Subject: [PATCH] clocksource: Make the int help prompt unit readable in ncurses

From: "Borislav Petkov (AMD)" <[email protected]>

When doing

make menuconfig

and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the
help says:

│ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
│ Type : integer
│ Range : [50 1000]
│ Defined at kernel/time/Kconfig:204
│ Prompt: Clocksource watchdog maximum allowable skew (in s)
^^^^^

│ Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]

because on some terminals, it cannot display the 'μ' char, unicode
number 0x3bc.

So simply write it out so that there's no trouble.

Signed-off-by: Borislav Petkov (AMD) <[email protected]>
Cc: Paul E. McKenney <[email protected]>
Cc: Waiman Long <[email protected]>
---
kernel/time/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
index fc3b1a06c981..8ebb6d5a106b 100644
--- a/kernel/time/Kconfig
+++ b/kernel/time/Kconfig
@@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
the size of the kernel image.

config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
- int "Clocksource watchdog maximum allowable skew (in μs)"
+ int "Clocksource watchdog maximum allowable skew (in microseconds)"
depends on CLOCKSOURCE_WATCHDOG
range 50 1000
default 125
--
2.43.0

2024-04-28 15:39:38

by Randy Dunlap

Subject: Re: [PATCH] clocksource: Make the int help prompt unit readable in ncurses

On 4/28/24 3:21 AM, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <[email protected]>
>
> When doing
>
> make menuconfig
>
> and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the
> help says:
>
> │ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
> │ Type : integer
> │ Range : [50 1000]
> │ Defined at kernel/time/Kconfig:204
> │ Prompt: Clocksource watchdog maximum allowable skew (in s)
> ^^^^^
>
> │ Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]
>
> because on some terminals, it cannot display the 'μ' char, unicode
> number 0x3bc.
>
> So simply write it out so that there's no trouble.
>
> Signed-off-by: Borislav Petkov (AMD) <[email protected]>
> Cc: Paul E. McKenney <[email protected]>
> Cc: Waiman Long <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> kernel/time/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
> index fc3b1a06c981..8ebb6d5a106b 100644
> --- a/kernel/time/Kconfig
> +++ b/kernel/time/Kconfig
> @@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
> the size of the kernel image.
>
> config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
> - int "Clocksource watchdog maximum allowable skew (in μs)"
> + int "Clocksource watchdog maximum allowable skew (in microseconds)"
> depends on CLOCKSOURCE_WATCHDOG
> range 50 1000
> default 125

--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html

2024-04-29 16:05:40

by Paul E. McKenney

Subject: Re: [PATCH] clocksource: Make the int help prompt unit readable in ncurses

On Sun, Apr 28, 2024 at 12:21:43PM +0200, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <[email protected]>
>
> When doing
>
> make menuconfig
>
> and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the
> help says:
>
> │ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
> │ Type : integer
> │ Range : [50 1000]
> │ Defined at kernel/time/Kconfig:204
> │ Prompt: Clocksource watchdog maximum allowable skew (in s)
> ^^^^^
>
> │ Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]
>
> because on some terminals, it cannot display the 'μ' char, unicode
> number 0x3bc.
>
> So simply write it out so that there's no trouble.
>
> Signed-off-by: Borislav Petkov (AMD) <[email protected]>
> Cc: Paul E. McKenney <[email protected]>
> Cc: Waiman Long <[email protected]>

So all the world is not yet a UTF-8? ;-)

Acked-by: Paul E. McKenney <[email protected]>

> ---
> kernel/time/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
> index fc3b1a06c981..8ebb6d5a106b 100644
> --- a/kernel/time/Kconfig
> +++ b/kernel/time/Kconfig
> @@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
> the size of the kernel image.
>
> config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
> - int "Clocksource watchdog maximum allowable skew (in μs)"
> + int "Clocksource watchdog maximum allowable skew (in microseconds)"
> depends on CLOCKSOURCE_WATCHDOG
> range 50 1000
> default 125
> --
> 2.43.0
>

2024-04-29 22:19:32

by tip-bot2 for Jacob Pan

Subject: [tip: timers/core] clocksource: Make the int help prompt unit readable in ncurses

The following commit has been merged into the timers/core branch of tip:

Commit-ID: 54db412e618e9c43e5167f809a901f554e8c43e2
Gitweb: https://git.kernel.org/tip/54db412e618e9c43e5167f809a901f554e8c43e2
Author: Borislav Petkov (AMD) <[email protected]>
AuthorDate: Sun, 28 Apr 2024 12:21:43 +02:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Tue, 30 Apr 2024 00:12:22 +02:00

clocksource: Make the int help prompt unit readable in ncurses

When doing

make menuconfig

and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the
help says:

│ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
│ Type : integer
│ Range : [50 1000]
│ Defined at kernel/time/Kconfig:204
│ Prompt: Clocksource watchdog maximum allowable skew (in s)
^^^

│ Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]

because on some terminals, it cannot display the 'μ' char, unicode
number 0x3bc.

So simply write it out so that there's no trouble.

Signed-off-by: Borislav Petkov (AMD) <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: Paul E. McKenney <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
kernel/time/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
index fc3b1a0..8ebb6d5 100644
--- a/kernel/time/Kconfig
+++ b/kernel/time/Kconfig
@@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
the size of the kernel image.

config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
- int "Clocksource watchdog maximum allowable skew (in μs)"
+ int "Clocksource watchdog maximum allowable skew (in microseconds)"
depends on CLOCKSOURCE_WATCHDOG
range 50 1000
default 125

2024-04-29 22:29:29

by Borislav Petkov

Subject: Re: [PATCH] clocksource: Make the int help prompt unit readable in ncurses

On Mon, Apr 29, 2024 at 09:04:30AM -0700, Paul E. McKenney wrote:
> So all the world is not yet a UTF-8? ;-)

.. and it's not like I'm not trying. I have a fairly new debian
testing, xterm v390 and libncurses5 v6.3 but nope, no joy.

I betcha it is some stupid conversion thing.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

2024-04-29 22:54:25

by Paul E. McKenney

Subject: Re: [PATCH] clocksource: Make the int help prompt unit readable in ncurses

On Tue, Apr 30, 2024 at 12:29:02AM +0200, Borislav Petkov wrote:
> On Mon, Apr 29, 2024 at 09:04:30AM -0700, Paul E. McKenney wrote:
> > So all the world is not yet a UTF-8? ;-)
>
> ... and it's not like I'm not trying. I have a fairly new debian
> testing, xterm v390 and libncurses5 v6.3 but nope, no joy.
>
> I betcha it is some stupid conversion thing.

Worse things could happen! ;-)

Thanx, Paul