An ALU instruction's source operand can be the value in the source
register or the 32-bit immediate value encoded in the instruction. This
is controlled by the 's' bit of the 'opcode'.
The current description explicitly uses the phrase 'value of the source
register' when defining the meaning of 'src'.
Change the description to use 'source operand' in place of 'value of the
source register'.
Signed-off-by: Puranjay Mohan <[email protected]>
---
Documentation/bpf/standardization/instruction-set.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
index a5ab00ac0b14..2e17b365388e 100644
--- a/Documentation/bpf/standardization/instruction-set.rst
+++ b/Documentation/bpf/standardization/instruction-set.rst
@@ -292,8 +292,9 @@ Arithmetic instructions
``ALU`` uses 32-bit wide operands while ``ALU64`` uses 64-bit wide operands for
otherwise identical operations. ``ALU64`` instructions belong to the
base64 conformance group unless noted otherwise.
-The 'code' field encodes the operation as below, where 'src' and 'dst' refer
-to the values of the source and destination registers, respectively.
+The 'code' field encodes the operation as below, where 'src' refers to the
+the source operand and 'dst' refers to the value of the destination
+register.
===== ===== ======= ==========================================================
name code offset description
--
2.40.1
Puranjay Mohan <[email protected]> wrote:
> An ALU instruction's source operand can be the value in the source
register or the
> 32-bit immediate value encoded in the instruction. This is controlled by
the 's' bit of
> the 'opcode'.
>
> The current description explicitly uses the phrase 'value of the source
register'
> when defining the meaning of 'src'.
>
> Change the description to use 'source operand' in place of 'value of the
source
> register'.
>
> Signed-off-by: Puranjay Mohan <[email protected]>
Acked-by: Dave Thaler <[email protected]>
> ---
> Documentation/bpf/standardization/instruction-set.rst | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index a5ab00ac0b14..2e17b365388e 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -292,8 +292,9 @@ Arithmetic instructions ``ALU`` uses 32-bit wide
> operands while ``ALU64`` uses 64-bit wide operands for otherwise
identical
> operations. ``ALU64`` instructions belong to the
> base64 conformance group unless noted otherwise.
> -The 'code' field encodes the operation as below, where 'src' and 'dst'
refer -to the
> values of the source and destination registers, respectively.
> +The 'code' field encodes the operation as below, where 'src' refers to
> +the the source operand and 'dst' refers to the value of the destination
> +register.
>
> ===== ===== =======
> ==========================================================
> name code offset description
> --
> 2.40.1
Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <[email protected]>:
On Tue, 14 May 2024 13:03:03 +0000 you wrote:
> An ALU instruction's source operand can be the value in the source
> register or the 32-bit immediate value encoded in the instruction. This
> is controlled by the 's' bit of the 'opcode'.
>
> The current description explicitly uses the phrase 'value of the source
> register' when defining the meaning of 'src'.
>
> [...]
Here is the summary with links:
- [bpf] bpf, docs: Fix the description of 'src' in ALU instructions
https://git.kernel.org/bpf/bpf/c/7a8030057f67
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html