2024-05-31 01:38:51

by Tristram.Ha

[permalink] [raw]
Subject: [PATCH v1 net] net: dsa: microchip: fix RGMII error in KSZ DSA driver

From: Tristram Ha <[email protected]>

The driver should return RMII interface when XMII is running in RMII mode.

Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
Signed-off-by: Tristram Ha <[email protected]>
Acked-by: Arun Ramadoss <[email protected]>
Acked-by: Jerry Ray <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
---
v1
- Add review from Andrew Lunn

drivers/net/dsa/microchip/ksz_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 1e0085cd9a9a..2818e24e2a51 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -3142,7 +3142,7 @@ phy_interface_t ksz_get_xmii(struct ksz_device *dev, int port, bool gbit)
else
interface = PHY_INTERFACE_MODE_MII;
} else if (val == bitval[P_RMII_SEL]) {
- interface = PHY_INTERFACE_MODE_RGMII;
+ interface = PHY_INTERFACE_MODE_RMII;
} else {
interface = PHY_INTERFACE_MODE_RGMII;
if (data8 & P_RGMII_ID_EG_ENABLE)
--
2.34.1



2024-05-31 22:01:37

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH v1 net] net: dsa: microchip: fix RGMII error in KSZ DSA driver

Hello:

This patch was applied to bpf/bpf.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 30 May 2024 18:38:31 -0700 you wrote:
> From: Tristram Ha <[email protected]>
>
> The driver should return RMII interface when XMII is running in RMII mode.
>
> Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
> Signed-off-by: Tristram Ha <[email protected]>
> Acked-by: Arun Ramadoss <[email protected]>
> Acked-by: Jerry Ray <[email protected]>
> Reviewed-by: Andrew Lunn <[email protected]>
>
> [...]

Here is the summary with links:
- [v1,net] net: dsa: microchip: fix RGMII error in KSZ DSA driver
https://git.kernel.org/bpf/bpf/c/278d65ccdadb

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html