2024-05-28 21:57:11

by Dr. David Alan Gilbert

Subject: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'

From: "Dr. David Alan Gilbert" <[email protected]>

'scsi_dif_tuple' is unused since
commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
sectors.").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/scsi/qla2xxx/qla_isr.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index d48007e18288..fe98c76e9be3 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
}
}

-struct scsi_dif_tuple {
- __be16 guard; /* Checksum */
- __be16 app_tag; /* APPL identifier */
- __be32 ref_tag; /* Target LBA or indirect LBA */
-};
-
/*
* Checks the guard or meta-data for the type of error
* detected by the HBA. In case of errors, we set the
--
2.45.1

2024-05-29 18:58:38

by Himanshu Madhani

Subject: Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'

On 5/28/24 14:56, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'scsi_dif_tuple' is unused since
> commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
> sectors.").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index d48007e18288..fe98c76e9be3 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
> }
> }
>
> -struct scsi_dif_tuple {
> - __be16 guard; /* Checksum */
> - __be16 app_tag; /* APPL identifier */
> - __be32 ref_tag; /* Target LBA or indirect LBA */
> -};
> -
> /*
> * Checks the guard or meta-data for the type of error
> * detected by the HBA. In case of errors, we set the

Looks Good.

Reviewed-by: Himanshu Madhani <[email protected]>

--
Himanshu Madhani Oracle Linux Engineering

2024-05-31 00:27:48

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'

> 'scsi_dif_tuple' is unused since commit 8cb2049c7448 ("[SCSI] qla2xxx:
> T10 DIF - Handle uninitalized sectors.").
>
> Remove it.

Applied to 6.11/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2024-06-05 02:42:34

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'

On Tue, 28 May 2024 22:56:40 +0100, [email protected] wrote:

> 'scsi_dif_tuple' is unused since
> commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
> sectors.").
>
> Remove it.
>
>
> [...]

Applied to 6.11/scsi-queue, thanks!

[1/1] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'
https://git.kernel.org/mkp/scsi/c/96281dfa266d

--
Martin K. Petersen Oracle Linux Engineering