2023-09-28 03:29:50

by KaiLong Wang

Subject: [PATCH] mm/gup: Clean up errors in gup.c

Fix the following errors reported by checkpatch:

ERROR: else should follow close brace '}'

Signed-off-by: KaiLong Wang <[email protected]>
---
mm/gup.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/gup.c b/mm/gup.c
index 2f8a2d89fde1..aed327450250 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1480,8 +1480,7 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm,
return -EAGAIN;
must_unlock = true;
*locked = 1;
- }
- else
+ } else
mmap_assert_locked(mm);

if (flags & FOLL_PIN)
--
2.17.1

2023-10-02 11:21:53

by David Hildenbrand

Subject: Re: [PATCH] mm/gup: Clean up errors in gup.c

On 28.09.23 05:28, KaiLong Wang wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: else should follow close brace '}'
>
> Signed-off-by: KaiLong Wang <[email protected]>
> ---
> mm/gup.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 2f8a2d89fde1..aed327450250 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1480,8 +1480,7 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm,
> return -EAGAIN;
> must_unlock = true;
> *locked = 1;
> - }
> - else
> + } else
> mmap_assert_locked(mm);
>
> if (flags & FOLL_PIN)

Please see Documentation/process/coding-style.rst "3) Placing Braces and
Spaces"

--
Cheers,

David / dhildenb