2022-09-08 10:44:38

by Xiu Jianfeng

Subject: [PATCH -next] smack: cleanup obsolete mount option flags

These mount option flags are obsolete since commit 12085b14a444 ("smack:
switch to private smack_mnt_opts"), remove them.

Signed-off-by: Xiu Jianfeng <[email protected]>
---
security/smack/smack.h | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/security/smack/smack.h b/security/smack/smack.h
index fc837dcebf96..e2239be7bd60 100644
--- a/security/smack/smack.h
+++ b/security/smack/smack.h
@@ -180,15 +180,6 @@ struct smack_known_list_elem {
struct smack_known *smk_label;
};

-/* Super block security struct flags for mount options */
-#define FSDEFAULT_MNT 0x01
-#define FSFLOOR_MNT 0x02
-#define FSHAT_MNT 0x04
-#define FSROOT_MNT 0x08
-#define FSTRANS_MNT 0x10
-
-#define NUM_SMK_MNT_OPTS 5
-
enum {
Opt_error = -1,
Opt_fsdefault = 0,
--
2.17.1

2022-09-12 17:37:28

by Casey Schaufler

Subject: Re: [PATCH -next] smack: cleanup obsolete mount option flags

On 9/8/2022 3:35 AM, Xiu Jianfeng wrote:
> These mount option flags are obsolete since commit 12085b14a444 ("smack:
> switch to private smack_mnt_opts"), remove them.
>
> Signed-off-by: Xiu Jianfeng <[email protected]>

Added to https://github.com/cschaufler/smack-next#next.
Thank you.

> ---
> security/smack/smack.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index fc837dcebf96..e2239be7bd60 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -180,15 +180,6 @@ struct smack_known_list_elem {
> struct smack_known *smk_label;
> };
>
> -/* Super block security struct flags for mount options */
> -#define FSDEFAULT_MNT 0x01
> -#define FSFLOOR_MNT 0x02
> -#define FSHAT_MNT 0x04
> -#define FSROOT_MNT 0x08
> -#define FSTRANS_MNT 0x10
> -
> -#define NUM_SMK_MNT_OPTS 5
> -
> enum {
> Opt_error = -1,
> Opt_fsdefault = 0,