2007-06-05 21:22:21

by Chris Snook

[permalink] [raw]
Subject: [PATCH TRIVIAL] icom whitespace cleanups

From: Chris Snook <[email protected]>

Clean up whitespace and comments in drivers/serial/icom.c

Signed-off-by: Chris Snook <[email protected]>

The patch is very large (30k) so I have attached it. Please let me know if you
really, really want it inline.


Attachments:
icom-whitespace-cleanup.patch (29.23 kB)

2007-06-05 22:39:55

by Paul Mackerras

[permalink] [raw]
Subject: Re: [PATCH TRIVIAL] icom whitespace cleanups

Chris Snook writes:

> Clean up whitespace and comments in drivers/serial/icom.c

These changes seem totally unnecessary, as the existing indentation is
according to a commonly-accepted style and is quite reasonable:

> @@ -149,23 +149,23 @@ static void free_port_memory(struct icom
> trace(icom_port, "RET_PORT_MEM", 0);
> if (icom_port->recv_buf) {
> pci_free_consistent(dev, 4096, icom_port->recv_buf,
> - icom_port->recv_buf_pci);
> + icom_port->recv_buf_pci);
> icom_port->recv_buf = NULL;
> }
> if (icom_port->xmit_buf) {
> pci_free_consistent(dev, 4096, icom_port->xmit_buf,
> - icom_port->xmit_buf_pci);
> + icom_port->xmit_buf_pci);

etc. etc. The comment changes I agree on but not most of the other
whitespace changes.

Also you don't seem to have cc'd the driver author.

Paul.

2007-06-05 23:01:00

by Chris Snook

[permalink] [raw]
Subject: Re: [PATCH TRIVIAL] icom whitespace cleanups

Paul Mackerras wrote:
> Chris Snook writes:
>
>> Clean up whitespace and comments in drivers/serial/icom.c
>
> These changes seem totally unnecessary, as the existing indentation is
> according to a commonly-accepted style and is quite reasonable:

There are actually a few different indentation styles used inconsistently
throughout, which I personally find annoying, and there's lots of whitespace
damage. If I've really overstepped the bounds, I'll resubmit a somewhat smaller
patch, but I'm inclined to make it look pretty while I've got the hood up.

> Also you don't seem to have cc'd the driver author.

Can't find any contact info. Care to enlighten me?

-- Chris

2007-06-06 14:21:19

by V. Ananda Krishnan

[permalink] [raw]
Subject: Re: [PATCH TRIVIAL] icom whitespace cleanups

Paul Mackerras wrote:
> Chris Snook writes:
>
>> Clean up whitespace and comments in drivers/serial/icom.c
>
> These changes seem totally unnecessary, as the existing indentation is
> according to a commonly-accepted style and is quite reasonable:
>
I agree with Paul.

>> @@ -149,23 +149,23 @@ static void free_port_memory(struct icom
>> trace(icom_port, "RET_PORT_MEM", 0);
>> if (icom_port->recv_buf) {
>> pci_free_consistent(dev, 4096, icom_port->recv_buf,
>> - icom_port->recv_buf_pci);
>> + icom_port->recv_buf_pci);
>> icom_port->recv_buf = NULL;
>> }
>> if (icom_port->xmit_buf) {
>> pci_free_consistent(dev, 4096, icom_port->xmit_buf,
>> - icom_port->xmit_buf_pci);
>> + icom_port->xmit_buf_pci);
>
> etc. etc. The comment changes I agree on but not most of the other
> whitespace changes.
The comment changes are fine with me too.
>
> Also you don't seem to have cc'd the driver author.
>
Current contacts for the driver are: Ananda ([email protected]) and
Wendy ([email protected])

:- Ananda

> Paul.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>