2023-03-10 14:51:12

by Rob Herring (Arm)

Subject: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence

It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <[email protected]>
---
drivers/rtc/rtc-sun6i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
index 7038f47d77ff..dc76537f1b62 100644
--- a/drivers/rtc/rtc-sun6i.c
+++ b/drivers/rtc/rtc-sun6i.c
@@ -260,7 +260,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node,
}

/* Switch to the external, more precise, oscillator, if present */
- if (of_get_property(node, "clocks", NULL)) {
+ if (of_property_present(node, "clocks")) {
reg |= SUN6I_LOSC_CTRL_EXT_OSC;
if (rtc->data->has_losc_en)
reg |= SUN6I_LOSC_CTRL_EXT_LOSC_EN;
--
2.39.2

2023-03-13 10:23:52

by Andre Przywara

Subject: Re: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence

On Fri, 10 Mar 2023 08:47:36 -0600
Rob Herring <[email protected]> wrote:

> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Andre Przywara <[email protected]>

Cheers,
Andre

> ---
> drivers/rtc/rtc-sun6i.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 7038f47d77ff..dc76537f1b62 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -260,7 +260,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node,
> }
>
> /* Switch to the external, more precise, oscillator, if present */
> - if (of_get_property(node, "clocks", NULL)) {
> + if (of_property_present(node, "clocks")) {
> reg |= SUN6I_LOSC_CTRL_EXT_OSC;
> if (rtc->data->has_losc_en)
> reg |= SUN6I_LOSC_CTRL_EXT_LOSC_EN;

2023-03-14 19:58:51

by Jernej Škrabec

Subject: Re: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence

Dne petek, 10. marec 2023 ob 15:47:36 CET je Rob Herring napisal(a):
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej

> ---
> drivers/rtc/rtc-sun6i.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 7038f47d77ff..dc76537f1b62 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -260,7 +260,7 @@ static void __init sun6i_rtc_clk_init(struct device_node
> *node, }
>
> /* Switch to the external, more precise, oscillator, if present */
> - if (of_get_property(node, "clocks", NULL)) {
> + if (of_property_present(node, "clocks")) {
> reg |= SUN6I_LOSC_CTRL_EXT_OSC;
> if (rtc->data->has_losc_en)
> reg |= SUN6I_LOSC_CTRL_EXT_LOSC_EN;

2023-03-17 22:22:04

by Alexandre Belloni

Subject: Re: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence

On Fri, 10 Mar 2023 08:47:36 -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> [...]

Applied, thanks!

[1/1] rtc: sun6i: Use of_property_present() for testing DT property presence
commit: 4d9890ac9d43d4dfd011110ab96633caa6fa829c

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com