2023-07-19 10:21:35

by Dmitry Baryshkov

Subject: Re: [PATCH 5/5] soc: qcom: socinfo: add SM4450 ID

On 19/07/2023 13:01, Tengfei Fan wrote:
> Add the ID for the Qualcomm SM4450 SoC.
>
> Signed-off-by: Tengfei Fan <[email protected]>
> ---
> drivers/soc/qcom/socinfo.c | 1 +
> include/dt-bindings/arm/qcom,ids.h | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 4d49945b3a35..fa5e4c54207a 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -415,6 +415,7 @@ static const struct soc_id soc_id[] = {
> { qcom_board_id(IPQ5312) },
> { qcom_board_id(IPQ5302) },
> { qcom_board_id(IPQ5300) },
> + { qcom_board_id(SM4450) },
> };
>
> static const char *socinfo_machine(struct device *dev, unsigned int id)
> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index bcbe9ee2cdaf..6201bfb1405e 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -2,6 +2,7 @@
> /*
> * Copyright (c) 2015, The Linux Foundation. All rights reserved.
> * Copyright (c) 2022 Linaro Ltd
> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.

I wonder whether a single define is copyrightable.

> * Author: Krzysztof Kozlowski <[email protected]> based on previous work of Kumar Gala.
> */
> #ifndef _DT_BINDINGS_ARM_QCOM_IDS_H
> @@ -259,6 +260,7 @@
> #define QCOM_ID_IPQ5312 594
> #define QCOM_ID_IPQ5302 595
> #define QCOM_ID_IPQ5300 624
> +#define QCOM_ID_SM4450 568
>
> /*
> * The board type and revision information, used by Qualcomm bootloaders and

--
With best wishes
Dmitry

2023-07-19 10:38:14

by Krzysztof Kozlowski

Subject: Re: [PATCH 5/5] soc: qcom: socinfo: add SM4450 ID

On 19/07/2023 12:15, Dmitry Baryshkov wrote:
> On 19/07/2023 13:01, Tengfei Fan wrote:
>> Add the ID for the Qualcomm SM4450 SoC.
>>
>> Signed-off-by: Tengfei Fan <[email protected]>
>> ---
>> drivers/soc/qcom/socinfo.c | 1 +
>> include/dt-bindings/arm/qcom,ids.h | 2 ++
>> 2 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>> index 4d49945b3a35..fa5e4c54207a 100644
>> --- a/drivers/soc/qcom/socinfo.c
>> +++ b/drivers/soc/qcom/socinfo.c
>> @@ -415,6 +415,7 @@ static const struct soc_id soc_id[] = {
>> { qcom_board_id(IPQ5312) },
>> { qcom_board_id(IPQ5302) },
>> { qcom_board_id(IPQ5300) },
>> + { qcom_board_id(SM4450) },
>> };
>>
>> static const char *socinfo_machine(struct device *dev, unsigned int id)
>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>> index bcbe9ee2cdaf..6201bfb1405e 100644
>> --- a/include/dt-bindings/arm/qcom,ids.h
>> +++ b/include/dt-bindings/arm/qcom,ids.h
>> @@ -2,6 +2,7 @@
>> /*
>> * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>> * Copyright (c) 2022 Linaro Ltd
>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>
> I wonder whether a single define is copyrightable.

If you carefully choose a place, like out of order, then probably it is
a creative work. :)

Best regards,
Krzysztof

2023-07-21 03:38:23

by Tengfei Fan

Subject: Re: [PATCH 5/5] soc: qcom: socinfo: add SM4450 ID

在 7/19/2023 6:26 PM, Krzysztof Kozlowski 写道:
> On 19/07/2023 12:15, Dmitry Baryshkov wrote:
>> On 19/07/2023 13:01, Tengfei Fan wrote:
>>> Add the ID for the Qualcomm SM4450 SoC.
>>>
>>> Signed-off-by: Tengfei Fan <[email protected]>
>>> ---
>>> drivers/soc/qcom/socinfo.c | 1 +
>>> include/dt-bindings/arm/qcom,ids.h | 2 ++
>>> 2 files changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>>> index 4d49945b3a35..fa5e4c54207a 100644
>>> --- a/drivers/soc/qcom/socinfo.c
>>> +++ b/drivers/soc/qcom/socinfo.c
>>> @@ -415,6 +415,7 @@ static const struct soc_id soc_id[] = {
>>> { qcom_board_id(IPQ5312) },
>>> { qcom_board_id(IPQ5302) },
>>> { qcom_board_id(IPQ5300) },
>>> + { qcom_board_id(SM4450) },
>>> };
>>>
>>> static const char *socinfo_machine(struct device *dev, unsigned int id)
>>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>>> index bcbe9ee2cdaf..6201bfb1405e 100644
>>> --- a/include/dt-bindings/arm/qcom,ids.h
>>> +++ b/include/dt-bindings/arm/qcom,ids.h
>>> @@ -2,6 +2,7 @@
>>> /*
>>> * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>>> * Copyright (c) 2022 Linaro Ltd
>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>
>> I wonder whether a single define is copyrightable.
>
> If you carefully choose a place, like out of order, then probably it is
> a creative work. :)
V2 patch will remove this copyrithtable.
>
> Best regards,
> Krzysztof
>

--
Thx and BRs,
Tengfei Fan