On 06/03/2022 11:41, Frank Wunderlich wrote:
>> Gesendet: Sonntag, 06. März 2022 um 11:27 Uhr
>> Von: "Krzysztof Kozlowski" <[email protected]>
>>> add compatibles used together with generic-ahci
>>> - marvell,berlin2-ahci
>>
>> This is fine, just mention it in commit msg.
>>
>>> - qcom,apq8064-ahci
>>> - qcom,ipq806x-ahci
>>
>> These you need to consult with qcom-sata.txt. This could be a following
>> commit which will integrate qcom-sata.txt and remove it.
>
> this depends on Robs opinion
Then maybe precise the question for Rob...
>
>> Either you have
>> binding document for all devices or you create a common part, like for UFS:
>> https://lore.kernel.org/linux-devicetree/[email protected]/
>> https://github.com/krzk/linux/commits/n/dt-bindings-ufs-v2
>>
>> The choice depends more or less on complexity of bindings, IOW, how big
>> and complicated bindings would be if you combine everything to one YAML.
>>
>> In the case of UFS, the devices differ - by clocks, resets, phys and
>> sometimes supplies. Therefore it easier to have one common shared part
>> and several device bindings.
>>
>> AHCI looks more consistent - except that Qualcomm - so maybe better to
>> have one document.
>>
>>> increase reg-count to 2 (used in omap5-l4.dtsi)
>>> increase clock-count to 5 (used in qcom-apq8064.dtsi)
>>
>> This would need allOf+if.
>
> if i get ok from rob i add only the berlin-compatible and skip the qcom+reg/clock-change in the first applied version. Adding the allOf/if (and making it right) will only delay the sata-binding/dts-change.
I don't get what is the problem with delaying this patch for the time
needed to make the bindings correct? Especially that alternative is to
add bindings document which soon will need to be modified, e.g. split
into common part. Is there a particular hurry with these bindings
conversion?
Best regards,
Krzysztof
> Gesendet: Sonntag, 06. März 2022 um 12:15 Uhr
> Von: "Krzysztof Kozlowski" <[email protected]>
> An: "Frank Wunderlich" <[email protected]>
> Cc: "Frank Wunderlich" <[email protected]>, [email protected], "Damien Le Moal" <[email protected]>, "Rob Herring" <[email protected]>, "Andrew Lunn" <[email protected]>, "Gregory Clement" <[email protected]>, "Sebastian Hesselbarth" <[email protected]>, "Russell King" <[email protected]>, "Heiko Stuebner" <[email protected]>, "Peter Geis" <[email protected]>, "Michael Riesch" <[email protected]>, "Hans de Goede" <[email protected]>, "Jens Axboe" <[email protected]>, [email protected], [email protected], [email protected], [email protected]
> Betreff: Re: Aw: Re: Re: [PATCH v5 1/5] dt-bindings: ata: ahci-platform: Convert DT bindings to yaml
>
> On 06/03/2022 11:41, Frank Wunderlich wrote:
> >> Gesendet: Sonntag, 06. März 2022 um 11:27 Uhr
> >> Von: "Krzysztof Kozlowski" <[email protected]>
> >>> add compatibles used together with generic-ahci
> >>> - marvell,berlin2-ahci
> >>
> >> This is fine, just mention it in commit msg.
> >>
> >>> - qcom,apq8064-ahci
> >>> - qcom,ipq806x-ahci
> >>
> >> These you need to consult with qcom-sata.txt. This could be a following
> >> commit which will integrate qcom-sata.txt and remove it.
> >
> > this depends on Robs opinion
>
> Then maybe precise the question for Rob...
do i need to fix the errors for qcom-compatibles/reg-count/clock-count (reported by your bot) *now*?
or is binding well enough with adding berlin-compatible and fixing the indentation error in example?
for the marvell anyof issue and the spear13xx i have a patch in my tree which i include in v6
> >
> >> Either you have
> >> binding document for all devices or you create a common part, like for UFS:
> >> https://lore.kernel.org/linux-devicetree/[email protected]/
> >> https://github.com/krzk/linux/commits/n/dt-bindings-ufs-v2
> >>
> >> The choice depends more or less on complexity of bindings, IOW, how big
> >> and complicated bindings would be if you combine everything to one YAML.
> >>
> >> In the case of UFS, the devices differ - by clocks, resets, phys and
> >> sometimes supplies. Therefore it easier to have one common shared part
> >> and several device bindings.
> >>
> >> AHCI looks more consistent - except that Qualcomm - so maybe better to
> >> have one document.
> >>
> >>> increase reg-count to 2 (used in omap5-l4.dtsi)
> >>> increase clock-count to 5 (used in qcom-apq8064.dtsi)
> >>
> >> This would need allOf+if.
> >
> > if i get ok from rob i add only the berlin-compatible and skip the qcom+reg/clock-change in the first applied version. Adding the allOf/if (and making it right) will only delay the sata-binding/dts-change.
>
> I don't get what is the problem with delaying this patch for the time
> needed to make the bindings correct? Especially that alternative is to
> add bindings document which soon will need to be modified, e.g. split
> into common part. Is there a particular hurry with these bindings
> conversion?
i see it as requirement for last part
"arm64: dts: rockchip: Add sata nodes to rk356x"
if this can applied without the bindings conversion there is nothing to hurry :)
regards Frank
On Sun, Mar 06, 2022 at 12:15:39PM +0100, Krzysztof Kozlowski wrote:
> On 06/03/2022 11:41, Frank Wunderlich wrote:
> >> Gesendet: Sonntag, 06. M?rz 2022 um 11:27 Uhr
> >> Von: "Krzysztof Kozlowski" <[email protected]>
> >>> add compatibles used together with generic-ahci
> >>> - marvell,berlin2-ahci
> >>
> >> This is fine, just mention it in commit msg.
> >>
> >>> - qcom,apq8064-ahci
> >>> - qcom,ipq806x-ahci
> >>
> >> These you need to consult with qcom-sata.txt. This could be a following
> >> commit which will integrate qcom-sata.txt and remove it.
> >
> > this depends on Robs opinion
>
> Then maybe precise the question for Rob...
I would leave qcom separate, but the warnings should be fixed. For that
you need a custom 'select' schema that lists everything but
'generic-ahci'. Adding the berlin compatible looks right.
> >> Either you have
> >> binding document for all devices or you create a common part, like for UFS:
> >> https://lore.kernel.org/linux-devicetree/[email protected]/
> >> https://github.com/krzk/linux/commits/n/dt-bindings-ufs-v2
> >>
> >> The choice depends more or less on complexity of bindings, IOW, how big
> >> and complicated bindings would be if you combine everything to one YAML.
> >>
> >> In the case of UFS, the devices differ - by clocks, resets, phys and
> >> sometimes supplies. Therefore it easier to have one common shared part
> >> and several device bindings.
> >>
> >> AHCI looks more consistent - except that Qualcomm - so maybe better to
> >> have one document.
> >>
> >>> increase reg-count to 2 (used in omap5-l4.dtsi)
> >>> increase clock-count to 5 (used in qcom-apq8064.dtsi)
> >>
> >> This would need allOf+if.
> >
> > if i get ok from rob i add only the berlin-compatible and skip the
> > qcom+reg/clock-change in the first applied version. Adding the
> > allOf/if (and making it right) will only delay the sata-binding/dts-change.
>
> I don't get what is the problem with delaying this patch for the time
> needed to make the bindings correct? Especially that alternative is to
> add bindings document which soon will need to be modified, e.g. split
> into common part. Is there a particular hurry with these bindings
> conversion?
Qcom doesn't use sata-port nodes, so I don't think there is anything to
share. And if it did, that's already in sata-common.yaml.
Rob