2024-02-23 13:46:02

by Jérémie Dautheribes

[permalink] [raw]
Subject: [PATCH 0/3] panel-simple: add support for Crystal Clear CMT430B19N00

This patch series add support for the Crystal Clear Technology
CMT430B19N00 4.3" 480x272 TFT-LCD panel.
It also adds Crystal Clear Technology to vendor-prefixes.yaml.

Please note that unfortunately there is no public datasheet available
for this panel.

Jérémie Dautheribes (3):
dt-bindings: Add Crystal Clear Technology vendor prefix
dt-bindings: display: simple: add support for Crystal Clear
CMT430B19N00
drm/panel: simple: add CMT430B19N00 LCD panel support

.../bindings/display/panel/panel-simple.yaml | 2 ++
.../devicetree/bindings/vendor-prefixes.yaml | 2 ++
drivers/gpu/drm/panel/panel-simple.c | 29 +++++++++++++++++++
3 files changed, 33 insertions(+)

--
2.34.1



2024-02-23 13:46:25

by Jérémie Dautheribes

[permalink] [raw]
Subject: [PATCH 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support

Add support for Crystal Clear Technology CMT430B19N00 4.3" 480x272
TFT-LCD panel.

Signed-off-by: Jérémie Dautheribes <[email protected]>
---
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 20e3df1c59d4..b940220f56e2 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1457,6 +1457,32 @@ static const struct panel_desc boe_hv070wsa = {
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};

+static const struct drm_display_mode cct_cmt430b19n00_mode = {
+ .clock = 9000,
+ .hdisplay = 480,
+ .hsync_start = 480 + 43,
+ .hsync_end = 480 + 43 + 8,
+ .htotal = 480 + 43 + 8 + 4,
+ .vdisplay = 272,
+ .vsync_start = 272 + 12,
+ .vsync_end = 272 + 12 + 8,
+ .vtotal = 272 + 12 + 8 + 4,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc cct_cmt430b19n00 = {
+ .modes = &cct_cmt430b19n00_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 95,
+ .height = 53,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
+ .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = {
.clock = 9000,
.hdisplay = 480,
@@ -4402,6 +4428,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "boe,hv070wsa-100",
.data = &boe_hv070wsa
+ }, {
+ .compatible = "cct,cmt430b19n00",
+ .data = &cct_cmt430b19n00,
}, {
.compatible = "cdtech,s043wq26h-ct7",
.data = &cdtech_s043wq26h_ct7,
--
2.34.1


2024-02-26 08:30:03

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support

On 23/02/2024 14:45, Jérémie Dautheribes wrote:
> Add support for Crystal Clear Technology CMT430B19N00 4.3" 480x272
> TFT-LCD panel.
>
> Signed-off-by: Jérémie Dautheribes <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 20e3df1c59d4..b940220f56e2 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1457,6 +1457,32 @@ static const struct panel_desc boe_hv070wsa = {
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
> +static const struct drm_display_mode cct_cmt430b19n00_mode = {
> + .clock = 9000,
> + .hdisplay = 480,
> + .hsync_start = 480 + 43,
> + .hsync_end = 480 + 43 + 8,
> + .htotal = 480 + 43 + 8 + 4,
> + .vdisplay = 272,
> + .vsync_start = 272 + 12,
> + .vsync_end = 272 + 12 + 8,
> + .vtotal = 272 + 12 + 8 + 4,
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc cct_cmt430b19n00 = {
> + .modes = &cct_cmt430b19n00_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 95,
> + .height = 53,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
> + .connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
> static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = {
> .clock = 9000,
> .hdisplay = 480,
> @@ -4402,6 +4428,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "boe,hv070wsa-100",
> .data = &boe_hv070wsa
> + }, {
> + .compatible = "cct,cmt430b19n00",
> + .data = &cct_cmt430b19n00,
> }, {
> .compatible = "cdtech,s043wq26h-ct7",
> .data = &cdtech_s043wq26h_ct7,

Reviewed-by: Neil Armstrong <[email protected]>

2024-02-26 21:37:43

by Jessica Zhang

[permalink] [raw]
Subject: Re: [PATCH 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support



On 2/23/2024 5:45 AM, Jérémie Dautheribes wrote:
> Add support for Crystal Clear Technology CMT430B19N00 4.3" 480x272
> TFT-LCD panel.
>
> Signed-off-by: Jérémie Dautheribes <[email protected]>

Hi Jérémie,

Reviewed-by: Jessica Zhang <[email protected]>

Thanks,

Jessica Zhang

> ---
> drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 20e3df1c59d4..b940220f56e2 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1457,6 +1457,32 @@ static const struct panel_desc boe_hv070wsa = {
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
> +static const struct drm_display_mode cct_cmt430b19n00_mode = {
> + .clock = 9000,
> + .hdisplay = 480,
> + .hsync_start = 480 + 43,
> + .hsync_end = 480 + 43 + 8,
> + .htotal = 480 + 43 + 8 + 4,
> + .vdisplay = 272,
> + .vsync_start = 272 + 12,
> + .vsync_end = 272 + 12 + 8,
> + .vtotal = 272 + 12 + 8 + 4,
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc cct_cmt430b19n00 = {
> + .modes = &cct_cmt430b19n00_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 95,
> + .height = 53,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
> + .connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
> static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = {
> .clock = 9000,
> .hdisplay = 480,
> @@ -4402,6 +4428,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "boe,hv070wsa-100",
> .data = &boe_hv070wsa
> + }, {
> + .compatible = "cct,cmt430b19n00",
> + .data = &cct_cmt430b19n00,
> }, {
> .compatible = "cdtech,s043wq26h-ct7",
> .data = &cdtech_s043wq26h_ct7,
> --
> 2.34.1
>