2019-10-02 17:47:15

by Aliasgar Surti

Subject: [PATCH] gfs2: removed unnecessary semicolon

From: Aliasgar Surti <[email protected]>

There is use of unnecessary semicolon after switch case.
Removed the semicolon.

Signed-off-by: Aliasgar Surti <[email protected]>
---
fs/gfs2/recovery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
index c529f8749a89..f4aa8551277b 100644
--- a/fs/gfs2/recovery.c
+++ b/fs/gfs2/recovery.c
@@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)

default:
goto fail;
- };
+ }

error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
--
2.17.1

2019-10-04 15:50:49

by Bob Peterson

Subject: Re: [PATCH] gfs2: removed unnecessary semicolon

----- Original Message -----
> From: Aliasgar Surti <[email protected]>
>
> There is use of unnecessary semicolon after switch case.
> Removed the semicolon.
>
> Signed-off-by: Aliasgar Surti <[email protected]>
> ---
> fs/gfs2/recovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> index c529f8749a89..f4aa8551277b 100644
> --- a/fs/gfs2/recovery.c
> +++ b/fs/gfs2/recovery.c
> @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
>
> default:
> goto fail;
> - };
> + }
>
> error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
> LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
> --
> 2.17.1

Hi,

Thanks for the patch. I did a quick search and found two more:

glops.c- break;
glops.c: };

inode.c- goto out_gunlock;
inode.c: };

Do you want to include those in your patch and re-submit it or
should I cook up a second patch?

Regards,

Bob Peterson
Red Hat File Systems

2019-10-04 17:22:56

by Bob Peterson

Subject: Re: [Cluster-devel] [PATCH] gfs2: removed unnecessary semicolon

----- Original Message -----
> ----- Original Message -----
> > From: Aliasgar Surti <[email protected]>
> >
> > There is use of unnecessary semicolon after switch case.
> > Removed the semicolon.
> >
> > Signed-off-by: Aliasgar Surti <[email protected]>
> > ---
> > fs/gfs2/recovery.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> > index c529f8749a89..f4aa8551277b 100644
> > --- a/fs/gfs2/recovery.c
> > +++ b/fs/gfs2/recovery.c
> > @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
> >
> > default:
> > goto fail;
> > - };
> > + }
> >
> > error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
> > LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
> > --
> > 2.17.1
>
> Hi,
>
> Thanks for the patch. I did a quick search and found two more:
>
> glops.c- break;
> glops.c: };
>
> inode.c- goto out_gunlock;
> inode.c: };
>
> Do you want to include those in your patch and re-submit it or
> should I cook up a second patch?

Hi,

I just went ahead and added the two above to your patch and pushed
it to for-next. Thanks.

Regards,

Bob Peterson