2022-04-04 21:37:57

by Alaa Mohamed

Subject: [PATCH 2/2] staging: r8188eu: Add line after declarations

Reported by checkpatch:

WARNING: Missing a blank line after declarations

Signed-off-by: Alaa Mohamed <[email protected]>
---
drivers/staging/r8188eu/core/rtw_br_ext.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
index 7c664f80fa99..f7811b46db1c 100644
--- a/drivers/staging/r8188eu/core/rtw_br_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
@@ -313,6 +313,7 @@ void nat25_db_cleanup(struct adapter *priv)

for (i = 0; i < NAT25_HASH_SIZE; i++) {
struct nat25_network_db_entry *f;
+
f = priv->nethash[i];
while (f) {
struct nat25_network_db_entry *g;
@@ -339,12 +340,12 @@ void nat25_db_expire(struct adapter *priv)

for (i = 0; i < NAT25_HASH_SIZE; i++) {
struct nat25_network_db_entry *f;
- f = priv->nethash[i];

+ f = priv->nethash[i];
while (f) {
struct nat25_network_db_entry *g;
- g = f->next_hash;

+ g = f->next_hash;
if (__nat25_has_expired(f)) {
if (atomic_dec_and_test(&f->use_count)) {
if (priv->scdb_entry == f) {
--
2.35.1

2022-04-05 00:31:37

by Larry Finger

Subject: Re: [PATCH 2/2] staging: r8188eu: Add line after declarations

On 4/4/22 09:39, Alaa Mohamed wrote:
> Reported by checkpatch:
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Alaa Mohamed <[email protected]>
> ---
> drivers/staging/r8188eu/core/rtw_br_ext.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> index 7c664f80fa99..f7811b46db1c 100644
> --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> @@ -313,6 +313,7 @@ void nat25_db_cleanup(struct adapter *priv)
>
> for (i = 0; i < NAT25_HASH_SIZE; i++) {
> struct nat25_network_db_entry *f;
> +
> f = priv->nethash[i];
> while (f) {
> struct nat25_network_db_entry *g;
> @@ -339,12 +340,12 @@ void nat25_db_expire(struct adapter *priv)
>
> for (i = 0; i < NAT25_HASH_SIZE; i++) {
> struct nat25_network_db_entry *f;
> - f = priv->nethash[i];
>
> + f = priv->nethash[i];
> while (f) {
> struct nat25_network_db_entry *g;
> - g = f->next_hash;
>
> + g = f->next_hash;
> if (__nat25_has_expired(f)) {
> if (atomic_dec_and_test(&f->use_count)) {
> if (priv->scdb_entry == f) {

Acked_by: Larry Finger <[email protected]>

That applies to both patches.

Thanks,

Larry

2022-04-06 12:20:15

by Greg Kroah-Hartman

Subject: Re: [PATCH 2/2] staging: r8188eu: Add line after declarations

On Mon, Apr 04, 2022 at 01:47:33PM -0500, Larry Finger wrote:
> On 4/4/22 09:39, Alaa Mohamed wrote:
> > Reported by checkpatch:
> >
> > WARNING: Missing a blank line after declarations
> >
> > Signed-off-by: Alaa Mohamed <[email protected]>
> > ---
> > drivers/staging/r8188eu/core/rtw_br_ext.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> > index 7c664f80fa99..f7811b46db1c 100644
> > --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> > +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> > @@ -313,6 +313,7 @@ void nat25_db_cleanup(struct adapter *priv)
> > for (i = 0; i < NAT25_HASH_SIZE; i++) {
> > struct nat25_network_db_entry *f;
> > +
> > f = priv->nethash[i];
> > while (f) {
> > struct nat25_network_db_entry *g;
> > @@ -339,12 +340,12 @@ void nat25_db_expire(struct adapter *priv)
> > for (i = 0; i < NAT25_HASH_SIZE; i++) {
> > struct nat25_network_db_entry *f;
> > - f = priv->nethash[i];
> > + f = priv->nethash[i];
> > while (f) {
> > struct nat25_network_db_entry *g;
> > - g = f->next_hash;
> > + g = f->next_hash;
> > if (__nat25_has_expired(f)) {
> > if (atomic_dec_and_test(&f->use_count)) {
> > if (priv->scdb_entry == f) {
>
> Acked_by: Larry Finger <[email protected]>
>
> That applies to both patches.

b4 doesn't pick this ack up for both patches, you either need to do it
on the 0/X message, or on each one individually.

thanks,

greg k-h