This patchset is trying to fix problems seen on S905X boards when interfacing
with an ILI9486 equipped SPI panel.
To: Kamlesh Gurudasani <[email protected]>
To: David Airlie <[email protected]>
To: Daniel Vetter <[email protected]>
To: Mark Brown <[email protected]>
To: Neil Armstrong <[email protected]>
To: Kevin Hilman <[email protected]>
To: Jerome Brunet <[email protected]>
To: Martin Blumenstingl <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Carlo Caione <[email protected]>
---
Changes in v4:
- Removed NAK-ed patch from patchset
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Added trailers
- Added new patch to use drm_aperture_remove_framebuffers()
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Removed SPICC patch
- Reworked commit message
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Carlo Caione (2):
drm/tiny: ili9486: Enable driver module autoloading
drm/tiny: ili9486: Do not assume 8-bit only SPI controllers
drivers/gpu/drm/tiny/ili9486.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
---
base-commit: 84e57d292203a45c96dbcb2e6be9dd80961d981a
change-id: 20221116-s905x_spi_ili9486-aed54ff3cb21
Best regards,
--
Carlo Caione
The pixel data for the ILI9486 is always 16-bits wide and it must be
sent over the SPI bus. When the controller is only able to deal with
8-bit transfers, this 16-bits data needs to be swapped before the
sending to account for the big endian bus, this is on the contrary not
needed when the SPI controller already supports 16-bits transfers.
The decision about swapping the pixel data or not is taken in the MIPI
DBI code by probing the controller capabilities: if the controller only
suppors 8-bit transfers the data is swapped, otherwise it is not.
This swapping/non-swapping is relying on the assumption that when the
controller does support 16-bit transactions then the data is sent
unswapped in 16-bits-per-word over SPI.
The problem with the ILI9486 driver is that it is forcing 8-bit
transactions also for controllers supporting 16-bits, violating the
assumption and corrupting the pixel data.
Align the driver to what is done in the MIPI DBI code by adjusting the
transfer size to the maximum allowed by the SPI controller.
Reviewed-by: Neil Armstrong <[email protected]>
Signed-off-by: Carlo Caione <[email protected]>
---
drivers/gpu/drm/tiny/ili9486.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
index 8bf0dca0b05d..6f03531175bd 100644
--- a/drivers/gpu/drm/tiny/ili9486.c
+++ b/drivers/gpu/drm/tiny/ili9486.c
@@ -43,6 +43,7 @@ static int waveshare_command(struct mipi_dbi *mipi, u8 *cmd, u8 *par,
size_t num)
{
struct spi_device *spi = mipi->spi;
+ unsigned int bpw = 8;
void *data = par;
u32 speed_hz;
int i, ret;
@@ -56,8 +57,6 @@ static int waveshare_command(struct mipi_dbi *mipi, u8 *cmd, u8 *par,
* The displays are Raspberry Pi HATs and connected to the 8-bit only
* SPI controller, so 16-bit command and parameters need byte swapping
* before being transferred as 8-bit on the big endian SPI bus.
- * Pixel data bytes have already been swapped before this function is
- * called.
*/
buf[0] = cpu_to_be16(*cmd);
gpiod_set_value_cansleep(mipi->dc, 0);
@@ -71,12 +70,18 @@ static int waveshare_command(struct mipi_dbi *mipi, u8 *cmd, u8 *par,
for (i = 0; i < num; i++)
buf[i] = cpu_to_be16(par[i]);
num *= 2;
- speed_hz = mipi_dbi_spi_cmd_max_speed(spi, num);
data = buf;
}
+ /*
+ * Check whether pixel data bytes needs to be swapped or not
+ */
+ if (*cmd == MIPI_DCS_WRITE_MEMORY_START && !mipi->swap_bytes)
+ bpw = 16;
+
gpiod_set_value_cansleep(mipi->dc, 1);
- ret = mipi_dbi_spi_transfer(spi, speed_hz, 8, data, num);
+ speed_hz = mipi_dbi_spi_cmd_max_speed(spi, num);
+ ret = mipi_dbi_spi_transfer(spi, speed_hz, bpw, data, num);
free:
kfree(buf);
--
b4 0.10.1
SPI devices use the spi_device_id for module autoloading even on
systems using device tree.
Add the spi_device_id entry to enable autoloading for the 3.5inch RPi
Display (rpi-lcd-35 and piscreen).
Reviewed-by: Neil Armstrong <[email protected]>
Signed-off-by: Carlo Caione <[email protected]>
---
drivers/gpu/drm/tiny/ili9486.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
index 1bb847466b10..8bf0dca0b05d 100644
--- a/drivers/gpu/drm/tiny/ili9486.c
+++ b/drivers/gpu/drm/tiny/ili9486.c
@@ -183,6 +183,8 @@ MODULE_DEVICE_TABLE(of, ili9486_of_match);
static const struct spi_device_id ili9486_id[] = {
{ "ili9486", 0 },
+ { "rpi-lcd-35", 0 },
+ { "piscreen", 0 },
{ }
};
MODULE_DEVICE_TABLE(spi, ili9486_id);
--
b4 0.10.1
Hi Kamlesh,
On 19/12/2022 10:02, Carlo Caione wrote:
> This patchset is trying to fix problems seen on S905X boards when interfacing
> with an ILI9486 equipped SPI panel.
I fully reviewed both patches, but I'd like a review from the maintainer,
can you have a look ?
Thanks,
Neil
>
> To: Kamlesh Gurudasani <[email protected]>
> To: David Airlie <[email protected]>
> To: Daniel Vetter <[email protected]>
> To: Mark Brown <[email protected]>
> To: Neil Armstrong <[email protected]>
> To: Kevin Hilman <[email protected]>
> To: Jerome Brunet <[email protected]>
> To: Martin Blumenstingl <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Carlo Caione <[email protected]>
>
> ---
> Changes in v4:
> - Removed NAK-ed patch from patchset
> - Link to v3: https://lore.kernel.org/r/[email protected]
>
> Changes in v3:
> - Added trailers
> - Added new patch to use drm_aperture_remove_framebuffers()
> - Link to v2: https://lore.kernel.org/r/[email protected]
>
> Changes in v2:
> - Removed SPICC patch
> - Reworked commit message
> - Link to v1: https://lore.kernel.org/r/[email protected]
>
> ---
> Carlo Caione (2):
> drm/tiny: ili9486: Enable driver module autoloading
> drm/tiny: ili9486: Do not assume 8-bit only SPI controllers
>
> drivers/gpu/drm/tiny/ili9486.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
> ---
> base-commit: 84e57d292203a45c96dbcb2e6be9dd80961d981a
> change-id: 20221116-s905x_spi_ili9486-aed54ff3cb21
>
> Best regards,
Hi,
On Mon, 19 Dec 2022 10:02:36 +0100, Carlo Caione wrote:
> This patchset is trying to fix problems seen on S905X boards when interfacing
> with an ILI9486 equipped SPI panel.
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/2] drm/tiny: ili9486: Enable driver module autoloading
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=e9c7cfe7b71d26ee4a9f17192632f3d0ff246001
[2/2] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=77772e607522daa61f3af74df018559db75c43d6
--
Neil
Hi
Am 19.12.22 um 10:02 schrieb Carlo Caione:
> SPI devices use the spi_device_id for module autoloading even on
> systems using device tree.
>
> Add the spi_device_id entry to enable autoloading for the 3.5inch RPi
> Display (rpi-lcd-35 and piscreen).
>
> Reviewed-by: Neil Armstrong <[email protected]>
> Signed-off-by: Carlo Caione <[email protected]>
> ---
> drivers/gpu/drm/tiny/ili9486.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
> index 1bb847466b10..8bf0dca0b05d 100644
> --- a/drivers/gpu/drm/tiny/ili9486.c
> +++ b/drivers/gpu/drm/tiny/ili9486.c
> @@ -183,6 +183,8 @@ MODULE_DEVICE_TABLE(of, ili9486_of_match);
>
> static const struct spi_device_id ili9486_id[] = {
> { "ili9486", 0 },
> + { "rpi-lcd-35", 0 },
> + { "piscreen", 0 },
Alphabetical sorting please.
With that:
Reviewed-by: Thomas Zimmermann <[email protected]>
Best regards
Thomas
> { }
> };
> MODULE_DEVICE_TABLE(spi, ili9486_id);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev