There's another OLED panel needs to use DPCD aux interface to control
backlight.
BugLink: https://bugs.launchpad.net/bugs/1860303
Signed-off-by: Kai-Heng Feng <[email protected]>
---
drivers/gpu/drm/drm_dp_helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 8ba4531e808d..a0d4314663de 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1301,6 +1301,8 @@ static const struct edid_quirk edid_quirk_list[] = {
* only supports DPCD backlight controls
*/
{ MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
+ /* HP Spectre x360 Convertible 13t-aw100 */
+ { MFG(0x4c, 0x83), PROD_ID(0x42, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
/*
* Some Dell CML 2020 systems have panels support both AUX and PWM
* backlight control, and some only support AUX backlight control. All
--
2.17.1
Hi,
> On Mar 23, 2020, at 13:35, Kai-Heng Feng <[email protected]> wrote:
>
> There's another OLED panel needs to use DPCD aux interface to control
> backlight.
>
> BugLink: https://bugs.launchpad.net/bugs/1860303
> Signed-off-by: Kai-Heng Feng <[email protected]>
Would it be possible to review this?
I'd like to send a similar quirk for a new panel, and I want to avoid causing any merge conflict.
Kai-Heng
> ---
> drivers/gpu/drm/drm_dp_helper.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 8ba4531e808d..a0d4314663de 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1301,6 +1301,8 @@ static const struct edid_quirk edid_quirk_list[] = {
> * only supports DPCD backlight controls
> */
> { MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> + /* HP Spectre x360 Convertible 13t-aw100 */
> + { MFG(0x4c, 0x83), PROD_ID(0x42, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> /*
> * Some Dell CML 2020 systems have panels support both AUX and PWM
> * backlight control, and some only support AUX backlight control. All
> --
> 2.17.1
>
> On Mar 27, 2020, at 19:03, Kai-Heng Feng <[email protected]> wrote:
>
> Hi,
>
>> On Mar 23, 2020, at 13:35, Kai-Heng Feng <[email protected]> wrote:
>>
>> There's another OLED panel needs to use DPCD aux interface to control
>> backlight.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1860303
>> Signed-off-by: Kai-Heng Feng <[email protected]>
>
> Would it be possible to review this?
> I'd like to send a similar quirk for a new panel, and I want to avoid causing any merge conflict.
Another gentle ping...
>
> Kai-Heng
>
>> ---
>> drivers/gpu/drm/drm_dp_helper.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
>> index 8ba4531e808d..a0d4314663de 100644
>> --- a/drivers/gpu/drm/drm_dp_helper.c
>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>> @@ -1301,6 +1301,8 @@ static const struct edid_quirk edid_quirk_list[] = {
>> * only supports DPCD backlight controls
>> */
>> { MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>> + /* HP Spectre x360 Convertible 13t-aw100 */
>> + { MFG(0x4c, 0x83), PROD_ID(0x42, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>> /*
>> * Some Dell CML 2020 systems have panels support both AUX and PWM
>> * backlight control, and some only support AUX backlight control. All
>> --
>> 2.17.1
>>
>
On Tue, 07 Apr 2020, Kai-Heng Feng <[email protected]> wrote:
>> On Mar 27, 2020, at 19:03, Kai-Heng Feng <[email protected]> wrote:
>>
>> Hi,
>>
>>> On Mar 23, 2020, at 13:35, Kai-Heng Feng <[email protected]> wrote:
>>>
>>> There's another OLED panel needs to use DPCD aux interface to control
>>> backlight.
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1860303
>>> Signed-off-by: Kai-Heng Feng <[email protected]>
>>
>> Would it be possible to review this?
>> I'd like to send a similar quirk for a new panel, and I want to avoid causing any merge conflict.
>
> Another gentle ping...
Can't really review, but if you say that's needed...
Acked-by: Jani Nikula <[email protected]>
>
>>
>> Kai-Heng
>>
>>> ---
>>> drivers/gpu/drm/drm_dp_helper.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
>>> index 8ba4531e808d..a0d4314663de 100644
>>> --- a/drivers/gpu/drm/drm_dp_helper.c
>>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>>> @@ -1301,6 +1301,8 @@ static const struct edid_quirk edid_quirk_list[] = {
>>> * only supports DPCD backlight controls
>>> */
>>> { MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>>> + /* HP Spectre x360 Convertible 13t-aw100 */
>>> + { MFG(0x4c, 0x83), PROD_ID(0x42, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>>> /*
>>> * Some Dell CML 2020 systems have panels support both AUX and PWM
>>> * backlight control, and some only support AUX backlight control. All
>>> --
>>> 2.17.1
>>>
>>
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Graphics Center
> On Apr 8, 2020, at 15:22, Jani Nikula <[email protected]> wrote:
>
> On Tue, 07 Apr 2020, Kai-Heng Feng <[email protected]> wrote:
>>> On Mar 27, 2020, at 19:03, Kai-Heng Feng <[email protected]> wrote:
>>>
>>> Hi,
>>>
>>>> On Mar 23, 2020, at 13:35, Kai-Heng Feng <[email protected]> wrote:
>>>>
>>>> There's another OLED panel needs to use DPCD aux interface to control
>>>> backlight.
>>>>
>>>> BugLink: https://bugs.launchpad.net/bugs/1860303
>>>> Signed-off-by: Kai-Heng Feng <[email protected]>
>>>
>>> Would it be possible to review this?
>>> I'd like to send a similar quirk for a new panel, and I want to avoid causing any merge conflict.
>>
>> Another gentle ping...
>
> Can't really review, but if you say that's needed...
>
> Acked-by: Jani Nikula <[email protected]>
David,
Can you please merge this patch? Thanks.
Kai-Heng
>
>>
>>>
>>> Kai-Heng
>>>
>>>> ---
>>>> drivers/gpu/drm/drm_dp_helper.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
>>>> index 8ba4531e808d..a0d4314663de 100644
>>>> --- a/drivers/gpu/drm/drm_dp_helper.c
>>>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>>>> @@ -1301,6 +1301,8 @@ static const struct edid_quirk edid_quirk_list[] = {
>>>> * only supports DPCD backlight controls
>>>> */
>>>> { MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>>>> + /* HP Spectre x360 Convertible 13t-aw100 */
>>>> + { MFG(0x4c, 0x83), PROD_ID(0x42, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>>>> /*
>>>> * Some Dell CML 2020 systems have panels support both AUX and PWM
>>>> * backlight control, and some only support AUX backlight control. All
>>>> --
>>>> 2.17.1
>>>>
>>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> [email protected]
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Jani Nikula, Intel Open Source Graphics Center
Another gentle ping, this patch is still needed as of today.