Current wording in the binding documentation doesn't make it 100%
clear that only one of "INT1" and "INT2" will ever be used by the
driver and that specifying both has no advantages. Re-word it to make
this aspect a bit more explicit.
Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Jonathan Cameron <[email protected]>
Cc: Hartmut Knaack <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>
Cc: Peter Meerwald-Stadler <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Documentation/devicetree/bindings/iio/accel/mma8452.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
index e132394375a1..b27b6bee9eb6 100644
--- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
+++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
@@ -17,7 +17,7 @@ Optional properties:
- interrupts: interrupt mapping for GPIO IRQ
- - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
+ - interrupt-names: should contain "INT1" or "INT2", the accelerometer's
interrupt line in use.
- vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.
--
2.21.0
On Tue, 22 Oct 2019 10:43:09 +0200
Martin Kepplinger <[email protected]> wrote:
> On 22.10.19 05:56, Andrey Smirnov wrote:
> > Current wording in the binding documentation doesn't make it 100%
> > clear that only one of "INT1" and "INT2" will ever be used by the
> > driver and that specifying both has no advantages. Re-word it to make
> > this aspect a bit more explicit.
From a quick glance at the datasheet, it appears that the hardware
is capable of routing different interrupts to different pins, even
if the driver does not do so.
CTRL_REG5 has 6 different bits to set whether particular blocks have
their interrupt routed to INT1 or INT2, so it appears to be possible
to send some each way.
A binding is for the hardware not the driver, so if I'm right about this
the current text is correct and should be left alone.
Thanks,
Jonathan
> >
> > Signed-off-by: Andrey Smirnov <[email protected]>
> > Cc: Chris Healy <[email protected]>
> > Cc: Jonathan Cameron <[email protected]>
> > Cc: Hartmut Knaack <[email protected]>
> > Cc: Lars-Peter Clausen <[email protected]>
> > Cc: Peter Meerwald-Stadler <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > ---
> > Documentation/devicetree/bindings/iio/accel/mma8452.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > index e132394375a1..b27b6bee9eb6 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > @@ -17,7 +17,7 @@ Optional properties:
> >
> > - interrupts: interrupt mapping for GPIO IRQ
> >
> > - - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
> > + - interrupt-names: should contain "INT1" or "INT2", the accelerometer's
> > interrupt line in use.
> >
> > - vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.
> >
>
> Acked-by: Martin Kepplinger <[email protected]>
>
> thanks,
>
> martin
>
On 22.10.19 05:56, Andrey Smirnov wrote:
> Current wording in the binding documentation doesn't make it 100%
> clear that only one of "INT1" and "INT2" will ever be used by the
> driver and that specifying both has no advantages. Re-word it to make
> this aspect a bit more explicit.
>
> Signed-off-by: Andrey Smirnov <[email protected]>
> Cc: Chris Healy <[email protected]>
> Cc: Jonathan Cameron <[email protected]>
> Cc: Hartmut Knaack <[email protected]>
> Cc: Lars-Peter Clausen <[email protected]>
> Cc: Peter Meerwald-Stadler <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> Documentation/devicetree/bindings/iio/accel/mma8452.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> index e132394375a1..b27b6bee9eb6 100644
> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> @@ -17,7 +17,7 @@ Optional properties:
>
> - interrupts: interrupt mapping for GPIO IRQ
>
> - - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
> + - interrupt-names: should contain "INT1" or "INT2", the accelerometer's
> interrupt line in use.
>
> - vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.
>
Acked-by: Martin Kepplinger <[email protected]>
thanks,
martin
On 22.10.19 12:50, Jonathan Cameron wrote:
> On Tue, 22 Oct 2019 10:43:09 +0200
> Martin Kepplinger <[email protected]> wrote:
>
>> On 22.10.19 05:56, Andrey Smirnov wrote:
>>> Current wording in the binding documentation doesn't make it 100%
>>> clear that only one of "INT1" and "INT2" will ever be used by the
>>> driver and that specifying both has no advantages. Re-word it to make
>>> this aspect a bit more explicit.
>
> From a quick glance at the datasheet, it appears that the hardware
> is capable of routing different interrupts to different pins, even
> if the driver does not do so.
>
> CTRL_REG5 has 6 different bits to set whether particular blocks have
> their interrupt routed to INT1 or INT2, so it appears to be possible
> to send some each way.
>
> A binding is for the hardware not the driver, so if I'm right about this
> the current text is correct and should be left alone.
right, please ignore my "acked-by". Thanks a lot for taking a look.
martin