2019-02-13 02:39:21

by Randy Dunlap

Subject: [PATCH -next] net: ipvlan_l3s: fix kconfig unmet dependency warning

From: Randy Dunlap <[email protected]>

Fix the kconfig warning in IPVLAN_L3S when neither INET nor IPV6
is enabled:

WARNING: unmet direct dependencies detected for NET_L3_MASTER_DEV
Depends on [n]: NET [=y] && (INET [=n] || IPV6 [=n])
Selected by [y]:
- IPVLAN_L3S [=y] && NETDEVICES [=y] && NET_CORE [=y] && NETFILTER [=y]

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Mahesh Bandewar <[email protected]>
---
Seen in mmotm but applies to linux-next.

drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- mmotm-2019-0212-1537.orig/drivers/net/Kconfig
+++ mmotm-2019-0212-1537/drivers/net/Kconfig
@@ -147,6 +147,7 @@ config MACVTAP

config IPVLAN_L3S
depends on NETFILTER
+ depends on INET || IPV6 # same as NET_L3_MASTER_DEV
def_bool y
select NET_L3_MASTER_DEV

2019-02-13 13:50:52

by Daniel Borkmann

Subject: Re: [PATCH -next] net: ipvlan_l3s: fix kconfig unmet dependency warning

On 02/13/2019 03:02 AM, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix the kconfig warning in IPVLAN_L3S when neither INET nor IPV6
> is enabled:
>
> WARNING: unmet direct dependencies detected for NET_L3_MASTER_DEV
> Depends on [n]: NET [=y] && (INET [=n] || IPV6 [=n])
> Selected by [y]:
> - IPVLAN_L3S [=y] && NETDEVICES [=y] && NET_CORE [=y] && NETFILTER [=y]
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mahesh Bandewar <[email protected]>
> ---
> Seen in mmotm but applies to linux-next.
>
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- mmotm-2019-0212-1537.orig/drivers/net/Kconfig
> +++ mmotm-2019-0212-1537/drivers/net/Kconfig
> @@ -147,6 +147,7 @@ config MACVTAP
>
> config IPVLAN_L3S
> depends on NETFILTER
> + depends on INET || IPV6 # same as NET_L3_MASTER_DEV

Thanks for the fix! Lets just do the following instead ...

depends on IPVLAN

... and we should be all set. Please submit against net-next, thanks!

> def_bool y
> select NET_L3_MASTER_DEV
>
>
>