2022-05-21 06:59:11

by Doug Anderson

[permalink] [raw]
Subject: [PATCH v2] soc: qcom: socinfo: Add an ID for sc7180P

Some sc7180 Chromebooks actually have sc7180P (known by many names,
apparently, including possibly sc7180 Pro and sc7185). This is a
sc7180 part that has slightly higher clock speeds.

The official ID numbrer allocated to these devices by Qualcomm is 495
so we'll add an entry to the table for them. Note that currently
shipping BIOS for these devices will actually end up reporting an ID
of 407 due to a bug but eventually a new BIOS will be released which
corrects it to 495.

Signed-off-by: Douglas Anderson <[email protected]>
---

Changes in v2:
- Switch from 407 to 495.

drivers/soc/qcom/socinfo.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index cee579a267a6..c2c879ccc6c0 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -332,6 +332,7 @@ static const struct soc_id soc_id[] = {
{ 480, "SM8450" },
{ 482, "SM8450" },
{ 487, "SC7280" },
+ { 495, "SC7180P" },
};

static const char *socinfo_machine(struct device *dev, unsigned int id)
--
2.36.1.124.g0e6072fb45-goog



2022-05-21 21:32:14

by Sai Prakash Ranjan

[permalink] [raw]
Subject: Re: [PATCH v2] soc: qcom: socinfo: Add an ID for sc7180P

On 5/21/2022 4:23 AM, Douglas Anderson wrote:
> Some sc7180 Chromebooks actually have sc7180P (known by many names,
> apparently, including possibly sc7180 Pro and sc7185). This is a
> sc7180 part that has slightly higher clock speeds.
>
> The official ID numbrer allocated to these devices by Qualcomm is 495
> so we'll add an entry to the table for them. Note that currently
> shipping BIOS for these devices will actually end up reporting an ID
> of 407 due to a bug but eventually a new BIOS will be released which
> corrects it to 495.
>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---
>
> Changes in v2:
> - Switch from 407 to 495.
>
> drivers/soc/qcom/socinfo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index cee579a267a6..c2c879ccc6c0 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -332,6 +332,7 @@ static const struct soc_id soc_id[] = {
> { 480, "SM8450" },
> { 482, "SM8450" },
> { 487, "SC7280" },
> + { 495, "SC7180P" },
> };
>
> static const char *socinfo_machine(struct device *dev, unsigned int id)

Reviewed-by: Sai Prakash Ranjan <[email protected]>

-Sai

2022-05-23 07:47:26

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v2] soc: qcom: socinfo: Add an ID for sc7180P

Quoting Douglas Anderson (2022-05-20 15:53:10)
> Some sc7180 Chromebooks actually have sc7180P (known by many names,
> apparently, including possibly sc7180 Pro and sc7185). This is a
> sc7180 part that has slightly higher clock speeds.
>
> The official ID numbrer allocated to these devices by Qualcomm is 495

s/numbrer/number/

> so we'll add an entry to the table for them. Note that currently
> shipping BIOS for these devices will actually end up reporting an ID
> of 407 due to a bug but eventually a new BIOS will be released which
> corrects it to 495.
>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>