2023-07-18 21:05:42

by Bjorn Helgaas

Subject: [PATCH] m68k/pci: Drop useless pcibios_setup()

From: Bjorn Helgaas <[email protected]>

The PCI core supplies a weak pcibios_setup() implementation that is
identical to the m68k implementation. Remove the m68k version since it is
unnecessary.

Signed-off-by: Bjorn Helgaas <[email protected]>
---
arch/m68k/kernel/pcibios.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c
index b0e110d3d2e6..9504eb19d73a 100644
--- a/arch/m68k/kernel/pcibios.c
+++ b/arch/m68k/kernel/pcibios.c
@@ -92,9 +92,3 @@ void pcibios_fixup_bus(struct pci_bus *bus)
pci_write_config_byte(dev, PCI_LATENCY_TIMER, 32);
}
}
-
-char *pcibios_setup(char *str)
-{
- return str;
-}
-
--
2.34.1

2023-07-19 05:08:28

by Greg Ungerer

Subject: Re: [PATCH] m68k/pci: Drop useless pcibios_setup()

Hi Bjorn,

On 19/7/23 06:42, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> The PCI core supplies a weak pcibios_setup() implementation that is
> identical to the m68k implementation. Remove the m68k version since it is
> unnecessary.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>

Thanks. Seeing as this is related to the ColdFire parts I'll take this through
the m68knommu git tree. Applied to the for-next branch.

Regards
Greg


> ---
> arch/m68k/kernel/pcibios.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c
> index b0e110d3d2e6..9504eb19d73a 100644
> --- a/arch/m68k/kernel/pcibios.c
> +++ b/arch/m68k/kernel/pcibios.c
> @@ -92,9 +92,3 @@ void pcibios_fixup_bus(struct pci_bus *bus)
> pci_write_config_byte(dev, PCI_LATENCY_TIMER, 32);
> }
> }
> -
> -char *pcibios_setup(char *str)
> -{
> - return str;
> -}
> -