2022-10-11 08:02:13

by Rajat Khandelwal

Subject: [PATCH v2] dt-bindings: iio: dac: Change the I2C slave address for ds4422/4424 to its correct value

The datasheet states that the slave address for the device is 0x20
when the pins A0 and A1 are ground. The DT binding has been using
0x10 as the value and I think it should be 0x20 as per datasheet.

Signed-off-by: Rajat Khandelwal <[email protected]>
---

v2:
1. Subject prefix added
2. DT bindings validated

Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
index 264fa7c5fe3a..1955b1a97cd6 100644
--- a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
@@ -38,7 +38,7 @@ examples:

dac@10 {
compatible = "maxim,ds4424";
- reg = <0x10>; /* When A0, A1 pins are ground */
+ reg = <0x20>; /* When A0, A1 pins are ground */
vcc-supply = <&vcc_3v3>;
};
};
--
2.34.1

2022-10-11 12:17:12

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] dt-bindings: iio: dac: Change the I2C slave address for ds4422/4424 to its correct value

On 12/10/2022 03:44, Rajat Khandelwal wrote:
> The datasheet states that the slave address for the device is 0x20
> when the pins A0 and A1 are ground. The DT binding has been using
> 0x10 as the value and I think it should be 0x20 as per datasheet.
>
> Signed-off-by: Rajat Khandelwal <[email protected]>
> ---
>
> v2:
> 1. Subject prefix added
> 2. DT bindings validated

No, still wrong. Nothing was validated.

>
> Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
> index 264fa7c5fe3a..1955b1a97cd6 100644
> --- a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
> @@ -38,7 +38,7 @@ examples:
>
> dac@10 {
> compatible = "maxim,ds4424";
> - reg = <0x10>; /* When A0, A1 pins are ground */
> + reg = <0x20>; /* When A0, A1 pins are ground */

Nothing improved here.

Best regards,
Krzysztof

2022-10-11 13:49:46

by Rob Herring (Arm)

Subject: Re: [PATCH v2] dt-bindings: iio: dac: Change the I2C slave address for ds4422/4424 to its correct value

On Wed, 12 Oct 2022 13:14:46 +0530, Rajat Khandelwal wrote:
> The datasheet states that the slave address for the device is 0x20
> when the pins A0 and A1 are ground. The DT binding has been using
> 0x10 as the value and I think it should be 0x20 as per datasheet.
>
> Signed-off-by: Rajat Khandelwal <[email protected]>
> ---
>
> v2:
> 1. Subject prefix added
> 2. DT bindings validated
>
> Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/iio/dac/maxim,ds4424.example.dts:22.20-26.15: Warning (i2c_bus_reg): /example-0/i2c/dac@10: I2C bus unit address format error, expected "20"

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.