2022-06-01 11:08:20

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings

On 31/05/2022 13:59, Puranjay Mohan wrote:
> Hi Krzysztof,
>
> On 31/05/22 17:18, Krzysztof Kozlowski wrote:
>> On 31/05/2022 13:27, Puranjay Mohan wrote:
>>>>> +examples:
>>>>> + - |
>>>>> +
>>>>> + /* Example k3-am654 base board SR2.0, dual-emac */
>>>>> + pruss2_eth: pruss2_eth {
>>>>> + compatible = "ti,am654-icssg-prueth";
>>>>
>>>> Again missed Rob's comment.
>>>
>>> One of Rob's comment was to make the indentation as 4 which I have done.
>>
>> I clearly do not see indentation of 4, but there is 8 instead.
>
> I changed the indentation at the wrong place.
>
>>
>> Let's count:
>> + pruss2_eth: pruss2_eth {
> ^ here, it was 8 in v1 so, I changed it to 4
>
>> + compatible = "ti,am654-icssg-prueth";
>> 12345678^
>>
>
> Compatible is the child of pruss2_eth, so, It should have 4+4 = 8?

Yes. Indentation of four means first block is indented with 4 spaces.
The next block 4+4. The next one 4+4+4.

Best regards,
Krzysztof

2022-06-01 19:43:39

by Puranjay Mohan

Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings

Hi Krzysztof,

On 31/05/22 17:31, Krzysztof Kozlowski wrote:
> On 31/05/2022 13:59, Puranjay Mohan wrote:
>> Hi Krzysztof,
>>
>> On 31/05/22 17:18, Krzysztof Kozlowski wrote:
>>> On 31/05/2022 13:27, Puranjay Mohan wrote:
>>>>>> +examples:
>>>>>> + - |
>>>>>> +
>>>>>> + /* Example k3-am654 base board SR2.0, dual-emac */
>>>>>> + pruss2_eth: pruss2_eth {
>>>>>> + compatible = "ti,am654-icssg-prueth";
>>>>>
>>>>> Again missed Rob's comment.
>>>>
>>>> One of Rob's comment was to make the indentation as 4 which I have done.
>>>
>>> I clearly do not see indentation of 4, but there is 8 instead.
>>
>> I changed the indentation at the wrong place.
>>
>>>
>>> Let's count:
>>> + pruss2_eth: pruss2_eth {
>> ^ here, it was 8 in v1 so, I changed it to 4
>>
>>> + compatible = "ti,am654-icssg-prueth";
>>> 12345678^
>>>
>>
>> Compatible is the child of pruss2_eth, so, It should have 4+4 = 8?
>
> Yes. Indentation of four means first block is indented with 4 spaces.
> The next block 4+4. The next one 4+4+4.

Thanks for clearing my misunderstanding. I will fix all this in the next
version.

Thanks,
Puranjay

>
> Best regards,
> Krzysztof