2020-10-08 03:16:16

by Zhouyi Zhou

Subject: [PATCH] kprobes: Correct a type error in function kprobes_module_callback

There is a tiny type error in comment of function kprobes_module_callback.

Signed-off-by: Zhouyi Zhou <[email protected]>
---
kernel/kprobes.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index e995541..9d2042b 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
within_module_core((unsigned long)p->addr, mod))) {
/*
* The vaddr this probe is installed will soon
- * be vfreed buy not synced to disk. Hence,
+ * be vfreed but not synced to disk. Hence,
* disarming the breakpoint isn't needed.
*
* Note, this will also move any optimized probes
--
1.7.1

2020-10-08 03:16:33

by Randy Dunlap

Subject: Re: [PATCH] kprobes: Correct a type error in function kprobes_module_callback

Hi,

On 10/7/20 7:59 PM, Zhouyi Zhou wrote:
> There is a tiny type error in comment of function kprobes_module_callback.

Preferable
typo
and same in $Subject.

'type' usually means data type or maybe typedef, or even
font or typeface.

I suppose you could say a "typing" error (as in using a typewriter
or keyboard).

>
> Signed-off-by: Zhouyi Zhou <[email protected]>
> ---
> kernel/kprobes.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index e995541..9d2042b 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
> within_module_core((unsigned long)p->addr, mod))) {
> /*
> * The vaddr this probe is installed will soon
> - * be vfreed buy not synced to disk. Hence,
> + * be vfreed but not synced to disk. Hence,
> * disarming the breakpoint isn't needed.
> *
> * Note, this will also move any optimized probes
>

thanks.
--
~Randy

2020-10-08 04:17:56

by Zhouyi Zhou

Subject: Re: [PATCH] kprobes: Correct a type error in function kprobes_module_callback

Thanks for the tip!

On Thu, Oct 8, 2020 at 11:06 AM Randy Dunlap <[email protected]> wrote:
>
> Hi,
>
> On 10/7/20 7:59 PM, Zhouyi Zhou wrote:
> > There is a tiny type error in comment of function kprobes_module_callback.
>
> Preferable
> typo
> and same in $Subject.
>
> 'type' usually means data type or maybe typedef, or even
> font or typeface.
>
> I suppose you could say a "typing" error (as in using a typewriter
> or keyboard).
>
> >
> > Signed-off-by: Zhouyi Zhou <[email protected]>
> > ---
> > kernel/kprobes.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> > index e995541..9d2042b 100644
> > --- a/kernel/kprobes.c
> > +++ b/kernel/kprobes.c
> > @@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
> > within_module_core((unsigned long)p->addr, mod))) {
> > /*
> > * The vaddr this probe is installed will soon
> > - * be vfreed buy not synced to disk. Hence,
> > + * be vfreed but not synced to disk. Hence,
> > * disarming the breakpoint isn't needed.
> > *
> > * Note, this will also move any optimized probes
> >
>
> thanks.
> --
> ~Randy
>