2017-08-21 10:06:50

by Arvind Yadav

Subject: [PATCH] staging: vboxvideo: constify drm_fb_helper_funcs

drm_fb_helper_funcs are not supposed to change at runtime.
All functions working with drm_fb_helper_funcs provided by
<drm/drm_fb_helper.h> work with const drm_fb_helper_funcs.
So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/staging/vboxvideo/vbox_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
index 35f6d9f..70d99b7 100644
--- a/drivers/staging/vboxvideo/vbox_fb.c
+++ b/drivers/staging/vboxvideo/vbox_fb.c
@@ -330,7 +330,7 @@ static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green,
*blue = regno;
}

-static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
+static const struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
.gamma_set = vbox_fb_gamma_set,
.gamma_get = vbox_fb_gamma_get,
.fb_probe = vboxfb_create,
--
1.9.1

2017-08-21 11:36:42

by Hans de Goede

Subject: Re: [PATCH] staging: vboxvideo: constify drm_fb_helper_funcs

Hi,

On 21-08-17 12:06, Arvind Yadav wrote:
> drm_fb_helper_funcs are not supposed to change at runtime.
> All functions working with drm_fb_helper_funcs provided by
> <drm/drm_fb_helper.h> work with const drm_fb_helper_funcs.
> So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans


> ---
> drivers/staging/vboxvideo/vbox_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
> index 35f6d9f..70d99b7 100644
> --- a/drivers/staging/vboxvideo/vbox_fb.c
> +++ b/drivers/staging/vboxvideo/vbox_fb.c
> @@ -330,7 +330,7 @@ static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green,
> *blue = regno;
> }
>
> -static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
> +static const struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
> .gamma_set = vbox_fb_gamma_set,
> .gamma_get = vbox_fb_gamma_get,
> .fb_probe = vboxfb_create,
>

2017-08-23 01:33:33

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: vboxvideo: constify drm_fb_helper_funcs

On Mon, Aug 21, 2017 at 03:36:34PM +0530, Arvind Yadav wrote:
> drm_fb_helper_funcs are not supposed to change at runtime.
> All functions working with drm_fb_helper_funcs provided by
> <drm/drm_fb_helper.h> work with const drm_fb_helper_funcs.
> So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> Reviewed-by: Hans de Goede <[email protected]>
> ---
> drivers/staging/vboxvideo/vbox_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree :(