2002-03-21 16:16:39

by Jean-Luc Coulon (f5ibh)

[permalink] [raw]
Subject: 2.5.7 does not compile

make[3]: Entering directory
`/usr/src/kernel-sources-2.5.7/drivers/net/hamradio'
gcc -D__KERNEL__ -I/usr/src/kernel-sources-2.5.7/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=k6 -DMODULE -DMODVERSIONS -include
/usr/src/kernel-sources-2.5.7/include/linux/modversions.h
-DKBUILD_BASENAME=scc -c -o scc.o scc.c
scc.c: In function `scc_net_rx':
scc.c:1664: `dev' undeclared (first use in this function)
scc.c:1664: (Each undeclared identifier is reported only once
scc.c:1664: for each function it appears in.)
make[3]: *** [scc.o] Error 1
make[3]: Leaving directory
`/usr/src/kernel-sources-2.5.7/drivers/net/hamradio'
make[2]: *** [_modsubdir_net/hamradio] Error 2
make[2]: Leaving directory `/usr/src/kernel-sources-2.5.7/drivers'
make[1]: *** [_mod_drivers] Error 2
make[1]: Leaving directory `/usr/src/kernel-sources-2.5.7'
make: *** [stamp-build] Error 2

-----------
Regards
Jean-Luc


2002-03-21 16:36:52

by Evgeniy Polyakov

[permalink] [raw]
Subject: Re: 2.5.7 does not compile

On Thu, 21 Mar 2002 17:15:49 +0100
Jean-Luc Coulon <[email protected]> wrote:

> make[3]: Entering directory
> `/usr/src/kernel-sources-2.5.7/drivers/net/hamradio'
> gcc -D__KERNEL__ -I/usr/src/kernel-sources-2.5.7/include -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
> -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
> -march=k6 -DMODULE -DMODVERSIONS -include
> /usr/src/kernel-sources-2.5.7/include/linux/modversions.h
> -DKBUILD_BASENAME=scc -c -o scc.o scc.c
> scc.c: In function `scc_net_rx':
> scc.c:1664: `dev' undeclared (first use in this function)
> scc.c:1664: (Each undeclared identifier is reported only once
> scc.c:1664: for each function it appears in.)
> make[3]: *** [scc.o] Error 1
> make[3]: Leaving directory
> `/usr/src/kernel-sources-2.5.7/drivers/net/hamradio'
> make[2]: *** [_modsubdir_net/hamradio] Error 2
> make[2]: Leaving directory `/usr/src/kernel-sources-2.5.7/drivers'
> make[1]: *** [_mod_drivers] Error 2
> make[1]: Leaving directory `/usr/src/kernel-sources-2.5.7'
> make: *** [stamp-build] Error 2

I hope this path will help you.

> -----------
> Regards
> Jean-Luc

Evgeniy Polyakov ( s0mbre )


Attachments:
drivers_net_hamradio_scc_c.diff (262.00 B)

2002-03-21 16:40:13

by Dave Jones

[permalink] [raw]
Subject: Re: 2.5.7 does not compile

On Thu, Mar 21, 2002 at 05:15:49PM +0100, Jean-Luc Coulon wrote:
> -DKBUILD_BASENAME=scc -c -o scc.o scc.c
> scc.c: In function `scc_net_rx':
> scc.c:1664: `dev' undeclared (first use in this function)

Line should read..

scc->dev->last_rx = jiffies;

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs

2002-03-22 06:53:38

by Hans-Joachim Hetscher

[permalink] [raw]
Subject: Re: 2.5.7 does not compile

Hallo,

It seeems to be the same bug in 6pack.c

So, I solved the problem in line 259 of 6pack.c by changing

dev->last_rx = jiffies;

into

sp->dev->last_rx = jiffies;



>>>>>>>>>>>>>>>>>> Urspr?ngliche Nachricht <<<<<<<<<<<<<<<<<<

Am 21.03.02, 17:45:01, schrieb [email protected] (Dave Jones) zum Thema Re:
2.5.7 does not compile:


> On Thu, Mar 21, 2002 at 05:15:49PM +0100, Jean-Luc Coulon wrote:
> > -DKBUILD_BASENAME=scc -c -o scc.o scc.c
> > scc.c: In function `scc_net_rx':
> > scc.c:1664: `dev' undeclared (first use in this function)

> Line should read..

> scc->dev->last_rx = jiffies;

vy 73 de Hans-Joachim

--

DD8NE : Hans-Joachim Hetscher IP-Adr. : [44.130.62.1]
amprNet : [email protected] AX25 :DD8NE@DB0LJ.#RPL.DEU.EU
Internet: [email protected] [email protected]

2002-03-22 08:35:09

by Dave Jones

[permalink] [raw]
Subject: Re: 2.5.7 does not compile

On Fri, Mar 22, 2002 at 06:53:48AM +0000, Hans-Joachim Hetscher wrote:
> It seeems to be the same bug in 6pack.c
> So, I solved the problem in line 259 of 6pack.c by changing
> dev->last_rx = jiffies;
> into
> sp->dev->last_rx = jiffies;

Yeah, it's a mystery how these broken versions of the fixes ended up
in Jeff's tree. He took them from my tree, and my tree already has this
and the previous corrected fix. really weird.

anyways, it's moot as all this is going to Jeff at the end of the week
anyway for his pushing to Linus on his return the following week 8-)

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs