2002-10-23 13:36:20

by Matthew Wilcox

[permalink] [raw]
Subject: kernel hooks interface available to non-GPL modules?


+EXPORT_SYMBOL(hook_exit_deregister);
+EXPORT_SYMBOL(hook_exit_arm);
+EXPORT_SYMBOL(hook_exit_disarm);
+EXPORT_SYMBOL(_hook_initialise);
+EXPORT_SYMBOL(_hook_terminate);
+EXPORT_SYMBOL(_hook_exit_register);

I'm not sure this is a great idea. OK, your DECLARE_HOOK macros are _GPL
(and why are they _NOVERS_GPL? Surely this is the exact kind of thing
you want versioned?), but I wouldn't have to use the DECLARE_HOOK macros,
would I?

If you thought the LSM GPL furore was bad, this one would be worse.

--
Revolutions do not require corporate support.


2002-10-24 06:50:28

by Vamsi Krishna S .

[permalink] [raw]
Subject: Re: kernel hooks interface available to non-GPL modules?


On Wed, Oct 23, 2002 at 02:42:27PM +0100, Matthew Wilcox wrote:
>
> I'm not sure this is a great idea. OK, your DECLARE_HOOK macros are _GPL
> (and why are they _NOVERS_GPL? Surely this is the exact kind of thing
> you want versioned?), but I wouldn't have to use the DECLARE_HOOK macros,
> would I?

I agree and have exported hook interfaces with _GPL in the latest version of
the patch. It will be at http://www-124.ibm.com/linux/patches/?patch_id=595.

--
Vamsi Krishna S.
Linux Technology Center,
IBM Software Lab, Bangalore.
Ph: +91 80 5044959
Internet: [email protected]