2002-11-20 10:36:19

by Mathiasen, Torben

[permalink] [raw]
Subject: [PATCH-2.5.47-ac6] Updates to BIOS IDE timings code

Hi Alan,

Attached is a patch that addresses some of the issues we discussed previously.
The patch does the following:

# Moves BIOS timings IDE detection into chipset drivers (by providing a
library function).
# Provide the above library function that sets default values for tune
parameters. It also handles the special case where user has requested
to use BIOS IDE timings. Caller is assumed to support DMA
on/off probe using the dma_status register unless a dma_check funtion
is provided (note, the tekram driver is somewhat different from all
the others, and haven't been updated yet).
# Makes BIOS IDE timings work for both IDE0 and IDE1 at the same time.

What hasn't been addresses yet, but that I'm working on is proper simplex
detection when 'biostimings' are used. However, to me it seems like the simplex
code is in the middle of being updated, right? On some chipsets we make just
dma_base isn't set on both interfaces if device claims to be simplex. On others
we force dma on both channels if simplex mode, why?

Tested with via82cxxx, serverworks and piix. 'biostimings' is only supported on
PCI chips.

More generic IDE cleanups are needed here and there, so thats probaly next.

Cheers,
Torben


Attachments:
(No filename) (1.20 kB)
ide_bios-2.5.47-ac6.diff (21.41 kB)
Download all attachments

2002-11-20 13:18:28

by Alan

[permalink] [raw]
Subject: Re: [PATCH-2.5.47-ac6] Updates to BIOS IDE timings code

On Wed, 2002-11-20 at 10:43, Torben Mathiasen wrote:
> What hasn't been addresses yet, but that I'm working on is proper simplex
> detection when 'biostimings' are used. However, to me it seems like the simplex
> code is in the middle of being updated, right? On some chipsets we make just
> dma_base isn't set on both interfaces if device claims to be simplex. On others
> we force dma on both channels if simplex mode, why?

See the documentation for the chips concerned, that ought to make it
more obvious. I dont think any of the examples I have docs for are
non-NDA'd 8(


Alan