2003-09-16 11:41:56

by Mikael Pettersson

Subject: agpgart's MODULE_ALIAS is broken

Dave,

With 2.6.0-test5, the generated alias for agpgart
in modules.alias looks wrong:

alias char-major-10-AGPGART_MINOR agpgart

Surely that should be char-major-10-175.

The problem is that AGP's MODULE_ALIAS_MISCDEV() is in
backend.c, but AGPGART_MINOR isn't #define:d there
because agpgart.h is only #include:d in frontend.c.
This causes MODULE_ALIAS_MISCDEV()'s __stringify()
to convert the token itself rather than its value.

Should be easy to fix (move the ALIAS or add #include).

/Mikael

2003-09-16 11:49:18

by Dave Jones

Subject: Re: agpgart's MODULE_ALIAS is broken

On Tue, Sep 16, 2003 at 01:41:52PM +0200, Mikael Pettersson wrote:

> With 2.6.0-test5, the generated alias for agpgart
> in modules.alias looks wrong:
>
> alias char-major-10-AGPGART_MINOR agpgart
>
> Surely that should be char-major-10-175.
>
> The problem is that AGP's MODULE_ALIAS_MISCDEV() is in
> backend.c, but AGPGART_MINOR isn't #define:d there
> because agpgart.h is only #include:d in frontend.c.
> This causes MODULE_ALIAS_MISCDEV()'s __stringify()
> to convert the token itself rather than its value.
>
> Should be easy to fix (move the ALIAS or add #include).

Should be fixed in agpgart bk tree. I'm waiting on Linus
to return before I push updates..

Dave

--
Dave Jones http://www.codemonkey.org.uk