2003-09-21 18:59:39

by Oleg Drokin

Subject: [PATCH] [2.4] devio.c memleak on unexpected disconnect

Hello!

There is a memleak in devio.c (User space communication with USB devices)
recently added, it forgets to free the buffer if device was disconnected.

The patch is trivial, please apply.
Found with help of smatch.


===== drivers/usb/devio.c 1.17 vs edited =====
--- 1.17/drivers/usb/devio.c Mon Aug 19 20:49:38 2002
+++ edited/drivers/usb/devio.c Sun Sep 21 22:51:15 2003
@@ -1114,7 +1114,7 @@
usb_driver_release_interface (driver, ifp);
up (&driver->serialize);
} else
- return -ENODATA;
+ retval = -ENODATA;
break;

/* let kernel drivers try to (re)bind to the interface */

2003-09-24 21:50:55

by Greg KH

Subject: Re: [PATCH] [2.4] devio.c memleak on unexpected disconnect

On Sun, Sep 21, 2003 at 10:59:22PM +0400, Oleg Drokin wrote:
> Hello!
>
> There is a memleak in devio.c (User space communication with USB devices)
> recently added, it forgets to free the buffer if device was disconnected.
>
> The patch is trivial, please apply.
> Found with help of smatch.

Applied to my trees, thanks.

greg k-h