ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.4-rc2/2.6.4-rc2-mm1/
- Added Jens's patch which teaches the kernel to use DMA when reading
audio from IDE CDROM drives. These devices tend to be flakey, and we
need lots of testing please.
- Re-added the device mapper update
- Brought back Ingo's patch which permits remap_file_pages() to set the
memory access permissions on a per-page basis. This is mainly interesting
for its very significant performance benefits to UML.
Breaks the build on most architectures. There are how-to-fix-it
instructions in the changelog.
- A new version of the patch which permits ext3 quota updates to be fully
journalled.
Changes since 2.6.4-rc1-mm2:
linus.patch
bk-acpi.patch
bk-alsa.patch
bk-input.patch
bk-netdev.patch
bk-scsi.patch
bk-usb.patch
Latest external trees
-fastcall-warning-fixes.patch
-fastcall-warning-fixes-2.patch
-ppc64-xmon-survival-fix.patch
-put_compat_timespec-prototype-fix.patch
-sparc-sys_ioperm-fix.patch
-support-zillions-of-scsi-disks.patch
-tulip-printk-cleanup.patch
-parport-01-move-exports.patch
-parport-02-use-module_init.patch
-parport-03-sysctls-use-module_init.patch
-parport-04-move-option-parsing.patch
-parport-irq-warning-fix.patch
-parport-05-parport_pc_probe_port-fixes.patch
-parport-06-refcounting-fixes.patch
-parport-07-unregister-fixes.patch
-parport-08-parport_announce-cleanups.patch
-parport-09-track-used-ports.patch
-parport-09-track-used-ports-fix.patch
-parport-10-sunbpp-track-ports.patch
-parport-11-remove-parport_enumerate.patch
-parport-12-driver-list-cleanup.patch
-hitachi-scsi_devinfo-fix.patch
-zwane-is-floppy-maintainer-now.patch
-rioctrl-retval-fixes.patch
-initrd-kconfig-dependencies.patch
-queue-congestion-callout.patch
-queue-congestion-dm-implementation.patch
-cs46_xx-c99-fix.patch
-remove-nlmclnt_grace_wait.patch
-HPFS3-hpfs_iget-RC4-rc1.patch
-HPFS4-hpfs_lock_iget-RC4-rc1.patch
-HPFS5-hpfs_locking-RC4-rc1.patch
-HPFS6-hpfs_cleanup-RC4-rc1.patch
-HPFS7-hpfs_cleanup2-RC4-rc1.patch
-HPFS8-hpfs_race2-RC4-rc1.patch
-HPFS9-hpfs_deadlock-RC4-rc1.patch
-HPFS10-fix-RC4-rc1.patch
-alpha-switch-semaphores.patch
-serial_core-build-fix.patch
-sb16-sample-size-fix.patch
-ext2-ext3-ENOSPC-fix.patch
-missing-MODULE_LICENSEs.patch
-v4l1-compatibility-module-fix.patch
-i2o-fixes.patch
Merged
+move-dma_consistent_dma_mask-sn-fix.patch
Fix move-dma_consistent_dma_mask.patch for SN platforms
+export-filemap_flush.patch
XFS needs this symbol.
+vma-corruption-fix.patch
Fix nasty memory management race.
-ext3-journalled-quotas.patch
-ext3-journalled-quotas-warning-fix.patch
-ext3-journalled-quotas-cleanups.patch
+ext3-journalled-quotas-2.patch
New journal-quotas-on-ext3 patch.
+sched-smt-nice-optimisation.patch
CPU scheduler tuneup for SMT hardware.
+ide-scsi-error-handling-update.patch
Update to ide-scsi-error-handling-fixes.patch
-doc2000-warning-fixes.patch
Dropped - this driver is otherwise broken.
-scsi-host-allocation-fix.patch
A perfectly good patch dropped :( Apparently it will expose races in
userspace's handling of the existing /proc API's.
-remove-more-KERNEL_SYSCALLS-build-fix.patch
-remove-more-KERNEL_SYSCALLS-build-fix-2.patch
Folded into remove-more-KERNEL_SYSCALLS.patch
+mq-security-fix.patch
POSIX message queue fix
+dm-01-endio-method.patch
+dm-03-list_for_each_entry-audit.patch
+dm-04-default-queue-limits-fix.patch
+dm-05-list-targets-command.patch
+dm-06-stripe-width-fix.patch
Device Mapper update
+dm-maplock.patch
Add an rwlock to the device mapper maptable management so that
+queue-congestion-dm-implementation.patch does not try to take a semaphore
inside a spinlock.
-blk-unplug-when-max-request-queued.patch
This was buggy, and is hard to fix.
-pdc_202xx_old-update.patch
This broke, and was a duplicate of other IDE patches. I think. It got
very confusing in there.
+cdromaudio-use-dma.patch
Use IDE DMA for reading audio CDROMs
+sysfs-pin-kobject.patch
I was asked to bring back this sysfs race fix.
+ATI-IXP-IDE-support.patch
ATI IXP IDE support
+ipmi-updates-3.patch
+ipmi-socket-interface.patch
IPMI driver updates
+md-use-schedule_timeout.patch
Don't use yield() in the RAID drivers
+md-array-assembly-fix.patch
RAID fix
+compiler_h-scope-fixes.patch
Header file fix
+remap-file-pages-prot-2.6.4-rc1-mm1-A1.patch
Per-page permissions for remap_file_pages()
+nmi_watchdog-local-apic-fix.patch
+nmi-1-hz.patch
NMI watchdog fixes
+elf-mmap-fix.patch
Don't hardwire the mmap size.
+kbuild-more-cleaning.patch
Make `make clean' delete more things
+loop-setup-race-fix.patch
Loop race fix.
+handle-dot-o-paths.patch
kbuild pathname fix
+acpi-asmlinkage-fix.patch
ACPI build fix for current gcc
+ipc-sem-extra-sem_unlock.patch
Missing unlock in the IPC code.
+procfs-dangling-subdir-fix.patch
Trap buggy /proc users
+AMD-768MPX-bootmem-fix.patch
"works around the infamous "only works stable when a mouse is plugged in"
problem some AMD 768MPX Dual Athlon chipsets have"
+i810fb-on-x86_64.patch
Enable i810fb on x86_64
+ext23-remove-acl-limits.patch
ACL uture-proofness
+watchdog-moduleparam-patches.patch
Watchdog driver module parameter updates
+amd-elan-fix.patch
Conig fix for AMD ELAN.
+pcmcia-netdev-ordering-fixes.patch
Attempt to fix some ordering problems with PCMCIA netdevices.
-shrink-inode-cache-harder.patch
Drop this - it was entirely too speculative and might actually slow things
down.
+4g4g-handle_BUG-fix.patch
Fix the handling of BUG()s when using the 4:4 split.
+ppc-fixes-dependency-fix.patch
Make dependency fix
+restore-writeback-trylock.patch
More fiddling with the writebakc locking for the O_DIRECT-vs-buffered
problem. Am getting a bit tired of this problem.
+aio-direct-io-oops-fix.patch
Fix an AIO oops due to aio-fallback-bio_count-race-fix-2.patch
All 232 patches:
linus.patch
bk-acpi.patch
bk-alsa.patch
bk-input.patch
bk-netdev.patch
bk-scsi.patch
bk-usb.patch
mm.patch
add -mmN to EXTRAVERSION
dma_sync_for_device-cpu.patch
dma_sync_for_{cpu,device}()
move-dma_consistent_dma_mask.patch
move consistent_dma_mask to the generic device
move-dma_consistent_dma_mask-x86_64-fix.patch
move-dma_consistent_dma_mask-sn-fix.patch
Fix dma_mask patch for sn platform
kgdb-ga.patch
kgdb stub for ia32 (George Anzinger's one)
kgdbL warning fix
kgdb buffer overflow fix
kgdbL warning fix
kgdb: CONFIG_DEBUG_INFO fix
x86_64 fixes
correct kgdb.txt Documentation link (against 2.6.1-rc1-mm2)
kgdb-ga-recent-gcc-fix.patch
kgdb: fix for recent gcc
kgdboe-netpoll.patch
kgdb-over-ethernet via netpoll
kgdboe-non-ia32-build-fix.patch
kgdb-warning-fixes.patch
kgdb warning fixes
kgdb-x86_64-support.patch
kgdb-x86_64-support.patch for 2.6.2-rc1-mm3
kgdb-THREAD_SIZE-fixes.patch
THREAD_SIZE fixes for kgdb
export-filemap_flush.patch
export filemap_flush() to modules
vma-corruption-fix.patch
vma corruption fix
must-fix.patch
must fix lists update
must fix list update
mustfix update
must-fix-update-5.patch
must-fix update
ppc64-reloc_hide.patch
compat-signal-noarch-2004-01-29.patch
Generic 32-bit compat for copy_siginfo_to_user
compat-generic-ipc-emulation.patch
generic 32 bit emulation for System-V IPC
remove-sys_ioperm-stubs.patch
Clean up sys_ioperm stubs
readdir-cleanups.patch
readdir() cleanups
ext3-journalled-quotas-2.patch
ext3: journalled quota
invalidate_inodes-speedup.patch
invalidate_inodes speedup
more invalidate_inodes speedup fixes
cfq-4.patch
CFQ io scheduler
CFQ fixes
config_spinline.patch
uninline spinlocks for profiling accuracy.
pdflush-diag.patch
zap_page_range-debug.patch
zap_page_range() debug
get_user_pages-handle-VM_IO.patch
fix get_user_pages() against mappings of /dev/mem
pci_set_power_state-might-sleep.patch
CONFIG_STANDALONE-default-to-n.patch
Make CONFIG_STANDALONE default to N
extra-buffer-diags.patch
CONFIG_SYSFS.patch
From: Pat Mochel <[email protected]>
Subject: [PATCH] Add CONFIG_SYSFS
CONFIG_SYSFS-boot-from-disk-fix.patch
slab-leak-detector.patch
slab leak detector
mm/slab.c warning in cache_alloc_debugcheck_after
scale-nr_requests.patch
scale nr_requests with TCQ depth
truncate_inode_pages-check.patch
local_bh_enable-warning-fix.patch
sched-find_busiest_node-resolution-fix.patch
sched: improved resolution in find_busiest_node
sched-domains.patch
sched: scheduler domain support
sched: fix for NR_CPUS > BITS_PER_LONG
sched: clarify find_busiest_group
sched: find_busiest_group arithmetic fix
sched-domains-improvements.patch
sched domains kernbench improvements
sched-clock-fixes.patch
fix sched_clock()
sched-sibling-map-to-cpumask.patch
sched: cpu_sibling_map to cpu_mask
p4-clockmod sibling_map fix
p4-clockmod: handle more than two siblings
sched-domains-i386-ht.patch
sched: implement domains for i386 HT
sched: Fix CONFIG_SMT oops on UP
sched: fix SMT + NUMA bug
Change arch_init_sched_domains to use cpu_online_map
Fix build with NR_CPUS > BITS_PER_LONG
sched-domain-tweak.patch
i386-sched-domain code consolidation
sched-no-drop-balance.patch
sched: handle inter-CPU jiffies skew
sched-directed-migration.patch
sched_balance_exec(): don't fiddle with the cpus_allowed mask
sched-domain-debugging.patch
sched_domain debugging
sched-domain-balancing-improvements.patch
scheduler domain balancing improvements
sched-group-power.patch
sched-group-power
sched-group-power warning fixes
sched-domains-use-cpu_possible_map.patch
sched_domains: use cpu_possible_map
sched-smt-nice-handling.patch
sched: SMT niceness handling
sched-smt-nice-optimisation.patch
sched: SMT-ice optimisation
fa311-mac-address-fix.patch
wrong mac address with netgear FA311 ethernet card
laptop-mode-2.patch
laptop-mode for 2.6, version 6
Documentation/laptop-mode.txt
laptop-mode documentation updates
Laptop mode documentation addition
laptop mode simplification
pid_max-fix.patch
Bug when setting pid_max > 32k
use-soft-float.patch
Use -msoft-float
DRM-cvs-update.patch
DRM cvs update
drm-include-fix.patch
process-migration-speedup.patch
Reduce TLB flushing during process migration
hotplugcpu-generalise-bogolock.patch
Atomic Hotplug CPU: Generalize Bogolock
hotplugcpu-generalise-bogolock-fix-for-kthread-stop-using-signals.patch
hotplugcpu-use-bogolock-in-modules.patch
Atomic Hotplug CPU: Use Bogolock in module.c
hotplugcpu-core.patch
Atomic Hotplug CPU: Hotplug CPU Core
stop_machine-warning-fix.patch
hotplugcpu-core-sparc64-build-fix.patch
hotplugcpu-core sparc64 build fix
hotplugcpu-core-fix-for-kthread-stop-using-signals.patch
migrate_to_cpu-dependency-fix.patch
migrate_to_cpu() dependency fix
hotplugcpu-core-drain_local_pages-fix.patch
split drain_local_pages
hotplugcpu-rcupdate-many-cpus-fix.patch
CPU hotplug, rcupdate high NR_CPUS fix
nfs-31-attr.patch
NFSv2/v3/v4: New attribute revalidation code
nfs-reconnect-fix.patch
nfs-mount-fix.patch
Update to NFS mount....
nfs-d_drop-lowmem.patch
NFS: handle nfs_fhget() error
nfs-avoid-i_size_write.patch
NFS: avoid unlocked i_size_write()
nfs_unlink-oops-fix.patch
nfs: fix "busy inodes after umount"
nfs-remove-XID-spinlock.patch
nfs: Remove an unnecessary spinlock from XID generation...
nfs-misc-rpc-fixes.patch
nfs: Misc RPC fixes...
nfs-improved-writeback-strategy.patch
nfs: improve writeback caching
nfs-simplify-config-options.patch
nfs: simplify client configuration options.
nfs-fix-msync.patch
nfs: fix msync()
nfs-mount-return-useful-errors.patch
nfs: make mount command return more useful errors
nfs-misc-minor-fixes.patch
nfs: misc minor fixes
nfs-lockd-sync-01.patch
nfs: sync lockd to 2.4.x
nfs-lockd-sync-02.patch
nfs: sync lockd to 2.4.x
nfs-lockd-sync-03.patch
nfs: sync lockd to 2.4.x
nfs-lockd-sync-04.patch
nfs: sync lockd to 2.4.x
nfs-rpc-remove-redundant-memset.patch
nfs: remove unnecessary memset() in RPC
nfs-tunable-rpc-slot-table.patch
nfs: make the RPC slot table size a tunable value.
nfs-short-read-fix.patch
nfs: fix an NFSv2 read bug
nfs-server-in-root_server_path.patch
Pull NFS server address out of root_server_path
non-readable-binaries.patch
Handle non-readable binfmt_misc executables
binfmt_misc-credentials.patch
binfmt_misc: improve calaulation of interpreter's credentials
initramfs-search-for-init.patch
search for /init for initramfs boots
centaur-crypto-core-support.patch
First steps toward VIA crypto support
adaptive-lazy-readahead.patch
adaptive lazy readahead
sysfs_remove_dir-race-fix.patch
sysfs_remove_dir-vs-dcache_readdir race fix
sysfs_remove_subdir-dentry-leak-fix.patch
Fix dentry refcounting in sysfs_remove_group()
per-node-rss-tracking.patch
Track per-node RSS for NUMA
aic7xxx-deadlock-fix.patch
aic7xxx deadlock fix
futex_wait-debug.patch
futex_wait debug
module_exit-deadlock-fix.patch
module unload deadlock fix
selinux-inode-race-trap.patch
Try to diagnose Bug 2153
ext3-dirty-debug-patch.patch
ext3 debug patch
ufs2-01.patch
read-only support for UFS2
ide-scsi-error-handling-fixes.patch
ide-scsi error handling fixes
ide-scsi-error-handling-update.patch
ide-scsi error handler update
fb_console_init-fix.patch
fb_console_init fix
poll-select-longer-timeouts.patch
poll()/select(): support longer timeouts
poll-select-range-check-fix.patch
poll()/select() range checking fix
poll-select-handle-large-timeouts.patch
poll()/select(): handle long timeouts
pcmcia-debugging-rework-1.patch
Overhaul PCMCIA debugging (1)
cs_err-compile-fix.patch
pcmcia: workaround for gcc-2.95 bug in cs_err()
pcmcia-debugging-rework-2.patch
Overhaul PCMCIA debugging (2)
distribute-early-allocations-across-nodes.patch
Manfred's patch to distribute boot allocations across nodes
time-interpolator-fix.patch
time interpolator fix
kmsg-nonblock.patch
teach /proc/kmsg about O_NONBLOCK
mixart-build-fix.patch
CONFIG_SND_MIXART doesn't compile
add-a-slab-for-ethernet.patch
Add a kmalloc slab for ethernet packets
remove-__io_virt_debug.patch
remove __io_virt_debug
genrtc-cleanups.patch
genrtc: cleanups
piix_ide_init-can-be-__init.patch
piix_ide_init can be __init
fusion-use-min-max.patch
message/fusion: use kernel min/max
i386-early-memory-cleanup.patch
i386 very early memory detection cleanup patch
modular-mce-handler.patch
Allow X86_MCE_NONFATAL to be a module
remove-more-KERNEL_SYSCALLS.patch
further __KERNEL_SYSCALLS__ removal
build fix for remove-more-KERNEL_SYSCALLS.patch
fix the build for remove-more-KERNEL_SYSCALLS
mq-01-codemove.patch
posix message queues: code move
mq-02-syscalls.patch
posix message queues: syscall stubs
mq-03-core.patch
posix message queues: implementation
mq-03-core-update.patch
posix message queues: update to core patch
mq-04-linuxext-poll.patch
posix message queues: linux-specific poll extension
mq-05-linuxext-mount.patch
posix message queues: made user mountable
mq-update-01.patch
posix message queue update
mq-security-fix.patch
security bugfix for mqueue
dm-01-endio-method.patch
dm: endio method
dm-03-list_for_each_entry-audit.patch
dm: list_for_each_entry audit
dm-04-default-queue-limits-fix.patch
dm: default queue limits
dm-05-list-targets-command.patch
dm: list targets cmd
dm-06-stripe-width-fix.patch
dm: stripe width fix
queue-congestion-callout.patch
Add queue congestion callout
queue-congestion-dm-implementation.patch
Implement queue congestion callout for device mapper
dm-maplock.patch
devicemapper: use rwlock for map alterations
use-wait_task_inactive-in-kthread_bind.patch
use wait_task_inactive() in kthread_bind()
HPFS1-hpfs2-RC4-rc1.patch
HPFS2-hpfs_namei-RC4-rc1.patch
selinux-cleanup-binary-mount-data.patch
selinux: clean up binary mount data
udffs-update.patch
UDF filesystem update
kbuild-redundant-CFLAGS.patch
kbuild: Remove CFLAGS assignment in i386/mach-*/Makefile
numa-aware-zonelist-builder.patch
NUMA-aware zonelist builder
numa-aware zonelist builder fix
numa-aware node builder fix #2
remove-redundant-unplug_timer-deletion.patch
Redundant unplug_timer deletion
queue_work_on_cpu.patch
Add queue_work_on_cpu() workqueue function
m68k-rename-sys_functions.patch
m68k: rename sys_* functions
pdc202xx_new-update.patch
ide: update for pdc202xx_new driver
siimage-update.patch
ide: update for siimage driver
ide-cleanups-01.patch
ide: IDE cleanups
ide-cleanups-02.patch
ide: IDE cleanups
ide-cleanups-03.patch
ide: IDE cleanups
cdromaudio-use-dma.patch
use DMA for CDROM audio reading
sysfs-pin-kobject.patch
sysfs: pin kobjects to fix use-after-free crashes
ATI-IXP-IDE-support.patch
ATI IXP IDE support
ipmi-updates-3.patch
IPMI driver updates
ipmi-socket-interface.patch
IPMI: socket interface
md-use-schedule_timeout.patch
md: use "shedule_timeout(2)" instead of yield()
md-array-assembly-fix.patch
md: allow assembling of partitioned arrays at boot time.
compiler_h-scope-fixes.patch
compiler.h scoping fixes
remap-file-pages-prot-2.6.4-rc1-mm1-A1.patch
per-page protections for remap_file_pages()
nmi_watchdog-local-apic-fix.patch
Fix nmi_watchdog=2 and P4 HT
nmi-1-hz.patch
set nmi_hz to 1 with nmi_watchdog=2 and SMP
elf-mmap-fix.patch
Fix elf mapping of the zero page
kbuild-more-cleaning.patch
kbuild: Cause `make clean' to remove more files
LOOP_CHANGE_FD.patch
LOOP_CHANGE_FD ioctl
loop-setup-race-fix.patch
loop setup race fix
handle-dot-o-paths.patch
kbuild: fix usage with directories containing '.o'
acpi-asmlinkage-fix.patch
gcc-3.5: acpi build fix
ipc-sem-extra-sem_unlock.patch
Remove unneeded unlock in ipc/sem.c
procfs-dangling-subdir-fix.patch
/proc data corruption check
AMD-768MPX-bootmem-fix.patch
Work around an AMD768MPX erratum
i810fb-on-x86_64.patch
Enable i810 fb on x86-64
ext23-remove-acl-limits.patch
Remove arbitrary #acl entries limits on ext[23] when reading
watchdog-moduleparam-patches.patch
watchdog: moduleparam-patches
amd-elan-fix.patch
AMD ELAN Kconfig fix
pcmcia-netdev-ordering-fixes.patch
PCMCIA netdevice ordering issues
instrument-highmem-page-reclaim.patch
vm: per-zone vmscan instrumentation
blk_congestion_wait-return-remaining.patch
return remaining jiffies from blk_congestion_wait()
vmscan-remove-priority.patch
mm/vmscan.c: remove unused priority argument.
kswapd-throttling-fixes.patch
kswapd throttling fixes
vm-refill_inactive-preserve-referenced.patch
vmscan: preserve page referenced info in refill_inactive()
shrink_slab-precision-fix.patch
shrink_slab: math precision fix
try_to_free_pages-shrink_slab-evenness.patch
vm: shrink slab evenly in try_to_free_pages()
vmscan-total_scanned-fix.patch
vmscan: fix calculation of number of pages scanned
shrink_slab-for-all-zones-2.patch
vm: scan slab in response to highmem scanning
zone-balancing-fix-2.patch
vmscan: zone balancing fix
vmscan-control-by-nr_to_scan-only.patch
vmscan: drive everything via nr_to_scan
vmscan-balance-zone-scanning-rates.patch
Balance inter-zone scan rates
vmscan-dont-throttle-if-zero-max_scan.patch
vmscan: avoid bogus throttling
kswapd-avoid-higher-zones.patch
kswapd: avoid unnecessary reclaiming from higher zones
kswapd-avoid-higher-zones-reverse-direction.patch
kswapd: fix lumpy page reclaim
kswapd-avoid-higher-zones-reverse-direction-fix.patch
fix the kswapd zone scanning algorithm
vmscan-throttle-later.patch
vmscan: less throttling of page allocators and kswapd
vm-batch-inactive-scanning.patch
vmscan: batch up inactive list scanning work
vm-batch-inactive-scanning-fix.patch
fix vm-batch-inactive-scanning.patch
vm-balance-refill-rate.patch
vm: balance inactive zone refill rates
slab-no-higher-order.patch
slab: avoid higher-order allocations
list_del-debug.patch
list_del debug check
oops-dump-preceding-code.patch
i386 oops output: dump preceding code
lockmeter.patch
lockmeter
lockmeter-ia64-fix.patch
ia64 CONFIG_LOCKMETER fix
4g-2.6.0-test2-mm2-A5.patch
4G/4G split patch
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g/4g usercopy atomicity fix
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g/4g usercopy atomicity fix
4G/4G preempt on vstack
4G/4G: even number of kmap types
4g4g: fix __get_user in slab
4g4g: Remove extra .data.idt section definition
4g/4g linker error (overlapping sections)
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g4g: show_registers() fix
4g/4g usercopy atomicity fix
4g4g: debug flags fix
4g4g: Fix wrong asm-offsets entry
cyclone time fixmap fix
4G/4G preempt on vstack
4G/4G: even number of kmap types
4g4g: fix __get_user in slab
4g4g: Remove extra .data.idt section definition
4g/4g linker error (overlapping sections)
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g4g: show_registers() fix
4g/4g usercopy atomicity fix
4g4g: debug flags fix
4g4g: Fix wrong asm-offsets entry
cyclone time fixmap fix
use direct_copy_{to,from}_user for kernel access in mm/usercopy.c
4G/4G might_sleep warning fix
4g/4g pagetable accounting fix
Fix 4G/4G and WP test lockup
4G/4G KERNEL_DS usercopy again
Fix 4G/4G X11/vm86 oops
Fix 4G/4G athlon triplefault
4g4g SEP fix
Fix 4G/4G split fix for pre-pentiumII machines
4g/4g PAE ACPI low mappings fix
zap_low_mappings() cannot be __init
4g/4g: remove printk at boot
4g4g-THREAD_SIZE-fixes.patch
4g4g-locked-userspace-copy.patch
Do a locked user-space copy for 4g/4g
ia32-4k-stacks.patch
ia32: 4Kb stacks (and irqstacks) patch
ia32-4k-stacks-build-fix.patch
4k stacks build fix
4k-stacks-in-modversions-magic.patch
Add 4k stacks to module version magic
4g4g-handle_BUG-fix.patch
4g4g: fix handle_BUG()
ppc-fixes.patch
make mm4 compile on ppc
ppc-fixes-dependency-fix.patch
ppc-fixes dependency fix
O_DIRECT-race-fixes-rollup.patch
O_DIRECT data exposure fixes
O_DIRECT-ll_rw_block-vs-block_write_full_page-fix.patch
Fix race between ll_rw_block() and block_write_full_page()
blockdev-direct-io-speedup.patch
blockdev direct-io speedups
O_DIRECT-vs-buffered-fix.patch
Fix O_DIRECT-vs-buffered data exposure bug
O_DIRECT-vs-buffered-fix-pdflush-hang-fix.patch
pdflush hang fix
serialise-writeback-fdatawait.patch
serialize_writeback_fdatawait patch
restore-writeback-trylock.patch
writeback trylock patch
dio-aio-fixes.patch
direct-io AIO fixes
aio-fallback-bio_count-race-fix-2.patch
AIO+DIO bio_count race fix
aio-direct-io-oops-fix.patch
AIO/direct-io oops fix
Included with this report is a list of the current warnings from the
2.6.4-rc2-mm1 builds.
Linux 2.6 (mm tree) Compile Statistics (gcc 3.2.2)
Warnings/Errors Summary
Kernel bzImage bzImage bzImage modules bzImage modules
(defconfig) (allno) (allyes) (allyes) (allmod) (allmod)
--------------- ---------- -------- -------- -------- -------- --------
2.6.3-rc2-mm1 1w/0e 5w/0e 146w/12e 11w/0e 3w/0e 147w/2e
2.6.3-rc1-mm2 1w/0e 5w/0e 144w/ 0e 11w/0e 3w/0e 145w/0e
2.6.3-rc1-mm1 1w/0e 5w/0e 147w/ 5e 11w/0e 3w/0e 147w/0e
2.6.3-mm4 1w/0e 5w/0e 146w/ 0e 7w/0e 3w/0e 142w/0e
2.6.3-mm3 1w/2e 5w/2e 146w/15e 7w/0e 3w/2e 144w/5e
2.6.3-mm2 1w/8e 5w/0e 140w/ 0e 7w/0e 3w/0e 138w/0e
2.6.3-mm1 1w/0e 5w/0e 143w/ 5e 7w/0e 3w/0e 141w/0e
2.6.3-rc3-mm1 1w/0e 0w/0e 144w/13e 7w/0e 3w/0e 142w/3e
2.6.3-rc2-mm1 1w/0e 0w/265e 144w/ 5e 7w/0e 3w/0e 145w/0e
2.6.3-rc1-mm1 1w/0e 0w/265e 141w/ 5e 7w/0e 3w/0e 143w/0e
2.6.2-mm1 2w/0e 0w/264e 147w/ 5e 7w/0e 3w/0e 173w/0e
2.6.2-rc3-mm1 2w/0e 0w/265e 146w/ 5e 7w/0e 3w/0e 172w/0e
2.6.2-rc2-mm2 0w/0e 0w/264e 145w/ 5e 7w/0e 3w/0e 171w/0e
2.6.2-rc2-mm1 0w/0e 0w/264e 146w/ 5e 7w/0e 3w/0e 172w/0e
2.6.2-rc1-mm3 0w/0e 0w/265e 144w/ 8e 7w/0e 3w/0e 169w/0e
2.6.2-rc1-mm2 0w/0e 0w/264e 144w/ 5e 10w/0e 3w/0e 171w/0e
2.6.2-rc1-mm1 0w/0e 0w/264e 144w/ 5e 10w/0e 3w/0e 171w/0e
2.6.1-mm5 2w/5e 0w/264e 153w/11e 10w/0e 3w/0e 180w/0e
2.6.1-mm4 0w/821e 0w/264e 154w/ 5e 8w/1e 5w/0e 179w/0e
2.6.1-mm3 0w/0e 0w/0e 151w/ 5e 10w/0e 3w/0e 177w/0e
2.6.1-mm2 0w/0e 0w/0e 143w/ 5e 12w/0e 3w/0e 171w/0e
2.6.1-mm1 0w/0e 0w/0e 146w/ 9e 12w/0e 6w/0e 171w/0e
2.6.1-rc2-mm1 0w/0e 0w/0e 149w/ 0e 12w/0e 6w/0e 171w/4e
2.6.1-rc1-mm2 0w/0e 0w/0e 157w/15e 12w/0e 3w/0e 185w/4e
2.6.1-rc1-mm1 0w/0e 0w/0e 156w/10e 12w/0e 3w/0e 184w/2e
2.6.0-mm2 0w/0e 0w/0e 161w/ 0e 12w/0e 3w/0e 189w/0e
2.6.0-mm1 0w/0e 0w/0e 173w/ 0e 12w/0e 3w/0e 212w/0e
Web page with links to complete details:
http://developer.osdl.org/cherry/compile/
Warnings in the build
---------------------
drivers/cdrom/aztcd.c:379: warning: `pa_ok' defined but not used
drivers/cdrom/isp16.c:124: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/cdrom/mcdx.h:180:2: warning: #warning You have not edited mcdx.h
drivers/cdrom/mcdx.h:181:2: warning: #warning Perhaps irq and i/o
settings are wrong.
drivers/cdrom/sjcd.c:1703: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/char/applicom.c:522:2: warning: #warning "Je suis stupide. DW. -
copy*user in cli"
drivers/char/applicom.c:67: warning: `applicom_pci_tbl' defined but not
used
drivers/char/ipmi/ipmi_smb.c:224: warning: implicit declaration of
function `i2c_set_spin_delay'
drivers/char/watchdog/alim1535_wdt.c:320: warning: `ali_pci_tbl' defined
but not used
drivers/char/watchdog/cpu5wdt.c:305: warning: initialization discards
qualifiers from pointer target type
drivers/char/watchdog/cpu5wdt.c:305: warning: return discards qualifiers
from pointer target type
drivers/ide/ide-tape.c:4701: warning: duplicate `const'
drivers/ide/ide.c:2291: warning: implicit declaration of function
`pnpide_init'
drivers/ide/legacy/ide-cs.c:364: warning: `MOD_INC_USE_COUNT' is
deprecated (declared at include/linux/module.h:515)
drivers/ide/legacy/ide-cs.c:410: warning: `MOD_DEC_USE_COUNT' is
deprecated (declared at include/linux/module.h:527)
drivers/ide/pci/trm290.c:378: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/isdn/capi/capidrv.c:2111:10: warning: #warning FIXME: maybe a
race condition the card should be removed here from global list /kkeil
drivers/isdn/hisax/config.c:1889: warning: `hisax_pci_tbl' defined but
not used
drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used
uninitialized in this function
drivers/isdn/icn/icn.c:719:18: warning: #warning TODO test headroom or
use skb->nb to flag ACK
drivers/media/dvb/frontends/stv0299.c:356: warning: unused variable `i'
drivers/media/dvb/frontends/tda1004x.c:191: warning: `errno' defined but
not used
drivers/media/video/zoran_card.c:149: warning: `zr36067_pci_tbl' defined
but not used
drivers/message/fusion/mptscsih.c:7117: warning: `mptscsih_setup'
defined but not used
drivers/message/i2o/i2o_block.c:1493: warning: `MOD_DEC_USE_COUNT' is
deprecated (declared at include/linux/module.h:527)
drivers/mtd/chips/amd_flash.c:783: warning: `MOD_INC_USE_COUNT' is
deprecated (declared at include/linux/module.h:515)
drivers/mtd/chips/cfi_cmdset_0001.c:381: warning: unsigned int format,
different type arg (arg 2)
drivers/mtd/chips/cfi_cmdset_0001.c:965: warning: unsigned int format,
different type arg (arg 2)
drivers/mtd/chips/cfi_cmdset_0002.c:1157: warning: unsigned int format,
different type arg (arg 4)
drivers/mtd/chips/cfi_cmdset_0002.c:513: warning: unsigned int format,
different type arg (arg 4)
drivers/mtd/chips/cfi_cmdset_0002.c:651: warning: unsigned int format,
different type arg (arg 4)
drivers/mtd/chips/cfi_cmdset_0002.c:977: warning: unsigned int format,
different type arg (arg 4)
drivers/mtd/chips/cfi_cmdset_0020.c:1148: warning: unsigned int format,
different type arg (arg 3)
drivers/mtd/chips/cfi_cmdset_0020.c:1297: warning: unsigned int format,
different type arg (arg 3)
drivers/mtd/chips/cfi_cmdset_0020.c:493: warning: unsigned int format,
different type arg (arg 3)
drivers/mtd/chips/cfi_cmdset_0020.c:862: warning: unsigned int format,
different type arg (arg 3)
drivers/mtd/chips/sharp.c:157: warning: `MOD_INC_USE_COUNT' is
deprecated (declared at include/linux/module.h:515)
drivers/mtd/cmdlinepart.c:344: warning: `mtdpart_setup' defined but not
used
drivers/mtd/devices/doc2000.c:567: warning: assignment from incompatible
pointer type
drivers/mtd/devices/doc2000.c:568: warning: assignment from incompatible
pointer type
drivers/mtd/devices/doc2001.c:376: warning: assignment from incompatible
pointer type
drivers/mtd/devices/doc2001.c:377: warning: assignment from incompatible
pointer type
drivers/mtd/nftlcore.c:354: warning: passing arg 7 of pointer to
function makes pointer from integer without a cast
drivers/mtd/nftlcore.c:358: warning: passing arg 7 of pointer to
function makes pointer from integer without a cast
drivers/mtd/nftlcore.c:363: warning: passing arg 7 of pointer to
function makes pointer from integer without a cast
drivers/mtd/nftlcore.c:632: warning: passing arg 7 of pointer to
function makes pointer from integer without a cast
drivers/mtd/nftlcore.c:696: warning: passing arg 7 of pointer to
function makes pointer from integer without a cast
drivers/mtd/nftlmount.c:220: warning: passing arg 7 of pointer to
function makes pointer from integer without a cast
drivers/net/arcnet/com20020-isa.c:188: warning: unused variable `dev'
drivers/net/arcnet/com20020-isa.c:189: warning: unused variable `lp'
drivers/net/ibmlana.c:910: warning: `ibmlana_probe' defined but not used
drivers/net/sk98lin/skaddr.c:1427: warning: `ReturnCode' might be used
uninitialized in this function
drivers/net/sk98lin/skaddr.c:895: warning: `ReturnCode' might be used
uninitialized in this function
drivers/net/tulip/winbond-840.c:149: warning: `version' defined but not
used
drivers/net/wan/cycx_drv.c:430: warning: unsigned int format, long
unsigned int arg (arg 3)
drivers/pcmcia/i82365.c:672: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/pcmcia/i82365.c:806: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/pcmcia/tcic.c:347: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:1000: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:1005: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:3556: warning: `BusLogic_AbortCommand' defined
but not used
drivers/scsi/BusLogic.c:694: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:698: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:702: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:706: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:710: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:714: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:970: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:985: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:990: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/BusLogic.c:995: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/NCR5380.c:396: warning: `phases' defined but not used
drivers/scsi/NCR5380.c:699: warning: `NCR5380_probe_irq' defined but not
used
drivers/scsi/NCR5380.c:756: warning: `NCR5380_print_options' defined but
not used
drivers/scsi/NCR53c406a.c:611: warning: `NCR53c406a_setup' defined but
not used
drivers/scsi/NCR53c406a.c:660: warning: initialization from incompatible
pointer type
drivers/scsi/NCR53c406a.c:669: warning: `wait_intr' defined but not used
drivers/scsi/aacraid/rkt.c:335: warning: `aac_rkt_check_health' defined
but not used
drivers/scsi/aacraid/rx.c:335: warning: `aac_rx_check_health' defined
but not used
drivers/scsi/aacraid/sa.c:310: warning: `aac_sa_check_health' defined
but not used
drivers/scsi/advansys.c:10006: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/advansys.c:4622: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/dtc.c:187: warning: `dtc_setup' defined but not used
drivers/scsi/eata_pio.c:596: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/fd_mcs.c:300: warning: `fd_mcs_setup' defined but not used
drivers/scsi/fd_mcs.c:311: warning: initialization from incompatible
pointer type
drivers/scsi/fd_mcs.h:27: warning: `fd_mcs_command' declared `static'
but never defined
drivers/scsi/fdomain.c:763: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/g_NCR5380.c:931: warning: `id_table' defined but not used
drivers/scsi/gdth.c:880: warning: `gdthtable' defined but not used
drivers/scsi/libata-core.c:2172: warning: `ata_qc_push' defined but not
used
drivers/scsi/psi240i.c:713: warning: initialization from incompatible
pointer type
drivers/scsi/psi240i.c:714: warning: initialization from incompatible
pointer type
drivers/scsi/qla1280.c:3124: warning: `qla1280_64bit_start_scsi' defined
but not used
drivers/scsi/sym53c416.c:627: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/sym53c416.c:715: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/scsi/wd7000.c:1611: warning: `wd7000_abort' defined but not used
drivers/serial/8250.c:689: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/telephony/ixj.c:7737: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/telephony/ixj.c:7799: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/telephony/ixj.c:7835: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
drivers/telephony/ixj.h:41: warning: `ixj_h_rcsid' defined but not used
drivers/usb/class/usb-midi.h:144: warning: `usb_midi_ids' defined but
not used
drivers/usb/media/pwc-if.c:1124: warning: control reaches end of
non-void function
drivers/usb/media/pwc-if.c:1855: warning: assignment from incompatible
pointer type
drivers/video/console/mdacon.c:374: warning: `MOD_INC_USE_COUNT' is
deprecated (declared at include/linux/module.h:515)
drivers/video/console/mdacon.c:384: warning: `MOD_DEC_USE_COUNT' is
deprecated (declared at include/linux/module.h:527)
drivers/video/console/mdacon.c:599: warning: initialization from
incompatible pointer type
drivers/video/hgafb.c:452: warning: `hgafb_fillrect' defined but not
used
drivers/video/hgafb.c:472: warning: `hgafb_copyarea' defined but not
used
drivers/video/hgafb.c:502: warning: `hgafb_imageblit' defined but not
used
drivers/video/imsttfb.c:1089: warning: `imsttfb_load_cursor_image'
defined but not used
drivers/video/imsttfb.c:1159: warning: `imstt_set_cursor' defined but
not used
drivers/video/matrox/matroxfb_base.c:1250: warning: `inverse' defined
but not used
drivers/video/matrox/matroxfb_g450.c:129: warning: duplicate `const'
drivers/video/matrox/matroxfb_g450.c:130: warning: duplicate `const'
drivers/video/matrox/matroxfb_maven.c:347: warning: duplicate `const'
drivers/video/matrox/matroxfb_maven.c:348: warning: duplicate `const'
drivers/video/tdfxfb.c:1005: warning: `tdfxfb_cursor' defined but not
used
drivers/video/tdfxfb.c:198: warning: `inverse' defined but not used
drivers/video/tdfxfb.c:199: warning: `mode_option' defined but not used
drivers/video/tridentfb.c:455: warning: `tridentfb_fillrect' defined but
not used
drivers/video/tridentfb.c:473: warning: `tridentfb_copyarea' defined but
not used
include/asm-generic/tlb.h:107: warning: implicit declaration of function
`page_cache_release'
include/asm-generic/tlb.h:74: warning: implicit declaration of function
`release_pages'
include/asm-generic/tlb.h:74: warning: previous implicit declaration of
`release_pages'
include/linux/ixjuser.h:45: warning: `ixjuser_h_rcsid' defined but not
used
include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy - please
move your driver to the new sysfs api"
include/linux/pagemap.h:50: warning: `release_pages' was previously
implicitly declared to return `int'
include/linux/pagemap.h:50: warning: type mismatch with previous
implicit declaration
include/sound/initval.h:141: warning: `get_id' defined but not used
sound/isa/dt019x.c:147: warning: long unsigned int format, int arg (arg
5)
sound/isa/dt019x.c:147: warning: long unsigned int format, int arg (arg
6)
sound/isa/dt019x.c:168: warning: long unsigned int format, int arg (arg
5)
sound/isa/wavefront/wavefront_synth.c:1923: warning: `errno' defined but
not used
sound/oss/ad1848.c:1580: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/ad1848.c:2530: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/ad1848.c:2967: warning: `id_table' defined but not used
sound/oss/cmpci.c:1465: warning: unused variable `s'
sound/oss/cmpci.c:2865: warning: `cmpci_pci_tbl' defined but not used
sound/oss/cs4232.c:141: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/cs4232.c:193: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/gus_card.c:76: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/gus_card.c:78: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/gus_card.c:93: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/gus_card.c:94: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/mad16.c:322: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/maui.c:307: warning: `check_region' is deprecated (declared at
include/linux/ioport.h:121)
sound/oss/mpu401.c:1217: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/msnd.c:63: warning: `MOD_INC_USE_COUNT' is deprecated
(declared at include/linux/module.h:515)
sound/oss/msnd.c:84: warning: `MOD_DEC_USE_COUNT' is deprecated
(declared at include/linux/module.h:527)
sound/oss/msnd_pinnacle.c:1123: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
sound/oss/msnd_pinnacle.c:1811: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
sound/oss/opl3sa.c:114: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/opl3sa.c:122: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/pss.c:1004: warning: `check_region' is deprecated (declared at
include/linux/ioport.h:121)
sound/oss/pss.c:191: warning: `check_region' is deprecated (declared at
include/linux/ioport.h:121)
sound/oss/pss.c:640: warning: `check_region' is deprecated (declared at
include/linux/ioport.h:121)
sound/oss/pss.c:710: warning: `check_region' is deprecated (declared at
include/linux/ioport.h:121)
sound/oss/sb_common.c:1224: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
sound/oss/sb_common.c:523: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
sound/oss/sgalaxy.c:89: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/sgalaxy.c:97: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/sscape.c:1113: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/sscape.c:1132: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/sscape.c:1137: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/sscape.c:737: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
sound/oss/trix.c:147: warning: `check_region' is deprecated (declared at
include/linux/ioport.h:121)
sound/oss/trix.c:292: warning: `check_region' is deprecated (declared at
include/linux/ioport.h:121)
sound/oss/trix.c:85: warning: `check_region' is deprecated (declared at
include/linux/ioport.h:121)
sound/oss/wavfront.c:2426: warning: `check_region' is deprecated
(declared at include/linux/ioport.h:121)
sound/oss/wavfront.c:2497: warning: `errno' defined but not used
sound/oss/wavfront.c:2524: warning: implicit declaration of function
`sys_open'
sound/oss/wavfront.c:2533: warning: implicit declaration of function
`sys_read'
sound/oss/wavfront.c:2582: warning: implicit declaration of function
`sys_close'
sound/oss/wf_midi.c:788: warning: `check_region' is deprecated (declared
at include/linux/ioport.h:121)
John
Was the DMA patch for CDROMREADAUDIO reading? I don't seem any speed
increase while ripping with cdparanoia.
On Mon, 2004-03-08 at 18:41, Balram Adlakha wrote:
> Was the DMA patch for CDROMREADAUDIO reading? I don't seem any speed
> increase while ripping with cdparanoia.
i didnt notice anything either, but that is because mine went to 32x
anyway, which is my cdrom maximum ;)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Regards, Redeeman
[email protected]
On Mon, 8 Mar 2004, Redeeman wrote:
> On Mon, 2004-03-08 at 18:41, Balram Adlakha wrote:
> > Was the DMA patch for CDROMREADAUDIO reading? I don't seem any speed
> > increase while ripping with cdparanoia.
> i didnt notice anything either, but that is because mine went to 32x
> anyway, which is my cdrom maximum ;)
How about CPU utilisation? vmstat output should do the trick.
Zwane
On Monday 08 March 2004 06:32, you wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.4-rc2/2.6
>.4-rc2-mm1/
>
>
> - Added Jens's patch which teaches the kernel to use DMA when reading
> audio from IDE CDROM drives. These devices tend to be flakey, and we
> need lots of testing please.
[snip]
This seems to work okay. When ripping a CD, cdparanoia's CPU utilisation
never peaks beyond 4.0%. Very nice.
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
445 alistair 18 0 5008 3428 1576 R 4.0 0.7 0:06.25 cdparanoia
No crashes so far. I'll try some bad discs and see how it recovers.
--
Cheers,
Alistair.
personal: alistair()devzero!co!uk
university: s0348365()sms!ed!ac!uk
student: CS/AI Undergraduate
contact: 7/10 Darroch Court,
University of Edinburgh.
On Mon, Mar 08 2004, Balram Adlakha wrote:
> Was the DMA patch for CDROMREADAUDIO reading? I don't seem any speed
> increase while ripping with cdparanoia.
If your CPU was fast enough you will not see a speed increase, you
should see system time go way down though. So try and time cdparanoia
rip + encode session instead, that way you'll be using your CPU for
something worthwhile while ripping the data (you'll be doing that if you
use grip, for instance).
--
Jens Axboe
On Mon, Mar 08, 2004 at 08:47:49PM +0100, Jens Axboe wrote:
> On Mon, Mar 08 2004, Balram Adlakha wrote:
> > Was the DMA patch for CDROMREADAUDIO reading? I don't seem any speed
> > increase while ripping with cdparanoia.
>
> If your CPU was fast enough you will not see a speed increase, you
> should see system time go way down though. So try and time cdparanoia
> rip + encode session instead, that way you'll be using your CPU for
> something worthwhile while ripping the data (you'll be doing that if you
> use grip, for instance).
>
> --
> Jens Axboe
Yeah it does work, system time is less than one second. Thanks a lot for
the patch.
I can't figure out why my ripping speed is so slow though, I'm getting a
3x speed with paranoia, around 6x without jitter correction. Any ideas where the problem might be?
Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.4-rc2/2
>.6.4-rc2-mm1/
>
>
> - Added Jens's patch which teaches the kernel to use DMA when reading
> audio from IDE CDROM drives. These devices tend to be flakey, and we
> need lots of testing please.
Works great on my VIA KT133A with Toshiba SD-M1502. Grip cpu usage is 5 %
instead of 90 %.
cheers
Christian
Hi,
the bk-usb.patch leads to following error:
drivers/char/watchdog/pcwd_usb.c: In function `usb_pcwd_probe':
drivers/char/watchdog/pcwd_usb.c:592: error: structure has no member named
`act_altsetting'
The attached patch fixes it.
Best regards
Thomas Schlichter
Hi,
the bk-acpi.patch leads to following warning:
In file included from include/asm/fixmap.h:18,
from arch/i386/kernel/time_hpet.c:17:
include/asm/acpi.h: In function `__acpi_acquire_global_lock':
include/asm/acpi.h:72: Warnung: implicit declaration of function `cmpxchg'
The attached patch fixes it by including <asm/system.h>.
Best regards
Thomas Schlichter
On Tue, Mar 09 2004, Balram Adlakha wrote:
> I can't figure out why my ripping speed is so slow though, I'm getting
> a 3x speed with paranoia, around 6x without jitter correction. Any
> ideas where the problem might be?
Probably the drive, not all drives are happy with reading cdda really
fast...
--
Jens Axboe
On Sun, 07 Mar 2004 22:32:21 PST, Andrew Morton <[email protected]> said:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.4-rc2/2.6.4
-rc2-mm1/
> Changes since 2.6.4-rc1-mm2:
>
>
> linus.patch
The Linus patch apparently has a half-done fix - it does it in smp.c but not
in io_apic.c - so building non-SMP we get:
arch/i386/kernel/io_apic.c:703: error: conflicting types for 'send_IPI_self'
include/asm/hw_irq.h:54: error: previous declaration of 'send_IPI_self' was here
arch/i386/kernel/io_apic.c:703: error: conflicting types for 'send_IPI_self'
include/asm/hw_irq.h:54: error: previous declaration of 'send_IPI_self' was here
Fix:
--- linux-2.6.4-rc2-mm1/arch/i386/kernel/io_apic.c.akpm 2004-03-08 16:53:02.337724358 -0500
+++ linux-2.6.4-rc2-mm1/arch/i386/kernel/io_apic.c 2004-03-08 16:53:20.950171060 -0500
@@ -699,7 +699,7 @@
#endif /* CONFIG_IRQBALANCE */
#ifndef CONFIG_SMP
-void send_IPI_self(int vector)
+void fastcall send_IPI_self(int vector)
{
unsigned int cfg;
On Mon, Mar 08, 2004 at 09:05:17PM +0100, Thomas Schlichter wrote:
> Hi,
>
> the bk-usb.patch leads to following error:
>
> drivers/char/watchdog/pcwd_usb.c: In function `usb_pcwd_probe':
> drivers/char/watchdog/pcwd_usb.c:592: error: structure has no member named
> `act_altsetting'
>
> The attached patch fixes it.
Yes, this is the proper fix, thanks. It's already in my bk-usb tree
now.
greg k-h
On Mon, 2004-03-08 at 21:10, Jens Axboe wrote:
> On Tue, Mar 09 2004, Balram Adlakha wrote:
> > I can't figure out why my ripping speed is so slow though, I'm getting
> > a 3x speed with paranoia, around 6x without jitter correction. Any
> > ideas where the problem might be?
>
> Probably the drive, not all drives are happy with reading cdda really
> fast...
i believe this too, as i had that problem with my old drive
--
Regards, Redeeman
[email protected]
On Sun, Mar 07, 2004 at 10:32:21PM -0800, Andrew Morton wrote:
>...
> +ipmi-updates-3.patch
> +ipmi-socket-interface.patch
>
> IPMI driver updates
>...
This causes the following compile error:
<-- snip -->
...
CC drivers/char/ipmi/ipmi_smb.o
drivers/char/ipmi/ipmi_smb.c: In function `smbus_client_read_block_data':
drivers/char/ipmi/ipmi_smb.c:224: warning: implicit declaration of
function `i2c_set_spin_delay'
...
LD .tmp_vmlinux1
drivers/built-in.o(.text+0x1342eb): In function
`smbus_client_read_block_data':
: undefined reference to `i2c_set_spin_delay'
drivers/built-in.o(.text+0x13448d): In function
`smbus_client_write_block_data':
: undefined reference to `i2c_set_spin_delay'
drivers/built-in.o(.text+0x134b7f): In function `set_run_to_completion':
: undefined reference to `i2c_set_spin_delay'
make: *** [.tmp_vmlinux1] Error 1
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Sun, 07 Mar 2004 22:32:21 PST, Andrew Morton <[email protected]> said:
> +dm-maplock.patch
>
> Add an rwlock to the device mapper maptable management so that
> +queue-congestion-dm-implementation.patch does not try to take a semaphore
> inside a spinlock.
Just an ack that this does fix the problem I reported against the -rc1-mm2
version of the queue-congestion stuff...
Hi, by trying to unload alsa (emu10k1) I get the following:
------------[ cut here ]------------
kernel BUG at fs/proc/generic.c:664!
invalid operand: 0000 [#1]
PREEMPT
CPU: 0
EIP: 0060:[<c0187be9>] Not tainted VLI
EFLAGS: 00010286
EIP is at remove_proc_entry+0xe9/0x140
eax: f3209cc0 ebx: f3fb85f0 ecx: f63d2140 edx: f7fece00
esi: 00000005 edi: f375a140 ebp: 00000000 esp: f42ffe70
ds: 007b es: 007b ss: 0068
Process modprobe (pid: 1835, threadinfo=f42fe000 task=f23b7150)
Stack: f375a140 f375a188 f375a140 f3209dc0 f375a188 f9ada470 f375a240 00000080
f9acfa7b f375a188 f3fb85c0 f74abe00 f74abe00 f9acf5b1 f375a240 f3fb85c0
f42fe000 f9acddcf f74abe00 00000002 f22989c0 c0171bde f7ff7b2c f22989c0
Call Trace:
[<f9acfa7b>] snd_info_unregister+0x3b/0x70 [snd]
[<f9acf5b1>] snd_info_card_free+0x31/0x60 [snd]
[<f9acddcf>] snd_card_free+0xef/0x230 [snd]
[<c0171bde>] destroy_inode+0x4e/0x50
[<c016fca2>] dput+0x22/0x270
[<f9b5e3a9>] snd_card_emu10k1_remove+0x19/0x30 [snd_emu10k1]
[<c01f1f8b>] pci_device_remove+0x3b/0x40
[<c0235394>] device_release_driver+0x64/0x70
[<c02353c0>] driver_detach+0x20/0x30
[<c02355ed>] bus_remove_driver+0x3d/0x80
[<c0235a03>] driver_unregister+0x13/0x28
[<c01f2166>] pci_unregister_driver+0x16/0x30
[<f9b6d2ef>] alsa_card_emu10k1_exit+0xf/0x35 [snd_emu10k1]
[<c013685c>] sys_delete_module+0x13c/0x190
[<c02f7bf2>] sysenter_past_esp+0x43/0x65
Code: 01 00 00 00 89 44 24 0c 8b 47 04 89 44 24 08 8b 44 24 28 8b 40 04 c7 04
24 c0 c4 31 c0 89 44 24 04 e8 ac a7 f9 ff e9 77 ff ff ff <0f> 0b 98 02 68 9e
31 c0 eb b4 8b 44 24 28 66 ff 48 0a eb 86 8d
My kernel-config is attached.
On Monday 08 March 2004 07:32, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.4-rc2/2.6
>.4-rc2-mm1/
>
>
> - Added Jens's patch which teaches the kernel to use DMA when reading
> audio from IDE CDROM drives. These devices tend to be flakey, and we
> need lots of testing please.
>
> - Re-added the device mapper update
>
> - Brought back Ingo's patch which permits remap_file_pages() to set the
> memory access permissions on a per-page basis. This is mainly
> interesting for its very significant performance benefits to UML.
>
> Breaks the build on most architectures. There are how-to-fix-it
> instructions in the changelog.
>
> - A new version of the patch which permits ext3 quota updates to be fully
> journalled.
>
>
>
>
> Changes since 2.6.4-rc1-mm2:
>
>
> linus.patch
> bk-acpi.patch
> bk-alsa.patch
> bk-input.patch
> bk-netdev.patch
> bk-scsi.patch
> bk-usb.patch
>
> Latest external trees
>
> -fastcall-warning-fixes.patch
> -fastcall-warning-fixes-2.patch
> -ppc64-xmon-survival-fix.patch
> -put_compat_timespec-prototype-fix.patch
> -sparc-sys_ioperm-fix.patch
> -support-zillions-of-scsi-disks.patch
> -tulip-printk-cleanup.patch
> -parport-01-move-exports.patch
> -parport-02-use-module_init.patch
> -parport-03-sysctls-use-module_init.patch
> -parport-04-move-option-parsing.patch
> -parport-irq-warning-fix.patch
> -parport-05-parport_pc_probe_port-fixes.patch
> -parport-06-refcounting-fixes.patch
> -parport-07-unregister-fixes.patch
> -parport-08-parport_announce-cleanups.patch
> -parport-09-track-used-ports.patch
> -parport-09-track-used-ports-fix.patch
> -parport-10-sunbpp-track-ports.patch
> -parport-11-remove-parport_enumerate.patch
> -parport-12-driver-list-cleanup.patch
> -hitachi-scsi_devinfo-fix.patch
> -zwane-is-floppy-maintainer-now.patch
> -rioctrl-retval-fixes.patch
> -initrd-kconfig-dependencies.patch
> -queue-congestion-callout.patch
> -queue-congestion-dm-implementation.patch
> -cs46_xx-c99-fix.patch
> -remove-nlmclnt_grace_wait.patch
> -HPFS3-hpfs_iget-RC4-rc1.patch
> -HPFS4-hpfs_lock_iget-RC4-rc1.patch
> -HPFS5-hpfs_locking-RC4-rc1.patch
> -HPFS6-hpfs_cleanup-RC4-rc1.patch
> -HPFS7-hpfs_cleanup2-RC4-rc1.patch
> -HPFS8-hpfs_race2-RC4-rc1.patch
> -HPFS9-hpfs_deadlock-RC4-rc1.patch
> -HPFS10-fix-RC4-rc1.patch
> -alpha-switch-semaphores.patch
> -serial_core-build-fix.patch
> -sb16-sample-size-fix.patch
> -ext2-ext3-ENOSPC-fix.patch
> -missing-MODULE_LICENSEs.patch
> -v4l1-compatibility-module-fix.patch
> -i2o-fixes.patch
>
> Merged
>
> +move-dma_consistent_dma_mask-sn-fix.patch
>
> Fix move-dma_consistent_dma_mask.patch for SN platforms
>
> +export-filemap_flush.patch
>
> XFS needs this symbol.
>
> +vma-corruption-fix.patch
>
> Fix nasty memory management race.
>
> -ext3-journalled-quotas.patch
> -ext3-journalled-quotas-warning-fix.patch
> -ext3-journalled-quotas-cleanups.patch
> +ext3-journalled-quotas-2.patch
>
> New journal-quotas-on-ext3 patch.
>
> +sched-smt-nice-optimisation.patch
>
> CPU scheduler tuneup for SMT hardware.
>
> +ide-scsi-error-handling-update.patch
>
> Update to ide-scsi-error-handling-fixes.patch
>
> -doc2000-warning-fixes.patch
>
> Dropped - this driver is otherwise broken.
>
> -scsi-host-allocation-fix.patch
>
> A perfectly good patch dropped :( Apparently it will expose races in
> userspace's handling of the existing /proc API's.
>
> -remove-more-KERNEL_SYSCALLS-build-fix.patch
> -remove-more-KERNEL_SYSCALLS-build-fix-2.patch
>
> Folded into remove-more-KERNEL_SYSCALLS.patch
>
> +mq-security-fix.patch
>
> POSIX message queue fix
>
> +dm-01-endio-method.patch
> +dm-03-list_for_each_entry-audit.patch
> +dm-04-default-queue-limits-fix.patch
> +dm-05-list-targets-command.patch
> +dm-06-stripe-width-fix.patch
>
> Device Mapper update
>
> +dm-maplock.patch
>
> Add an rwlock to the device mapper maptable management so that
> +queue-congestion-dm-implementation.patch does not try to take a semaphore
> inside a spinlock.
>
> -blk-unplug-when-max-request-queued.patch
>
> This was buggy, and is hard to fix.
>
> -pdc_202xx_old-update.patch
>
> This broke, and was a duplicate of other IDE patches. I think. It got
> very confusing in there.
>
> +cdromaudio-use-dma.patch
>
> Use IDE DMA for reading audio CDROMs
>
> +sysfs-pin-kobject.patch
>
> I was asked to bring back this sysfs race fix.
>
> +ATI-IXP-IDE-support.patch
>
> ATI IXP IDE support
>
> +ipmi-updates-3.patch
> +ipmi-socket-interface.patch
>
> IPMI driver updates
>
> +md-use-schedule_timeout.patch
>
> Don't use yield() in the RAID drivers
>
> +md-array-assembly-fix.patch
>
> RAID fix
>
> +compiler_h-scope-fixes.patch
>
> Header file fix
>
> +remap-file-pages-prot-2.6.4-rc1-mm1-A1.patch
>
> Per-page permissions for remap_file_pages()
>
> +nmi_watchdog-local-apic-fix.patch
> +nmi-1-hz.patch
>
> NMI watchdog fixes
>
> +elf-mmap-fix.patch
>
> Don't hardwire the mmap size.
>
> +kbuild-more-cleaning.patch
>
> Make `make clean' delete more things
>
> +loop-setup-race-fix.patch
>
> Loop race fix.
>
> +handle-dot-o-paths.patch
>
> kbuild pathname fix
>
> +acpi-asmlinkage-fix.patch
>
> ACPI build fix for current gcc
>
> +ipc-sem-extra-sem_unlock.patch
>
> Missing unlock in the IPC code.
>
> +procfs-dangling-subdir-fix.patch
>
> Trap buggy /proc users
>
> +AMD-768MPX-bootmem-fix.patch
>
> "works around the infamous "only works stable when a mouse is plugged in"
> problem some AMD 768MPX Dual Athlon chipsets have"
>
> +i810fb-on-x86_64.patch
>
> Enable i810fb on x86_64
>
> +ext23-remove-acl-limits.patch
>
> ACL uture-proofness
>
> +watchdog-moduleparam-patches.patch
>
> Watchdog driver module parameter updates
>
> +amd-elan-fix.patch
>
> Conig fix for AMD ELAN.
>
> +pcmcia-netdev-ordering-fixes.patch
>
> Attempt to fix some ordering problems with PCMCIA netdevices.
>
> -shrink-inode-cache-harder.patch
>
> Drop this - it was entirely too speculative and might actually slow things
> down.
>
> +4g4g-handle_BUG-fix.patch
>
> Fix the handling of BUG()s when using the 4:4 split.
>
> +ppc-fixes-dependency-fix.patch
>
> Make dependency fix
>
> +restore-writeback-trylock.patch
>
> More fiddling with the writebakc locking for the O_DIRECT-vs-buffered
> problem. Am getting a bit tired of this problem.
>
> +aio-direct-io-oops-fix.patch
>
> Fix an AIO oops due to aio-fallback-bio_count-race-fix-2.patch
>
>
>
>
>
> All 232 patches:
>
>
> linus.patch
>
> bk-acpi.patch
>
> bk-alsa.patch
>
> bk-input.patch
>
> bk-netdev.patch
>
> bk-scsi.patch
>
> bk-usb.patch
>
> mm.patch
> add -mmN to EXTRAVERSION
>
> dma_sync_for_device-cpu.patch
> dma_sync_for_{cpu,device}()
>
> move-dma_consistent_dma_mask.patch
> move consistent_dma_mask to the generic device
>
> move-dma_consistent_dma_mask-x86_64-fix.patch
>
> move-dma_consistent_dma_mask-sn-fix.patch
> Fix dma_mask patch for sn platform
>
> kgdb-ga.patch
> kgdb stub for ia32 (George Anzinger's one)
> kgdbL warning fix
> kgdb buffer overflow fix
> kgdbL warning fix
> kgdb: CONFIG_DEBUG_INFO fix
> x86_64 fixes
> correct kgdb.txt Documentation link (against 2.6.1-rc1-mm2)
>
> kgdb-ga-recent-gcc-fix.patch
> kgdb: fix for recent gcc
>
> kgdboe-netpoll.patch
> kgdb-over-ethernet via netpoll
>
> kgdboe-non-ia32-build-fix.patch
>
> kgdb-warning-fixes.patch
> kgdb warning fixes
>
> kgdb-x86_64-support.patch
> kgdb-x86_64-support.patch for 2.6.2-rc1-mm3
>
> kgdb-THREAD_SIZE-fixes.patch
> THREAD_SIZE fixes for kgdb
>
> export-filemap_flush.patch
> export filemap_flush() to modules
>
> vma-corruption-fix.patch
> vma corruption fix
>
> must-fix.patch
> must fix lists update
> must fix list update
> mustfix update
>
> must-fix-update-5.patch
> must-fix update
>
> ppc64-reloc_hide.patch
>
> compat-signal-noarch-2004-01-29.patch
> Generic 32-bit compat for copy_siginfo_to_user
>
> compat-generic-ipc-emulation.patch
> generic 32 bit emulation for System-V IPC
>
> remove-sys_ioperm-stubs.patch
> Clean up sys_ioperm stubs
>
> readdir-cleanups.patch
> readdir() cleanups
>
> ext3-journalled-quotas-2.patch
> ext3: journalled quota
>
> invalidate_inodes-speedup.patch
> invalidate_inodes speedup
> more invalidate_inodes speedup fixes
>
> cfq-4.patch
> CFQ io scheduler
> CFQ fixes
>
> config_spinline.patch
> uninline spinlocks for profiling accuracy.
>
> pdflush-diag.patch
>
> zap_page_range-debug.patch
> zap_page_range() debug
>
> get_user_pages-handle-VM_IO.patch
> fix get_user_pages() against mappings of /dev/mem
>
> pci_set_power_state-might-sleep.patch
>
> CONFIG_STANDALONE-default-to-n.patch
> Make CONFIG_STANDALONE default to N
>
> extra-buffer-diags.patch
>
> CONFIG_SYSFS.patch
> From: Pat Mochel <[email protected]>
> Subject: [PATCH] Add CONFIG_SYSFS
>
> CONFIG_SYSFS-boot-from-disk-fix.patch
>
> slab-leak-detector.patch
> slab leak detector
> mm/slab.c warning in cache_alloc_debugcheck_after
>
> scale-nr_requests.patch
> scale nr_requests with TCQ depth
>
> truncate_inode_pages-check.patch
>
> local_bh_enable-warning-fix.patch
>
> sched-find_busiest_node-resolution-fix.patch
> sched: improved resolution in find_busiest_node
>
> sched-domains.patch
> sched: scheduler domain support
> sched: fix for NR_CPUS > BITS_PER_LONG
> sched: clarify find_busiest_group
> sched: find_busiest_group arithmetic fix
>
> sched-domains-improvements.patch
> sched domains kernbench improvements
>
> sched-clock-fixes.patch
> fix sched_clock()
>
> sched-sibling-map-to-cpumask.patch
> sched: cpu_sibling_map to cpu_mask
> p4-clockmod sibling_map fix
> p4-clockmod: handle more than two siblings
>
> sched-domains-i386-ht.patch
> sched: implement domains for i386 HT
> sched: Fix CONFIG_SMT oops on UP
> sched: fix SMT + NUMA bug
> Change arch_init_sched_domains to use cpu_online_map
> Fix build with NR_CPUS > BITS_PER_LONG
>
> sched-domain-tweak.patch
> i386-sched-domain code consolidation
>
> sched-no-drop-balance.patch
> sched: handle inter-CPU jiffies skew
>
> sched-directed-migration.patch
> sched_balance_exec(): don't fiddle with the cpus_allowed mask
>
> sched-domain-debugging.patch
> sched_domain debugging
>
> sched-domain-balancing-improvements.patch
> scheduler domain balancing improvements
>
> sched-group-power.patch
> sched-group-power
> sched-group-power warning fixes
>
> sched-domains-use-cpu_possible_map.patch
> sched_domains: use cpu_possible_map
>
> sched-smt-nice-handling.patch
> sched: SMT niceness handling
>
> sched-smt-nice-optimisation.patch
> sched: SMT-ice optimisation
>
> fa311-mac-address-fix.patch
> wrong mac address with netgear FA311 ethernet card
>
> laptop-mode-2.patch
> laptop-mode for 2.6, version 6
> Documentation/laptop-mode.txt
> laptop-mode documentation updates
> Laptop mode documentation addition
> laptop mode simplification
>
> pid_max-fix.patch
> Bug when setting pid_max > 32k
>
> use-soft-float.patch
> Use -msoft-float
>
> DRM-cvs-update.patch
> DRM cvs update
>
> drm-include-fix.patch
>
> process-migration-speedup.patch
> Reduce TLB flushing during process migration
>
> hotplugcpu-generalise-bogolock.patch
> Atomic Hotplug CPU: Generalize Bogolock
>
> hotplugcpu-generalise-bogolock-fix-for-kthread-stop-using-signals.patch
>
> hotplugcpu-use-bogolock-in-modules.patch
> Atomic Hotplug CPU: Use Bogolock in module.c
>
> hotplugcpu-core.patch
> Atomic Hotplug CPU: Hotplug CPU Core
>
> stop_machine-warning-fix.patch
>
> hotplugcpu-core-sparc64-build-fix.patch
> hotplugcpu-core sparc64 build fix
>
> hotplugcpu-core-fix-for-kthread-stop-using-signals.patch
>
> migrate_to_cpu-dependency-fix.patch
> migrate_to_cpu() dependency fix
>
> hotplugcpu-core-drain_local_pages-fix.patch
> split drain_local_pages
>
> hotplugcpu-rcupdate-many-cpus-fix.patch
> CPU hotplug, rcupdate high NR_CPUS fix
>
> nfs-31-attr.patch
> NFSv2/v3/v4: New attribute revalidation code
>
> nfs-reconnect-fix.patch
>
> nfs-mount-fix.patch
> Update to NFS mount....
>
> nfs-d_drop-lowmem.patch
> NFS: handle nfs_fhget() error
>
> nfs-avoid-i_size_write.patch
> NFS: avoid unlocked i_size_write()
>
> nfs_unlink-oops-fix.patch
> nfs: fix "busy inodes after umount"
>
> nfs-remove-XID-spinlock.patch
> nfs: Remove an unnecessary spinlock from XID generation...
>
> nfs-misc-rpc-fixes.patch
> nfs: Misc RPC fixes...
>
> nfs-improved-writeback-strategy.patch
> nfs: improve writeback caching
>
> nfs-simplify-config-options.patch
> nfs: simplify client configuration options.
>
> nfs-fix-msync.patch
> nfs: fix msync()
>
> nfs-mount-return-useful-errors.patch
> nfs: make mount command return more useful errors
>
> nfs-misc-minor-fixes.patch
> nfs: misc minor fixes
>
> nfs-lockd-sync-01.patch
> nfs: sync lockd to 2.4.x
>
> nfs-lockd-sync-02.patch
> nfs: sync lockd to 2.4.x
>
> nfs-lockd-sync-03.patch
> nfs: sync lockd to 2.4.x
>
> nfs-lockd-sync-04.patch
> nfs: sync lockd to 2.4.x
>
> nfs-rpc-remove-redundant-memset.patch
> nfs: remove unnecessary memset() in RPC
>
> nfs-tunable-rpc-slot-table.patch
> nfs: make the RPC slot table size a tunable value.
>
> nfs-short-read-fix.patch
> nfs: fix an NFSv2 read bug
>
> nfs-server-in-root_server_path.patch
> Pull NFS server address out of root_server_path
>
> non-readable-binaries.patch
> Handle non-readable binfmt_misc executables
>
> binfmt_misc-credentials.patch
> binfmt_misc: improve calaulation of interpreter's credentials
>
> initramfs-search-for-init.patch
> search for /init for initramfs boots
>
> centaur-crypto-core-support.patch
> First steps toward VIA crypto support
>
> adaptive-lazy-readahead.patch
> adaptive lazy readahead
>
> sysfs_remove_dir-race-fix.patch
> sysfs_remove_dir-vs-dcache_readdir race fix
>
> sysfs_remove_subdir-dentry-leak-fix.patch
> Fix dentry refcounting in sysfs_remove_group()
>
> per-node-rss-tracking.patch
> Track per-node RSS for NUMA
>
> aic7xxx-deadlock-fix.patch
> aic7xxx deadlock fix
>
> futex_wait-debug.patch
> futex_wait debug
>
> module_exit-deadlock-fix.patch
> module unload deadlock fix
>
> selinux-inode-race-trap.patch
> Try to diagnose Bug 2153
>
> ext3-dirty-debug-patch.patch
> ext3 debug patch
>
> ufs2-01.patch
> read-only support for UFS2
>
> ide-scsi-error-handling-fixes.patch
> ide-scsi error handling fixes
>
> ide-scsi-error-handling-update.patch
> ide-scsi error handler update
>
> fb_console_init-fix.patch
> fb_console_init fix
>
> poll-select-longer-timeouts.patch
> poll()/select(): support longer timeouts
>
> poll-select-range-check-fix.patch
> poll()/select() range checking fix
>
> poll-select-handle-large-timeouts.patch
> poll()/select(): handle long timeouts
>
> pcmcia-debugging-rework-1.patch
> Overhaul PCMCIA debugging (1)
>
> cs_err-compile-fix.patch
> pcmcia: workaround for gcc-2.95 bug in cs_err()
>
> pcmcia-debugging-rework-2.patch
> Overhaul PCMCIA debugging (2)
>
> distribute-early-allocations-across-nodes.patch
> Manfred's patch to distribute boot allocations across nodes
>
> time-interpolator-fix.patch
> time interpolator fix
>
> kmsg-nonblock.patch
> teach /proc/kmsg about O_NONBLOCK
>
> mixart-build-fix.patch
> CONFIG_SND_MIXART doesn't compile
>
> add-a-slab-for-ethernet.patch
> Add a kmalloc slab for ethernet packets
>
> remove-__io_virt_debug.patch
> remove __io_virt_debug
>
> genrtc-cleanups.patch
> genrtc: cleanups
>
> piix_ide_init-can-be-__init.patch
> piix_ide_init can be __init
>
> fusion-use-min-max.patch
> message/fusion: use kernel min/max
>
> i386-early-memory-cleanup.patch
> i386 very early memory detection cleanup patch
>
> modular-mce-handler.patch
> Allow X86_MCE_NONFATAL to be a module
>
> remove-more-KERNEL_SYSCALLS.patch
> further __KERNEL_SYSCALLS__ removal
> build fix for remove-more-KERNEL_SYSCALLS.patch
> fix the build for remove-more-KERNEL_SYSCALLS
>
> mq-01-codemove.patch
> posix message queues: code move
>
> mq-02-syscalls.patch
> posix message queues: syscall stubs
>
> mq-03-core.patch
> posix message queues: implementation
>
> mq-03-core-update.patch
> posix message queues: update to core patch
>
> mq-04-linuxext-poll.patch
> posix message queues: linux-specific poll extension
>
> mq-05-linuxext-mount.patch
> posix message queues: made user mountable
>
> mq-update-01.patch
> posix message queue update
>
> mq-security-fix.patch
> security bugfix for mqueue
>
> dm-01-endio-method.patch
> dm: endio method
>
> dm-03-list_for_each_entry-audit.patch
> dm: list_for_each_entry audit
>
> dm-04-default-queue-limits-fix.patch
> dm: default queue limits
>
> dm-05-list-targets-command.patch
> dm: list targets cmd
>
> dm-06-stripe-width-fix.patch
> dm: stripe width fix
>
> queue-congestion-callout.patch
> Add queue congestion callout
>
> queue-congestion-dm-implementation.patch
> Implement queue congestion callout for device mapper
>
> dm-maplock.patch
> devicemapper: use rwlock for map alterations
>
> use-wait_task_inactive-in-kthread_bind.patch
> use wait_task_inactive() in kthread_bind()
>
> HPFS1-hpfs2-RC4-rc1.patch
>
> HPFS2-hpfs_namei-RC4-rc1.patch
>
> selinux-cleanup-binary-mount-data.patch
> selinux: clean up binary mount data
>
> udffs-update.patch
> UDF filesystem update
>
> kbuild-redundant-CFLAGS.patch
> kbuild: Remove CFLAGS assignment in i386/mach-*/Makefile
>
> numa-aware-zonelist-builder.patch
> NUMA-aware zonelist builder
> numa-aware zonelist builder fix
> numa-aware node builder fix #2
>
> remove-redundant-unplug_timer-deletion.patch
> Redundant unplug_timer deletion
>
> queue_work_on_cpu.patch
> Add queue_work_on_cpu() workqueue function
>
> m68k-rename-sys_functions.patch
> m68k: rename sys_* functions
>
> pdc202xx_new-update.patch
> ide: update for pdc202xx_new driver
>
> siimage-update.patch
> ide: update for siimage driver
>
> ide-cleanups-01.patch
> ide: IDE cleanups
>
> ide-cleanups-02.patch
> ide: IDE cleanups
>
> ide-cleanups-03.patch
> ide: IDE cleanups
>
> cdromaudio-use-dma.patch
> use DMA for CDROM audio reading
>
> sysfs-pin-kobject.patch
> sysfs: pin kobjects to fix use-after-free crashes
>
> ATI-IXP-IDE-support.patch
> ATI IXP IDE support
>
> ipmi-updates-3.patch
> IPMI driver updates
>
> ipmi-socket-interface.patch
> IPMI: socket interface
>
> md-use-schedule_timeout.patch
> md: use "shedule_timeout(2)" instead of yield()
>
> md-array-assembly-fix.patch
> md: allow assembling of partitioned arrays at boot time.
>
> compiler_h-scope-fixes.patch
> compiler.h scoping fixes
>
> remap-file-pages-prot-2.6.4-rc1-mm1-A1.patch
> per-page protections for remap_file_pages()
>
> nmi_watchdog-local-apic-fix.patch
> Fix nmi_watchdog=2 and P4 HT
>
> nmi-1-hz.patch
> set nmi_hz to 1 with nmi_watchdog=2 and SMP
>
> elf-mmap-fix.patch
> Fix elf mapping of the zero page
>
> kbuild-more-cleaning.patch
> kbuild: Cause `make clean' to remove more files
>
> LOOP_CHANGE_FD.patch
> LOOP_CHANGE_FD ioctl
>
> loop-setup-race-fix.patch
> loop setup race fix
>
> handle-dot-o-paths.patch
> kbuild: fix usage with directories containing '.o'
>
> acpi-asmlinkage-fix.patch
> gcc-3.5: acpi build fix
>
> ipc-sem-extra-sem_unlock.patch
> Remove unneeded unlock in ipc/sem.c
>
> procfs-dangling-subdir-fix.patch
> /proc data corruption check
>
> AMD-768MPX-bootmem-fix.patch
> Work around an AMD768MPX erratum
>
> i810fb-on-x86_64.patch
> Enable i810 fb on x86-64
>
> ext23-remove-acl-limits.patch
> Remove arbitrary #acl entries limits on ext[23] when reading
>
> watchdog-moduleparam-patches.patch
> watchdog: moduleparam-patches
>
> amd-elan-fix.patch
> AMD ELAN Kconfig fix
>
> pcmcia-netdev-ordering-fixes.patch
> PCMCIA netdevice ordering issues
>
> instrument-highmem-page-reclaim.patch
> vm: per-zone vmscan instrumentation
>
> blk_congestion_wait-return-remaining.patch
> return remaining jiffies from blk_congestion_wait()
>
> vmscan-remove-priority.patch
> mm/vmscan.c: remove unused priority argument.
>
> kswapd-throttling-fixes.patch
> kswapd throttling fixes
>
> vm-refill_inactive-preserve-referenced.patch
> vmscan: preserve page referenced info in refill_inactive()
>
> shrink_slab-precision-fix.patch
> shrink_slab: math precision fix
>
> try_to_free_pages-shrink_slab-evenness.patch
> vm: shrink slab evenly in try_to_free_pages()
>
> vmscan-total_scanned-fix.patch
> vmscan: fix calculation of number of pages scanned
>
> shrink_slab-for-all-zones-2.patch
> vm: scan slab in response to highmem scanning
>
> zone-balancing-fix-2.patch
> vmscan: zone balancing fix
>
> vmscan-control-by-nr_to_scan-only.patch
> vmscan: drive everything via nr_to_scan
>
> vmscan-balance-zone-scanning-rates.patch
> Balance inter-zone scan rates
>
> vmscan-dont-throttle-if-zero-max_scan.patch
> vmscan: avoid bogus throttling
>
> kswapd-avoid-higher-zones.patch
> kswapd: avoid unnecessary reclaiming from higher zones
>
> kswapd-avoid-higher-zones-reverse-direction.patch
> kswapd: fix lumpy page reclaim
>
> kswapd-avoid-higher-zones-reverse-direction-fix.patch
> fix the kswapd zone scanning algorithm
>
> vmscan-throttle-later.patch
> vmscan: less throttling of page allocators and kswapd
>
> vm-batch-inactive-scanning.patch
> vmscan: batch up inactive list scanning work
>
> vm-batch-inactive-scanning-fix.patch
> fix vm-batch-inactive-scanning.patch
>
> vm-balance-refill-rate.patch
> vm: balance inactive zone refill rates
>
> slab-no-higher-order.patch
> slab: avoid higher-order allocations
>
> list_del-debug.patch
> list_del debug check
>
> oops-dump-preceding-code.patch
> i386 oops output: dump preceding code
>
> lockmeter.patch
> lockmeter
>
> lockmeter-ia64-fix.patch
> ia64 CONFIG_LOCKMETER fix
>
> 4g-2.6.0-test2-mm2-A5.patch
> 4G/4G split patch
> 4G/4G: remove debug code
> 4g4g: pmd fix
> 4g/4g: fixes from Bill
> 4g4g: fpu emulation fix
> 4g/4g usercopy atomicity fix
> 4G/4G: remove debug code
> 4g4g: pmd fix
> 4g/4g: fixes from Bill
> 4g4g: fpu emulation fix
> 4g/4g usercopy atomicity fix
> 4G/4G preempt on vstack
> 4G/4G: even number of kmap types
> 4g4g: fix __get_user in slab
> 4g4g: Remove extra .data.idt section definition
> 4g/4g linker error (overlapping sections)
> 4G/4G: remove debug code
> 4g4g: pmd fix
> 4g/4g: fixes from Bill
> 4g4g: fpu emulation fix
> 4g4g: show_registers() fix
> 4g/4g usercopy atomicity fix
> 4g4g: debug flags fix
> 4g4g: Fix wrong asm-offsets entry
> cyclone time fixmap fix
> 4G/4G preempt on vstack
> 4G/4G: even number of kmap types
> 4g4g: fix __get_user in slab
> 4g4g: Remove extra .data.idt section definition
> 4g/4g linker error (overlapping sections)
> 4G/4G: remove debug code
> 4g4g: pmd fix
> 4g/4g: fixes from Bill
> 4g4g: fpu emulation fix
> 4g4g: show_registers() fix
> 4g/4g usercopy atomicity fix
> 4g4g: debug flags fix
> 4g4g: Fix wrong asm-offsets entry
> cyclone time fixmap fix
> use direct_copy_{to,from}_user for kernel access in mm/usercopy.c
> 4G/4G might_sleep warning fix
> 4g/4g pagetable accounting fix
> Fix 4G/4G and WP test lockup
> 4G/4G KERNEL_DS usercopy again
> Fix 4G/4G X11/vm86 oops
> Fix 4G/4G athlon triplefault
> 4g4g SEP fix
> Fix 4G/4G split fix for pre-pentiumII machines
> 4g/4g PAE ACPI low mappings fix
> zap_low_mappings() cannot be __init
> 4g/4g: remove printk at boot
>
> 4g4g-THREAD_SIZE-fixes.patch
>
> 4g4g-locked-userspace-copy.patch
> Do a locked user-space copy for 4g/4g
>
> ia32-4k-stacks.patch
> ia32: 4Kb stacks (and irqstacks) patch
>
> ia32-4k-stacks-build-fix.patch
> 4k stacks build fix
>
> 4k-stacks-in-modversions-magic.patch
> Add 4k stacks to module version magic
>
> 4g4g-handle_BUG-fix.patch
> 4g4g: fix handle_BUG()
>
> ppc-fixes.patch
> make mm4 compile on ppc
>
> ppc-fixes-dependency-fix.patch
> ppc-fixes dependency fix
>
> O_DIRECT-race-fixes-rollup.patch
> O_DIRECT data exposure fixes
>
> O_DIRECT-ll_rw_block-vs-block_write_full_page-fix.patch
> Fix race between ll_rw_block() and block_write_full_page()
>
> blockdev-direct-io-speedup.patch
> blockdev direct-io speedups
>
> O_DIRECT-vs-buffered-fix.patch
> Fix O_DIRECT-vs-buffered data exposure bug
>
> O_DIRECT-vs-buffered-fix-pdflush-hang-fix.patch
> pdflush hang fix
>
> serialise-writeback-fdatawait.patch
> serialize_writeback_fdatawait patch
>
> restore-writeback-trylock.patch
> writeback trylock patch
>
> dio-aio-fixes.patch
> direct-io AIO fixes
>
> aio-fallback-bio_count-race-fix-2.patch
> AIO+DIO bio_count race fix
>
> aio-direct-io-oops-fix.patch
> AIO/direct-io oops fix
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
---------------------------------------
Malte Schr?der
[email protected]
ICQ# 68121508
---------------------------------------
Malte Schr?der <[email protected]> wrote:
>
> Hi, by trying to unload alsa (emu10k1) I get the following:
>
> ------------[ cut here ]------------
> kernel BUG at fs/proc/generic.c:664!
> invalid operand: 0000 [#1]
> PREEMPT
> CPU: 0
> EIP: 0060:[<c0187be9>] Not tainted VLI
> EFLAGS: 00010286
> EIP is at remove_proc_entry+0xe9/0x140
> eax: f3209cc0 ebx: f3fb85f0 ecx: f63d2140 edx: f7fece00
> esi: 00000005 edi: f375a140 ebp: 00000000 esp: f42ffe70
> ds: 007b es: 007b ss: 0068
> Process modprobe (pid: 1835, threadinfo=f42fe000 task=f23b7150)
> Stack: f375a140 f375a188 f375a140 f3209dc0 f375a188 f9ada470 f375a240 00000080
> f9acfa7b f375a188 f3fb85c0 f74abe00 f74abe00 f9acf5b1 f375a240 f3fb85c0
> f42fe000 f9acddcf f74abe00 00000002 f22989c0 c0171bde f7ff7b2c f22989c0
> Call Trace:
> [<f9acfa7b>] snd_info_unregister+0x3b/0x70 [snd]
> [<f9acf5b1>] snd_info_card_free+0x31/0x60 [snd]
> [<f9acddcf>] snd_card_free+0xef/0x230 [snd]
> [<c0171bde>] destroy_inode+0x4e/0x50
> [<c016fca2>] dput+0x22/0x270
> [<f9b5e3a9>] snd_card_emu10k1_remove+0x19/0x30 [snd_emu10k1]
> [<c01f1f8b>] pci_device_remove+0x3b/0x40
This means that the driver deleted a /proc directory while it still has
live subdirectories. Arjan says this has been observed to lead to memory
corruption later on.
--- linux-v31/drivers/i2c/i2c-core.c 2004-02-19 19:31:07.000000000 -0600
+++ linux/drivers/i2c/i2c-core.c 2004-03-10 09:48:08.000000000 -0600
@@ -1256,6 +1256,12 @@
return (func & adap_func) == func;
}
+int i2c_spin_delay;
+void i2c_set_spin_delay(int val)
+{
+ i2c_spin_delay = val;
+}
+
EXPORT_SYMBOL(i2c_add_adapter);
EXPORT_SYMBOL(i2c_del_adapter);
EXPORT_SYMBOL(i2c_add_driver);
@@ -1292,6 +1298,8 @@
EXPORT_SYMBOL(i2c_get_functionality);
EXPORT_SYMBOL(i2c_check_functionality);
+EXPORT_SYMBOL(i2c_set_spin_delay);
+EXPORT_SYMBOL(i2c_spin_delay);
MODULE_AUTHOR("Simon G. Vogl <[email protected]>");
MODULE_DESCRIPTION("I2C-Bus main module");
--- linux-v31/include/linux/i2c.h 2003-12-17 20:58:16.000000000 -0600
+++ linux/include/linux/i2c.h 2004-03-10 09:47:21.000000000 -0600
@@ -600,10 +600,24 @@
((adapptr)->algo->id == I2C_ALGO_ISA)
/* Tiny delay function used by the i2c bus drivers */
+
+extern void i2c_set_spin_delay(int val);
+extern int i2c_spin_delay;
+#include <asm/delay.h>
static inline void i2c_delay(signed long timeout)
{
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(timeout);
+ if( i2c_spin_delay ) {
+ /* spin delay is needed for panic threads and
+ shutdowns to avoid processing switching so IPMI
+ messages can be sent to the Baseboard Management
+ Controllers on the SMBus*/
+ int i;
+ for( i=0 ; i<100 ; i++ )
+ udelay(timeout*(1000000/HZ/100));
+ } else {
+ set_current_state(TASK_INTERRUPTIBLE);
+ schedule_timeout(timeout);
+ }
}
#endif /* _LINUX_I2C_H */
On Wed, Mar 10, 2004 at 10:01:07AM -0600, Corey Minyard wrote:
>...
> I have included a patch from Todd Davis at Intel that adds this function
> to the I2C driver. I believe Todd has been working on getting this in
> through the I2C driver writers, although the patch is fairly non-intrusive.
>
> However, I have no real way to test this patch.
>...
I can only confirm that it fixes the compilation...
The patch to i2c-core.c is strange:
> --- linux-v31/drivers/i2c/i2c-core.c 2004-02-19 19:31:07.000000000 -0600
> +++ linux/drivers/i2c/i2c-core.c 2004-03-10 09:48:08.000000000 -0600
> @@ -1256,6 +1256,12 @@
> return (func & adap_func) == func;
> }
>
> +int i2c_spin_delay;
> +void i2c_set_spin_delay(int val)
> +{
> + i2c_spin_delay = val;
> +}
> +
> EXPORT_SYMBOL(i2c_add_adapter);
> EXPORT_SYMBOL(i2c_del_adapter);
> EXPORT_SYMBOL(i2c_add_driver);
> @@ -1292,6 +1298,8 @@
>
> EXPORT_SYMBOL(i2c_get_functionality);
> EXPORT_SYMBOL(i2c_check_functionality);
> +EXPORT_SYMBOL(i2c_set_spin_delay);
> +EXPORT_SYMBOL(i2c_spin_delay);
>
> MODULE_AUTHOR("Simon G. Vogl <[email protected]>");
> MODULE_DESCRIPTION("I2C-Bus main module");
>...
You can either add get/set functions and export them (more an OO
paradigm) or export the variable.
If you export the variable, it's quite useless to add such a set
function since everyone can set the variable directly.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Wed, Mar 10, 2004 at 10:01:07AM -0600, Corey Minyard wrote:
> You need to run off the panic events, the config flag IPMI_PANIC_EVENT,
> and it should compile fine. This is a flag that causes the driver to
> put some information about the panic into an event log in the IPMI
> controller so it can be fetched later.
>
> To do this, the driver needs a way to run each operation to completion
> without scheduling, interrupts. or the like. It needs this to do send
> the panic event (since you cannot schedule during a panic), although it
> also really needs it to do things like extend the watchdog timer time at
> panic time. The I2C driver does not currently have this, so it doesn't
> work with this option and the SMBus driver.
>
> I have included a patch from Todd Davis at Intel that adds this function
> to the I2C driver. I believe Todd has been working on getting this in
> through the I2C driver writers, although the patch is fairly non-intrusive.
All I've seen are some 2.4 patches, no 2.6 patches.
Anyone care to send them to the i2c maintainers?
thanks,
greg k-h
On Wed, Mar 10, 2004 at 07:51:05PM +0100, Adrian Bunk wrote:
> On Wed, Mar 10, 2004 at 10:01:07AM -0600, Corey Minyard wrote:
> >...
> > I have included a patch from Todd Davis at Intel that adds this function
> > to the I2C driver. I believe Todd has been working on getting this in
> > through the I2C driver writers, although the patch is fairly non-intrusive.
> >
> > However, I have no real way to test this patch.
> >...
>
> I can only confirm that it fixes the compilation...
>
>
> The patch to i2c-core.c is strange:
And dumb, and incorrect :(
thanks,
greg k-h
Adrian Bunk wrote:
>The patch to i2c-core.c is strange:
>
>
>
>
>>--- linux-v31/drivers/i2c/i2c-core.c 2004-02-19 19:31:07.000000000 -0600
>>+++ linux/drivers/i2c/i2c-core.c 2004-03-10 09:48:08.000000000 -0600
>>@@ -1256,6 +1256,12 @@
>> return (func & adap_func) == func;
>> }
>>
>>+int i2c_spin_delay;
>>+void i2c_set_spin_delay(int val)
>>+{
>>+ i2c_spin_delay = val;
>>+}
>>+
>> EXPORT_SYMBOL(i2c_add_adapter);
>> EXPORT_SYMBOL(i2c_del_adapter);
>> EXPORT_SYMBOL(i2c_add_driver);
>>@@ -1292,6 +1298,8 @@
>>
>> EXPORT_SYMBOL(i2c_get_functionality);
>> EXPORT_SYMBOL(i2c_check_functionality);
>>+EXPORT_SYMBOL(i2c_set_spin_delay);
>>+EXPORT_SYMBOL(i2c_spin_delay);
>>
>> MODULE_AUTHOR("Simon G. Vogl <[email protected]>");
>> MODULE_DESCRIPTION("I2C-Bus main module");
>>...
>>
>>
>
>
>You can either add get/set functions and export them (more an OO
>paradigm) or export the variable.
>
>If you export the variable, it's quite useless to add such a set
>function since everyone can set the variable directly.
>
I think the point is that lower-level drivers need to use this variable
(because of its use in the include file), but it's better to set it with
a function from external code.
Todd, am I correct here?
-Corey
The problem that is being addressed here is the need to avoid process
switching when sending IPMI messages over the SMBus/I2C bus. When the
kernel has panic'ed or is shutting down bus transactions need to
complete so the i2c bus drivers need to spin rather than calling
schedule.
The i2c_spin_delay is a flag that supports a revised inline function
i2c_delay() that was in i2c.h at one time.
static inline void i2c_delay(signed long timeout)
{
if( i2c_spin_delay ) {
int i;
for( i=0 ; i<100 ; i++ )
udelay(timeout*(1000000/HZ/100));
} else {
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(timeout);
}
}
Without this change i2c bus drivers will hang panic threads and short
circuit (fail) bus transactions during shutdown due to a pending signal.
I don't care how the exports are handled. It is the functionality that
is important here.
Todd C. Davis
These are my opinions and absolutely not official opinions of Intel
Corp.
-----Original Message-----
From: Corey Minyard [mailto:[email protected]]
Sent: Wednesday, March 10, 2004 2:12 PM
To: Adrian Bunk
Cc: Andrew Morton; [email protected]; Davis, Todd C;
[email protected]; [email protected]; Simon G. Vogl
Subject: Re: 2.6.4-rc2-mm1: IPMI_SMB doesnt compile
Adrian Bunk wrote:
>The patch to i2c-core.c is strange:
>
>
>
>
>>--- linux-v31/drivers/i2c/i2c-core.c 2004-02-19 19:31:07.000000000
-0600
>>+++ linux/drivers/i2c/i2c-core.c 2004-03-10 09:48:08.000000000
-0600
>>@@ -1256,6 +1256,12 @@
>> return (func & adap_func) == func;
>> }
>>
>>+int i2c_spin_delay;
>>+void i2c_set_spin_delay(int val)
>>+{
>>+ i2c_spin_delay = val;
>>+}
>>+
>> EXPORT_SYMBOL(i2c_add_adapter);
>> EXPORT_SYMBOL(i2c_del_adapter);
>> EXPORT_SYMBOL(i2c_add_driver);
>>@@ -1292,6 +1298,8 @@
>>
>> EXPORT_SYMBOL(i2c_get_functionality);
>> EXPORT_SYMBOL(i2c_check_functionality);
>>+EXPORT_SYMBOL(i2c_set_spin_delay);
>>+EXPORT_SYMBOL(i2c_spin_delay);
>>
>> MODULE_AUTHOR("Simon G. Vogl <[email protected]>");
>> MODULE_DESCRIPTION("I2C-Bus main module");
>>...
>>
>>
>
>
>You can either add get/set functions and export them (more an OO
>paradigm) or export the variable.
>
>If you export the variable, it's quite useless to add such a set
>function since everyone can set the variable directly.
>
I think the point is that lower-level drivers need to use this variable
(because of its use in the include file), but it's better to set it with
a function from external code.
Todd, am I correct here?
-Corey
Greg KH wrote:
>On Wed, Mar 10, 2004 at 07:51:05PM +0100, Adrian Bunk wrote:
>
>
>>On Wed, Mar 10, 2004 at 10:01:07AM -0600, Corey Minyard wrote:
>>
>>
>>>...
>>>I have included a patch from Todd Davis at Intel that adds this function
>>>to the I2C driver. I believe Todd has been working on getting this in
>>>through the I2C driver writers, although the patch is fairly non-intrusive.
>>>
>>>However, I have no real way to test this patch.
>>>...
>>>
>>>
>>I can only confirm that it fixes the compilation...
>>
>>
>>The patch to i2c-core.c is strange:
>>
>>
>
>And dumb, and incorrect :(
>
>
>
Wrong as in: "This code will not work" or wrong as in: "don't export the
variable and the function", or both? I certainly agree that exporting
both is wrong, there should really be two inline functions with only the
variable exported, or only functions exported and the variable hidden.
That's an easy change.
However, if the code does not work, that is a bigger deal. I'm fairly
sure it works in some cases, but not sure about all.
The patch I posted is for 2.6, BTW.
-Corey
On Wed, Mar 10, 2004 at 02:47:52PM -0600, Corey Minyard wrote:
> Greg KH wrote:
>
> >On Wed, Mar 10, 2004 at 07:51:05PM +0100, Adrian Bunk wrote:
> >
> >
> >>On Wed, Mar 10, 2004 at 10:01:07AM -0600, Corey Minyard wrote:
> >>
> >>
> >>>...
> >>>I have included a patch from Todd Davis at Intel that adds this function
> >>>to the I2C driver. I believe Todd has been working on getting this in
> >>>through the I2C driver writers, although the patch is fairly
> >>>non-intrusive.
> >>>
> >>>However, I have no real way to test this patch.
> >>>...
> >>>
> >>>
> >>I can only confirm that it fixes the compilation...
> >>
> >>
> >>The patch to i2c-core.c is strange:
> >>
> >>
> >
> >And dumb, and incorrect :(
> >
> >
> >
> Wrong as in: "This code will not work" or wrong as in: "don't export the
> variable and the function", or both?
Wrong as in "don't export the variable, the function, and on top of
that, not document what you are trying to do."
> I certainly agree that exporting both is wrong, there should really be
> two inline functions with only the variable exported, or only
> functions exported and the variable hidden. That's an easy change.
>
> However, if the code does not work, that is a bigger deal. I'm fairly
> sure it works in some cases, but not sure about all.
>
> The patch I posted is for 2.6, BTW.
But you never sent it to the i2c maintainers, right?
I understand what you are trying to accomplish with this type of patch,
but if you _really_ need to make this kind of change, please change the
name to something that really stands out as being not the thing you ever
would want to do.
Something like:
i2c_we_just_paniced_and_can_not_sleep_anymore()
thanks,
greg k-h
On Wednesday 10 March 2004 21:50, Davis, Todd C wrote:
> The problem that is being addressed here is the need to avoid process
> switching when sending IPMI messages over the SMBus/I2C bus. When the
> kernel has panic'ed or is shutting down bus transactions need to
> complete so the i2c bus drivers need to spin rather than calling
> schedule.
>
> The i2c_spin_delay is a flag that supports a revised inline function
> i2c_delay() that was in i2c.h at one time.
>
> static inline void i2c_delay(signed long timeout)
> {
> if( i2c_spin_delay ) {
> int i;
> for( i=0 ; i<100 ; i++ )
> udelay(timeout*(1000000/HZ/100));
> } else {
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(timeout);
> }
> }
too big for inline keyword
--
vda
On Mon, 08 Mar 2004 08:20:14 -0800, John Cherry wrote:
> Included with this report is a list of the current warnings from the
> 2.6.4-rc2-mm1 builds.
>
> Linux 2.6 (mm tree) Compile Statistics (gcc 3.2.2)
> Warnings/Errors Summary
>
> Kernel bzImage bzImage bzImage modules bzImage modules
> (defconfig) (allno) (allyes) (allyes) (allmod) (allmod)
> --------------- ---------- -------- -------- -------- -------- --------
> 2.6.3-rc2-mm1 1w/0e 5w/0e 146w/12e 11w/0e 3w/0e 147w/2e
> 2.6.3-rc1-mm2 1w/0e 5w/0e 144w/ 0e 11w/0e 3w/0e 145w/0e
> 2.6.3-rc1-mm1 1w/0e 5w/0e 147w/ 5e 11w/0e 3w/0e 147w/0e
> 2.6.3-mm4 1w/0e 5w/0e 146w/ 0e 7w/0e 3w/0e 142w/0e
> 2.6.3-mm3 1w/2e 5w/2e 146w/15e 7w/0e 3w/2e 144w/5e
> 2.6.3-mm2 1w/8e 5w/0e 140w/ 0e 7w/0e 3w/0e 138w/0e
> 2.6.3-mm1 1w/0e 5w/0e 143w/ 5e 7w/0e 3w/0e 141w/0e
> 2.6.3-rc3-mm1 1w/0e 0w/0e 144w/13e 7w/0e 3w/0e 142w/3e
> 2.6.3-rc2-mm1 1w/0e 0w/265e 144w/ 5e 7w/0e 3w/0e 145w/0e
> 2.6.3-rc1-mm1 1w/0e 0w/265e 141w/ 5e 7w/0e 3w/0e 143w/0e
The 2.6.4 stats are mislabeled 2.6.3...
-Paul