2004-03-28 19:37:12

by Arkadiusz Miskiewicz

[permalink] [raw]
Subject: [PATCH 2.6]: suspend to disk only available if non-modular IDE

Hi,

resume from disk doesn't work when using modular IDE so this patch disables
this in config:

--- kernel/power/Kconfig~ 2004-03-28 21:32:03.198944320 +0200
+++ kernel/power/Kconfig 2004-03-28 21:32:25.988479784 +0200
@@ -44,7 +44,7 @@

config PM_DISK
bool "Suspend-to-Disk Support"
- depends on PM && SWAP
+ depends on PM && SWAP && IDE=y && BLK_DEV_IDEDISK=y
---help---
Suspend-to-disk is a power management state in which the contents
of memory are stored on disk and the entire system is shut down or

Info here:
http://groups.google.com/groups?selm=1BdIH-5WB-17%40gated-at.bofh.it&oe=UTF-8&output=gplain
--
Arkadiusz Mi?kiewicz CS at FoE, Wroclaw University of Technology
arekm.pld-linux.org, 1024/3DB19BBD, JID: arekm.jabber.org, PLD/Linux


2004-03-28 23:41:31

by Nigel Cunningham

[permalink] [raw]
Subject: Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

Applied to 2.4 and 2.6.

Thanks and regards,

Nigel

On Mon, 2004-03-29 at 07:36, Arkadiusz Miskiewicz wrote:
> Hi,
>
> resume from disk doesn't work when using modular IDE so this patch disables
> this in config:
>
> --- kernel/power/Kconfig~ 2004-03-28 21:32:03.198944320 +0200
> +++ kernel/power/Kconfig 2004-03-28 21:32:25.988479784 +0200
> @@ -44,7 +44,7 @@
>
> config PM_DISK
> bool "Suspend-to-Disk Support"
> - depends on PM && SWAP
> + depends on PM && SWAP && IDE=y && BLK_DEV_IDEDISK=y
> ---help---
> Suspend-to-disk is a power management state in which the contents
> of memory are stored on disk and the entire system is shut down or
>
> Info here:
> http://groups.google.com/groups?selm=1BdIH-5WB-17%40gated-at.bofh.it&oe=UTF-8&output=gplain
--
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)

Evolution (n): A hypothetical process whereby infinitely improbable events occur
with alarming frequency, order arises from chaos, and no one is given credit.

2004-03-28 23:51:52

by Nigel Cunningham

[permalink] [raw]
Subject: Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

Oh.. should have said... "Applied to 2.4 and 2.6 suspend2 trees."

Nigel

On Mon, 2004-03-29 at 11:37, Nigel Cunningham wrote:
> Applied to 2.4 and 2.6.
>
> Thanks and regards,
>
> Nigel
>
> On Mon, 2004-03-29 at 07:36, Arkadiusz Miskiewicz wrote:
> > Hi,
> >
> > resume from disk doesn't work when using modular IDE so this patch disables
> > this in config:
> >
> > --- kernel/power/Kconfig~ 2004-03-28 21:32:03.198944320 +0200
> > +++ kernel/power/Kconfig 2004-03-28 21:32:25.988479784 +0200
> > @@ -44,7 +44,7 @@
> >
> > config PM_DISK
> > bool "Suspend-to-Disk Support"
> > - depends on PM && SWAP
> > + depends on PM && SWAP && IDE=y && BLK_DEV_IDEDISK=y
> > ---help---
> > Suspend-to-disk is a power management state in which the contents
> > of memory are stored on disk and the entire system is shut down or
> >
> > Info here:
> > http://groups.google.com/groups?selm=1BdIH-5WB-17%40gated-at.bofh.it&oe=UTF-8&output=gplain
--
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)

Evolution (n): A hypothetical process whereby infinitely improbable events occur
with alarming frequency, order arises from chaos, and no one is given credit.

2004-03-31 09:16:00

by Pavel Machek

[permalink] [raw]
Subject: Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

Hi!

> Applied to 2.4 and 2.6.

Bad idea. For swsusp2 the patch is bad because it can resume from
after initrd (IIRC). For swsusp1 patch is bad
because it should be able to resume
from usb mass storage drive.

Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms

2004-03-31 22:36:41

by Nigel Cunningham

[permalink] [raw]
Subject: Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

Hi.

On Wed, 2004-03-31 at 06:11, Pavel Machek wrote:
> Hi!
>
> > Applied to 2.4 and 2.6.
>
> Bad idea. For swsusp2 the patch is bad because it can resume from
> after initrd (IIRC). For swsusp1 patch is bad
> because it should be able to resume
> from usb mass storage drive.

So long as the initrd doesn't mess our filesystems up, we should be
okay, shouldn't we?

Nigel
--
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)

Evolution (n): A hypothetical process whereby infinitely improbable events occur
with alarming frequency, order arises from chaos, and no one is given credit.

2004-04-01 07:26:36

by Pavel Machek

[permalink] [raw]
Subject: Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

Hi!

> > > Applied to 2.4 and 2.6.
> >
> > Bad idea. For swsusp2 the patch is bad because it can resume from
> > after initrd (IIRC). For swsusp1 patch is bad
> > because it should be able to resume
> > from usb mass storage drive.
>
> So long as the initrd doesn't mess our filesystems up, we should be
> okay, shouldn't we?

As long as we test it once a while, yes.

But if resume from initrd works there's no reason to disallow modular
IDE... and that was what patch did.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]