2004-04-09 21:47:37

by Marcelo Tosatti

[permalink] [raw]
Subject: [PATCH] drivers/char/KConfig: Remove "BROKEN_ON_SMP" tag on CYCLADES entry


Hi Andrew,

The cyclades.c driver was marked BROKEN_ON_SMP during early 2.6. It was fixed later
on but the tag was left in Kconfig.

The driver is not very smart wrt SMP locking, it can be improved. There is only
one spinlock percard which guarantees command block ordering and protects different
shared data, which can be held for long periods.

_But_ the locking works reliably, so remove the BROKEN_ON_SMP tag.

Please apply.


--- linux-2.6.5-mc2.orig/drivers/char/Kconfig 2004-04-09 17:49:22.703814096 -0300
+++ linux-2.6.5-mc2/drivers/char/Kconfig 2004-04-08 18:04:21.000000000 -0300
@@ -110,7 +110,7 @@

config CYCLADES
tristate "Cyclades async mux support"
- depends on SERIAL_NONSTANDARD && BROKEN_ON_SMP
+ depends on SERIAL_NONSTANDARD
---help---
This is a driver for a card that gives you many serial ports. You
would need something like this to connect more than two modems to