2004-04-18 11:09:37

by Anton Blanchard

Subject: [PATCH] Oprofilefs cant handle > 99 cpus

Hi,

Oprofilefs cant handle > 99 cpus. This should fix it.

Anton

===== oprofile_stats.c 1.6 vs edited =====
--- 1.6/drivers/oprofile/oprofile_stats.c Mon Jan 19 17:33:51 2004
+++ edited/oprofile_stats.c Sun Apr 18 19:46:35 2004
@@ -55,7 +55,7 @@
continue;

cpu_buf = &cpu_buffer[i];
- snprintf(buf, 6, "cpu%d", i);
+ snprintf(buf, 10, "cpu%d", i);
cpudir = oprofilefs_mkdir(sb, dir, buf);

/* Strictly speaking access to these ulongs is racy,

2004-04-18 14:32:04

by Philippe Elie

Subject: Re: [PATCH] Oprofilefs cant handle > 99 cpus

On Sun, 18 Apr 2004 at 21:06 +0000, Anton Blanchard wrote:

>
> Hi,
>
> Oprofilefs cant handle > 99 cpus. This should fix it.

right.

> ===== oprofile_stats.c 1.6 vs edited =====
> --- 1.6/drivers/oprofile/oprofile_stats.c Mon Jan 19 17:33:51 2004
> +++ edited/oprofile_stats.c Sun Apr 18 19:46:35 2004
> @@ -55,7 +55,7 @@
> continue;
>
> cpu_buf = &cpu_buffer[i];
> - snprintf(buf, 6, "cpu%d", i);
> + snprintf(buf, 10, "cpu%d", i);
> cpudir = oprofilefs_mkdir(sb, dir, buf);
>
> /* Strictly speaking access to these ulongs is racy,

Andrew, can you apply this patch ?

regards,
Phil

2004-04-19 10:06:07

by Jan-Benedict Glaw

Subject: Re: [PATCH] Oprofilefs cant handle > 99 cpus

On Sun, 2004-04-18 21:06:58 +1000, Anton Blanchard <[email protected]>
wrote in message <20040418110658.GC26086@krispykreme>:
> Oprofilefs cant handle > 99 cpus. This should fix it.

Erm, on what hardware are you testing? Some large POWER5 machine?

MfG, JBG

--
Jan-Benedict Glaw [email protected] . +49-172-7608481
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg
fuer einen Freien Staat voll Freier B?rger" | im Internet! | im Irak!
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));