Hi,
This file mixes tabs with 8 spaces, leading to poor display
if one's editor doesn't have tab-stops set to 8. Please apply.
--linas
Signed-off-by: Linas Vepstas <[email protected]>
Forgot to attach the actual patch.
On Mon, Sep 20, 2004 at 05:19:33PM -0500, Linas Vepstas was heard to remark:
> Hi,
This file mixes tabs with 8 spaces, leading to poor display
if one's editor doesn't have tab-stops set to 8. Please apply.
--linas
Signed-off-by: Linas Vepstas <[email protected]>
On Tuesday 21 September 2004 01:31, Linas Vepstas wrote:
>
> Forgot to attach the actual patch.
>
> On Mon, Sep 20, 2004 at 05:19:33PM -0500, Linas Vepstas was heard to remark:
> > Hi,
>
>
> This file mixes tabs with 8 spaces, leading to poor display
> if one's editor doesn't have tab-stops set to 8. Please apply.
There are lots of such places.
Automated scripts can easily produce megabytes worth of whitespace
patches.
As I understand, such patches aren't accepted because
merging pain is much greater than gain.
Typically whitespace cleanups are piggybacked on some code changes.
--
vda
On Tue, Sep 21, 2004 at 02:07:09PM +0300, Denis Vlasenko was heard to remark:
> On Tuesday 21 September 2004 01:31, Linas Vepstas wrote:
> >
> > Forgot to attach the actual patch.
> >
> > On Mon, Sep 20, 2004 at 05:19:33PM -0500, Linas Vepstas was heard to remark:
> > > Hi,
> >
> >
> > This file mixes tabs with 8 spaces, leading to poor display
> > if one's editor doesn't have tab-stops set to 8. Please apply.
>
> There are lots of such places.
> Automated scripts can easily produce megabytes worth of whitespace
> patches.
>
> As I understand, such patches aren't accepted because
> merging pain is much greater than gain.
> Typically whitespace cleanups are piggybacked on some code changes.
Last time I sent in a combined whitespace plus other-fixes patch,
I was asked to do the opposite, and split them apart. I'm just
trying to do the right thing; I have other pending patches for this
file, and I'm waiting for the backlog to clear out before I submit
those.
--linas
On Tue, Sep 21, 2004 at 11:12:16AM -0500, Linas Vepstas wrote:
> On Tue, Sep 21, 2004 at 02:07:09PM +0300, Denis Vlasenko was heard to remark:
> > On Tuesday 21 September 2004 01:31, Linas Vepstas wrote:
> > >
> > > Forgot to attach the actual patch.
> > >
> > > On Mon, Sep 20, 2004 at 05:19:33PM -0500, Linas Vepstas was heard to remark:
> > > > Hi,
> > >
> > >
> > > This file mixes tabs with 8 spaces, leading to poor display
> > > if one's editor doesn't have tab-stops set to 8. Please apply.
> >
> > There are lots of such places.
> > Automated scripts can easily produce megabytes worth of whitespace
> > patches.
> >
> > As I understand, such patches aren't accepted because
> > merging pain is much greater than gain.
> > Typically whitespace cleanups are piggybacked on some code changes.
>
> Last time I sent in a combined whitespace plus other-fixes patch,
> I was asked to do the opposite, and split them apart. I'm just
> trying to do the right thing; I have other pending patches for this
> file, and I'm waiting for the backlog to clear out before I submit
> those.
well, I'd like to know if full whitespace cleanup
(trailing and indentation) _is_ something which
is interesting for linux mainline ...
because if so, I probably could provide a bunch of
patches too ...
TIA,
Herbert
> --linas
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
On Thu, Sep 23, 2004 at 01:17:00AM +0200, Herbert Poetzl was heard to remark:
> On Tue, Sep 21, 2004 at 11:12:16AM -0500, Linas Vepstas wrote:
> > On Tue, Sep 21, 2004 at 02:07:09PM +0300, Denis Vlasenko was heard to remark:
> > > On Tuesday 21 September 2004 01:31, Linas Vepstas wrote:
> > > >
> > > > Forgot to attach the actual patch.
> > > >
> > > > On Mon, Sep 20, 2004 at 05:19:33PM -0500, Linas Vepstas was heard to remark:
> > > > > Hi,
> > > >
> > > >
> > > > This file mixes tabs with 8 spaces, leading to poor display
> > > > if one's editor doesn't have tab-stops set to 8. Please apply.
> > >
> > > There are lots of such places.
> > > Automated scripts can easily produce megabytes worth of whitespace
> > > patches.
> > >
> > > As I understand, such patches aren't accepted because
> > > merging pain is much greater than gain.
> > > Typically whitespace cleanups are piggybacked on some code changes.
> >
> > Last time I sent in a combined whitespace plus other-fixes patch,
> > I was asked to do the opposite, and split them apart. I'm just
> > trying to do the right thing; I have other pending patches for this
> > file, and I'm waiting for the backlog to clear out before I submit
> > those.
>
> well, I'd like to know if full whitespace cleanup
> (trailing and indentation) _is_ something which
> is interesting for linux mainline ...
>
> because if so, I probably could provide a bunch of
> patches too ...
Hey, don't wreck it for me; I want this applied because I actually
read this file every couple of days. No need to clean up any files
that *I* don't read...
--linas
Herbert Poetzl writes:
> well, I'd like to know if full whitespace cleanup
> (trailing and indentation) _is_ something which
> is interesting for linux mainline ...
It's like this... you get to clean up the white space in a file (if
you want) IF you are also doing some useful work on the file - but the
whitespace cleanup and the useful work need to be separate patches in
order to ease later tracking of what changed.
Paul.
On Thu, Sep 23, 2004 at 08:36:46AM -0700, Paul Mackerras wrote:
> Herbert Poetzl writes:
>
> > well, I'd like to know if full whitespace cleanup
> > (trailing and indentation) _is_ something which
> > is interesting for linux mainline ...
>
> It's like this... you get to clean up the white space in a file (if
> you want) IF you are also doing some useful work on the file - but the
> whitespace cleanup and the useful work need to be separate patches in
> order to ease later tracking of what changed.
ah, okay, so a larger patch cleaning up the
whitespace issues in let's say linux/kernel or
linux/fs would not be appreciated ...
thanks for the info,
Herbert
> Paul.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
On Thursday 23 September 2004 19:08, Herbert Poetzl wrote:
> On Thu, Sep 23, 2004 at 08:36:46AM -0700, Paul Mackerras wrote:
> > Herbert Poetzl writes:
> >
> > > well, I'd like to know if full whitespace cleanup
> > > (trailing and indentation) _is_ something which
> > > is interesting for linux mainline ...
> >
> > It's like this... you get to clean up the white space in a file (if
> > you want) IF you are also doing some useful work on the file - but the
> > whitespace cleanup and the useful work need to be separate patches in
> > order to ease later tracking of what changed.
>
> ah, okay, so a larger patch cleaning up the
> whitespace issues in let's say linux/kernel or
> linux/fs would not be appreciated ...
Just in case, this is the script which can be used to generate patches
to fix whitespace in the tree. Unmodified script fixes only trailing ws
in printks and therefore ~250 generated patches have some chance of
acceptance.
Script has commented out code to fix all kinds of ws misuse.
If enabled, it produces nearly 50 MB worth of patches.
--
vda