As $subject says, usb-storage storage should automatically enable
scsi disk support in Kconfig.
Please apply.
Stelian.
Signed-off-by: Stelian Pop <[email protected]>
===== drivers/usb/storage/Kconfig 1.9 vs edited =====
--- 1.9/drivers/usb/storage/Kconfig 2004-06-13 17:24:10 +02:00
+++ edited/drivers/usb/storage/Kconfig 2004-11-19 16:44:16 +01:00
@@ -6,6 +6,7 @@
tristate "USB Mass Storage support"
depends on USB
select SCSI
+ select BLK_DEV_SD
---help---
Say Y here if you want to connect USB mass storage devices to your
computer's USB port. This is the driver you need for USB floppy drives,
--
Stelian Pop <[email protected]>
On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote:
> As $subject says, usb-storage storage should automatically enable
> scsi disk support in Kconfig.
>
> Please apply.
No, it shouldn't. There's lots of usb storage devices that don't use
sd, as there are lots of SPI/FC/etc.. devices.
On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote:
> On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote:
> > As $subject says, usb-storage storage should automatically enable
> > scsi disk support in Kconfig.
> >
> > Please apply.
>
> No, it shouldn't. There's lots of usb storage devices that don't use
> sd, as there are lots of SPI/FC/etc.. devices.
Indeed, I should have checked more carefully. My bad.
Still, it is not obvious that one should go into a completly different
config section and manually enable sd support, and I have been bitten
by this more than one time.
Maybe we should add, just below the 'USB storage' Kconfig option another
one, let's say 'SCSI disk based USB storage support', which documentation
would talk about 'usb keys, memory stick readers, USB floppy drives etc',
which should just be a dummy option selecting BLK_DEV_SD ?
Or perhaps we should add something along the Debian's dpkg 'suggests' rule
to Kconfig ? :)
Stelian.
--
Stelian Pop <[email protected]>
On Fri, Nov 19, 2004 at 10:39:42PM +0100, Stelian Pop wrote:
> On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote:
>
> > On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote:
> > > As $subject says, usb-storage storage should automatically enable
> > > scsi disk support in Kconfig.
> > >
> > > Please apply.
> >
> > No, it shouldn't. There's lots of usb storage devices that don't use
> > sd, as there are lots of SPI/FC/etc.. devices.
>
> Indeed, I should have checked more carefully. My bad.
>
> Still, it is not obvious that one should go into a completly different
> config section and manually enable sd support, and I have been bitten
> by this more than one time.
>
> Maybe we should add, just below the 'USB storage' Kconfig option another
> one, let's say 'SCSI disk based USB storage support', which documentation
> would talk about 'usb keys, memory stick readers, USB floppy drives etc',
> which should just be a dummy option selecting BLK_DEV_SD ?
>
> Or perhaps we should add something along the Debian's dpkg 'suggests' rule
> to Kconfig ? :)
I get enough e-mail on this topic that we should do something about it.
We need some sort of 'suggests' rule, or at least some sort of message to
the user to tell them to enable the high-level drivers.
Matt
--
Matthew Dharm Home: [email protected]
Maintainer, Linux USB Mass Storage Driver
What, are you one of those Microsoft-bashing Linux freaks?
-- Customer to Greg
User Friendly, 2/10/1999
Matthew Dharm wrote:
> On Fri, Nov 19, 2004 at 10:39:42PM +0100, Stelian Pop wrote:
>
>>On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote:
>>
>>
>>>On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote:
>>>
>>>>As $subject says, usb-storage storage should automatically enable
>>>>scsi disk support in Kconfig.
>>>>
>>>>Please apply.
>>>
>>>No, it shouldn't. There's lots of usb storage devices that don't use
>>>sd, as there are lots of SPI/FC/etc.. devices.
>>
>>Indeed, I should have checked more carefully. My bad.
>>
>>Still, it is not obvious that one should go into a completly different
>>config section and manually enable sd support, and I have been bitten
>>by this more than one time.
>>
>>Maybe we should add, just below the 'USB storage' Kconfig option another
>>one, let's say 'SCSI disk based USB storage support', which documentation
>>would talk about 'usb keys, memory stick readers, USB floppy drives etc',
>>which should just be a dummy option selecting BLK_DEV_SD ?
>>
>>Or perhaps we should add something along the Debian's dpkg 'suggests' rule
>>to Kconfig ? :)
>
>
> I get enough e-mail on this topic that we should do something about it.
> We need some sort of 'suggests' rule, or at least some sort of message to
> the user to tell them to enable the high-level drivers.
Until 'suggests' is available, does this help any?
It's tough getting people to read Help messages though.
Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also.
Add a few device types to help text and reformat it.
diffstat:=
drivers/usb/storage/Kconfig | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)
Signed-off-by: Randy Dunlap <[email protected]>
On Sat, Nov 20, 2004 at 03:21:54PM -0800, Randy.Dunlap wrote:
> >>>On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote:
> >>
> >>Maybe we should add, just below the 'USB storage' Kconfig option another
> >>one, let's say 'SCSI disk based USB storage support', which documentation
> >>would talk about 'usb keys, memory stick readers, USB floppy drives etc',
> >>which should just be a dummy option selecting BLK_DEV_SD ?
> Until 'suggests' is available, does this help any?
> It's tough getting people to read Help messages though.
>
> Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also.
> Add a few device types to help text and reformat it.
Isn't my above suggestion even better ? A separate config option
is much more visible IMHO...
Stelian.
--
Stelian Pop <[email protected]>
hoi :)
On Sat, Nov 20, 2004 at 03:21:54PM -0800, Randy.Dunlap wrote:
> Until 'suggests' is available, does this help any?
> It's tough getting people to read Help messages though.
perhaps the following is enough?
SCSI is auto-enabled by USB_STORAGE. We should enable BLK_DEV_SD
by default in this case but we should leave the option to turn it off.
Index: drivers/scsi/Kconfig
===================================================================
RCS file: /home/inf3/mnwaitz/src/linux-cvs/linux-2.5/drivers/scsi/Kconfig,v
retrieving revision 1.69
diff -u -p -r1.69 Kconfig
--- drivers/scsi/Kconfig 14 Nov 2004 04:33:58 -0000 1.69
+++ drivers/scsi/Kconfig 22 Nov 2004 14:48:22 -0000
@@ -38,6 +38,7 @@ comment "SCSI support type (disk, tape,
config BLK_DEV_SD
tristate "SCSI disk support"
depends on SCSI
+ default m
---help---
If you want to use SCSI hard disks, Fibre Channel disks,
USB storage or the SCSI or parallel port version of
--
Martin Waitz
On Mon, Nov 22, 2004 at 08:01:30AM -0800, Randy.Dunlap wrote:
> >>>>Maybe we should add, just below the 'USB storage' Kconfig option another
> >>>>one, let's say 'SCSI disk based USB storage support', which
> >>>>documentation
> >>>>would talk about 'usb keys, memory stick readers, USB floppy drives
> >>>>etc',
> >>>>which should just be a dummy option selecting BLK_DEV_SD ?
> >
> >
> >>Until 'suggests' is available, does this help any?
> >>It's tough getting people to read Help messages though.
> >>
> >>Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also.
> >>Add a few device types to help text and reformat it.
> >
> >
> >Isn't my above suggestion even better ? A separate config option
> >is much more visible IMHO...
>
> Sounds good, as long as we don't mind the same option being
> settable in multiple places. Did you submit a patch?
Nope, I was waiting for the discussion to settle.
But here it is:
===== drivers/usb/storage/Kconfig 1.9 vs edited =====
--- 1.9/drivers/usb/storage/Kconfig 2004-06-13 17:24:10 +02:00
+++ edited/drivers/usb/storage/Kconfig 2004-11-22 17:27:43 +01:00
@@ -45,6 +45,16 @@
If you say N here, the kernel will assume that all disk-like USB
devices are write-enabled.
+config USB_STORAGE_SD
+ bool "USB Mass Storage SCSI-like disks"
+ depends on USB_STORAGE
+ select BLK_DEV_SD
+ help
+ Say Y here if you want to enable support for SCSI-like USB
+ connected disks. These are the most used USB Mass Storage
+ devices, and include USB keys, USB floppy drives, most USB
+ flash memory readers, some USB photo cameras etc.
+
config USB_STORAGE_DATAFAB
bool "Datafab Compact Flash Reader support (EXPERIMENTAL)"
depends on USB_STORAGE && EXPERIMENTAL
--
Stelian Pop <[email protected]>
Stelian Pop wrote:
> On Sat, Nov 20, 2004 at 03:21:54PM -0800, Randy.Dunlap wrote:
>
>
>>>>>On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote:
>>>>
>>>>Maybe we should add, just below the 'USB storage' Kconfig option another
>>>>one, let's say 'SCSI disk based USB storage support', which documentation
>>>>would talk about 'usb keys, memory stick readers, USB floppy drives etc',
>>>>which should just be a dummy option selecting BLK_DEV_SD ?
>
>
>>Until 'suggests' is available, does this help any?
>>It's tough getting people to read Help messages though.
>>
>>Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also.
>>Add a few device types to help text and reformat it.
>
>
> Isn't my above suggestion even better ? A separate config option
> is much more visible IMHO...
Sounds good, as long as we don't mind the same option being
settable in multiple places. Did you submit a patch?
--
~Randy
On Sat, Nov 20, 2004 at 03:21:54PM -0800, Randy.Dunlap wrote:
>
> Until 'suggests' is available, does this help any?
> It's tough getting people to read Help messages though.
>
>
>
> Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also.
> Add a few device types to help text and reformat it.
Applied, thanks.
greg k-h