2005-01-20 18:23:49

by Adrian Bunk

[permalink] [raw]
Subject: [RFC: 2.6 patch] i386: unexport acpi_strict

I haven't found any possible modular usage of acpi_strict.

Is the patch below correct?


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.11-rc1-mm2-full/arch/i386/kernel/acpi/boot.c.old 2005-01-20 18:15:48.000000000 +0100
+++ linux-2.6.11-rc1-mm2-full/arch/i386/kernel/acpi/boot.c 2005-01-20 18:16:09.000000000 +0100
@@ -71,7 +71,6 @@
int acpi_lapic;
int acpi_ioapic;
int acpi_strict;
-EXPORT_SYMBOL(acpi_strict);

acpi_interrupt_flags acpi_sci_flags __initdata;
int acpi_sci_override_gsi __initdata;


2005-01-20 18:41:26

by Brown, Len

[permalink] [raw]
Subject: Re: [RFC: 2.6 patch] i386: unexport acpi_strict

On Thu, 2005-01-20 at 13:15, Adrian Bunk wrote:
> I haven't found any possible modular usage of acpi_strict.

I'd prefer to continue to export this flag if that isn't a burden.

The reason is that it is the only way we have to globally tell
the ACPI interpreter and all its (usually modularized) policy
drivers to allow or dis-allow support for platforms that openly
violate the ACPI spec. (By default the flag is clear and is
set explicity with "acpi_strict")

While the ACPI modules in the tree at the moment don't use
this flag, there are other out-of-tree
modules on the way, and they may need it.

-Len