2005-04-09 18:03:57

by Adrian Bunk

Subject: [2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow

This patch fixes an array overflow found by the Coverity checker.

Signed-off-by: Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 27 Mar 2005

--- linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c.old 2005-03-23 03:04:17.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c 2005-03-23 03:05:21.000000000 +0100
@@ -72,7 +72,9 @@
pnpbios_parse_allocated_dmaresource(struct pnp_resource_table * res, int dma)
{
int i = 0;
- while (!(res->dma_resource[i].flags & IORESOURCE_UNSET) && i < PNP_MAX_DMA) i++;
+ while (i < PNP_MAX_DMA &&
+ !(res->dma_resource[i].flags & IORESOURCE_UNSET))
+ i++;
if (i < PNP_MAX_DMA) {
res->dma_resource[i].flags = IORESOURCE_DMA; // Also clears _UNSET flag
if (dma == -1) {

2005-04-11 02:26:59

by Adam Belay

Subject: Re: [2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow

On Sat, Apr 09, 2005 at 08:03:52PM +0200, Adrian Bunk wrote:
> This patch fixes an array overflow found by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>

Looks good.

Thanks,
Adam