2005-04-19 00:56:45

by Adrian Bunk

Subject: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump

Signed-off-by: Adrian Bunk <[email protected]>

---

drivers/media/video/tveeprom.c | 6 ++++--
include/media/tveeprom.h | 1 -
2 files changed, 4 insertions(+), 3 deletions(-)

--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19 01:41:24.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19 01:41:28.000000000 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);

int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old 2005-04-19 01:40:39.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c 2005-04-19 01:41:13.000000000 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);

+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */

/* ----------------------------------------------------------------------- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;

-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;

static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}

-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = "tveeprom",
.id = I2C_DRIVERID_TVEEPROM,

2005-04-19 07:55:39

by Gerd Knorr

Subject: Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

> - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump

That's a debug helper function, please don't drop it. #if 0 might be
ok, not sure though, the tveeprom module is also used by a out-of-kernel
driver (ivtv). Otherwise the patch looks fine to me.

Gerd

2005-05-01 14:23:34

by Adrian Bunk

Subject: Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

On Tue, Apr 19, 2005 at 09:53:48AM +0200, Gerd Knorr wrote:

> > - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
>
> That's a debug helper function, please don't drop it. #if 0 might be
> ok, not sure though, the tveeprom module is also used by a out-of-kernel
> driver (ivtv). Otherwise the patch looks fine to me.

As the comment says, my patch does #if 0 the function.

> Gerd

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed