On Sun, May 08, 2005 at 10:23:51PM +0200, Jean Delvare wrote:
> Hi James,
>
> > I suggest that Ladislav's patch should still be applied and a
> > separate patch be submitted to export the interface to modules.
>
> Either way is fine with me as long as it actually happens.
Export ds1337_do_command so it could be used also if driver is built as
module.
Signed-off-by: Ladislav Michl <[email protected]>
--- linux-omap/drivers/i2c/chips/ds1337.c.orig 2005-05-10 14:10:49.637992600 +0200
+++ linux-omap/drivers/i2c/chips/ds1337.c 2005-05-10 14:13:05.064404656 +0200
@@ -380,5 +380,7 @@
MODULE_DESCRIPTION("DS1337 RTC driver");
MODULE_LICENSE("GPL");
+EXPORT_SYMBOL(ds1337_do_command);
+
module_init(ds1337_init);
module_exit(ds1337_exit);
Hi Ladislav,
> Export ds1337_do_command so it could be used also if driver is built as
> module.
Great, now we can apply the previous patch (changing the
ds1337_do_command parameters) and this one on top of it.
Thanks for your continued work on the ds1337 driver, this is much
appreciated.
--
Jean Delvare
On Tue, May 10, 2005 at 02:18:14PM +0200, Ladislav Michl wrote:
> On Sun, May 08, 2005 at 10:23:51PM +0200, Jean Delvare wrote:
> > Hi James,
> >
> > > I suggest that Ladislav's patch should still be applied and a
> > > separate patch be submitted to export the interface to modules.
> >
> > Either way is fine with me as long as it actually happens.
>
> Export ds1337_do_command so it could be used also if driver is built as
> module.
>
> Signed-off-by: Ladislav Michl <[email protected]>
>
> --- linux-omap/drivers/i2c/chips/ds1337.c.orig 2005-05-10 14:10:49.637992600 +0200
> +++ linux-omap/drivers/i2c/chips/ds1337.c 2005-05-10 14:13:05.064404656 +0200
> @@ -380,5 +380,7 @@
> MODULE_DESCRIPTION("DS1337 RTC driver");
> MODULE_LICENSE("GPL");
>
> +EXPORT_SYMBOL(ds1337_do_command);
EXPORT_SYMBOL_GPL() ok?
thanks,
greg k-h
On Tue, May 10, 2005 at 10:55:49AM -0700, Greg KH wrote:
> > --- linux-omap/drivers/i2c/chips/ds1337.c.orig 2005-05-10 14:10:49.637992600 +0200
> > +++ linux-omap/drivers/i2c/chips/ds1337.c 2005-05-10 14:13:05.064404656 +0200
> > @@ -380,5 +380,7 @@
> > MODULE_DESCRIPTION("DS1337 RTC driver");
> > MODULE_LICENSE("GPL");
> >
> > +EXPORT_SYMBOL(ds1337_do_command);
>
> EXPORT_SYMBOL_GPL() ok?
I do not realy care (and I think since unfamous SCO case people care
more about licenses than writing code). James is driver author, so I'll
do whatever he (and you) think is right. And while you bring up license
issue, comment on top of file says GPL version 2, but MODULE_LICENSE is
set to GPL.
Best regards,
ladis
On Tue, May 10, 2005 at 08:36:51PM +0200, Ladislav Michl wrote:
> And while you bring up license issue, comment on top of file says GPL
> version 2, but MODULE_LICENSE is set to GPL.
That is correct.
thanks,
greg k-h
On Tue, May 10, 2005 at 10:55:49AM -0700, Greg KH wrote:
> > --- linux-omap/drivers/i2c/chips/ds1337.c.orig 2005-05-10 14:10:49.637992600 +0200
> > +++ linux-omap/drivers/i2c/chips/ds1337.c 2005-05-10 14:13:05.064404656 +0200
> > @@ -380,5 +380,7 @@
> > MODULE_DESCRIPTION("DS1337 RTC driver");
> > MODULE_LICENSE("GPL");
> >
> > +EXPORT_SYMBOL(ds1337_do_command);
>
> EXPORT_SYMBOL_GPL() ok?
Export ds1337_do_command so it could be used also if driver is built as
module.
Signed-off-by: Ladislav Michl <[email protected]>
--- linux-omap/drivers/i2c/chips/ds1337.c.orig 2005-05-10 14:10:49.000000000 +0200
+++ linux-omap/drivers/i2c/chips/ds1337.c 2005-05-11 10:28:13.152690512 +0200
@@ -380,5 +380,7 @@
MODULE_DESCRIPTION("DS1337 RTC driver");
MODULE_LICENSE("GPL");
+EXPORT_SYMBOL_GPL(ds1337_do_command);
+
module_init(ds1337_init);
module_exit(ds1337_exit);