2005-09-11 19:04:34

by CIJOML

[permalink] [raw]
Subject: pluto2 patch

Hi,

I receive about 200 dmesg messages in 1 minut this fixes it, I think we can
easily remove this error message:

--- /usr/src/linux/drivers/media/dvb/pluto2/pluto2.c ? ?2005-09-11
14:09:19.000000000 +0200
+++ /usr/src/linux/drivers/media/dvb/pluto2/pluto2.c ? ?2005-09-11
14:10:17.000000000 +0200
@@ -291,8 +291,8 @@
? ? ? ? ? ? ? ? ? ? ? ? i += 188;
? ? ? ? ? ? ? ? valid = i / 188;
? ? ? ? ? ? ? ? if (nbpackets != valid) {
- ? ? ? ? ? ? ? ? ? ? ? dev_err(&pluto->pdev->dev, "nbpackets=%u valid=%u\n",
- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? nbpackets, valid);
+ ? ? ? /* ? ? ? ? ? ? ?dev_err(&pluto->pdev->dev, "nbpackets=%u valid=%u\n",
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? nbpackets, valid); */
? ? ? ? ? ? ? ? ? ? ? ? nbpackets = valid;
? ? ? ? ? ? ? ? }
? ? ? ? }

Thanks for applying!

There is another bug when card is removed, driver says card hung many times.
This part of code is responsible for it:

? ? ? ? if (tscr == 0xffffffff) {
? ? ? ? ? ? ? ? // FIXME: maybe recover somehow
? ? ? ? ? ? ? ? dev_err(&pluto->pdev->dev, "card hung up :(\n");
? ? ? ? ? ? ? ? return IRQ_HANDLED;

There should be probably
????????????????if (tscr == 0xffffffff) && !pcmcia_card_removed
to fix this.

Do anybody know exact name of this funtion in pcmcia code?

Thanks
Michal