2007-02-28 17:36:43

by Dave Jones

Subject: fix implicit declaration in nv_backlight.

drivers/video/nvidia/nv_backlight.c: In function 'nvidia_bl_init':
drivers/video/nvidia/nv_backlight.c:103: error: implicit declaration of function 'pmac_has_backlight_type'

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c~ 2007-02-20 22:25:15.000000000 -0500
+++ linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c 2007-02-20 22:25:31.000000000 -0500
@@ -12,6 +12,9 @@
#include <linux/backlight.h>
#include <linux/fb.h>
#include <linux/pci.h>
+#ifdef __powerpc__
+#include <asm/backlight.h>
+#endif
#include "nv_local.h"
#include "nv_type.h"
#include "nv_proto.h"

--
http://www.codemonkey.org.uk

2007-02-28 21:13:28

by Michael Hanselmann

Subject: Re: fix implicit declaration in nv_backlight.

On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
> +#ifdef __powerpc__

Is __powerpc__ defined when cross compiling? I'd rather use
CONFIG_PMAC_BACKLIGHT instead of it.

Greets,
Michael

2007-02-28 21:26:35

by Dave Jones

Subject: Re: fix implicit declaration in nv_backlight.

On Wed, Feb 28, 2007 at 10:13:24PM +0100, Michael Hanselmann wrote:
> On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
> > +#ifdef __powerpc__
>
> Is __powerpc__ defined when cross compiling? I'd rather use
> CONFIG_PMAC_BACKLIGHT instead of it.

Sounds ok to me.

Dave

--
http://www.codemonkey.org.uk

2007-02-28 21:50:39

by Antonino A. Daplas

Subject: Re: fix implicit declaration in nv_backlight.

> On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
>> +#ifdef __powerpc__
>
> Is __powerpc__ defined when cross compiling? I'd rather use
> CONFIG_PMAC_BACKLIGHT instead of it.

Agree with this too.

Tony