2007-06-21 14:53:20

by Glauber Costa

[permalink] [raw]

Subject: [PATCH] Move functions declarations to header file

---

diff --git a/arch/x86_64/kernel/i8259.c b/arch/x86_64/kernel/i8259.c
index 4b32665..948cae6 100644
--- a/arch/x86_64/kernel/i8259.c
+++ b/arch/x86_64/kernel/i8259.c
@@ -444,24 +444,6 @@ void __init init_ISA_irqs (void)
}
}

-void apic_timer_interrupt(void);
-void spurious_interrupt(void);
-void error_interrupt(void);
-void reschedule_interrupt(void);
-void call_function_interrupt(void);
-void irq_move_cleanup_interrupt(void);
-void invalidate_interrupt0(void);
-void invalidate_interrupt1(void);
-void invalidate_interrupt2(void);
-void invalidate_interrupt3(void);
-void invalidate_interrupt4(void);
-void invalidate_interrupt5(void);
-void invalidate_interrupt6(void);
-void invalidate_interrupt7(void);
-void thermal_interrupt(void);
-void threshold_interrupt(void);
-void i8254_timer_resume(void);
-
static void setup_timer_hardware(void)
{
outb_p(0x34,0x43); /* binary, mode 2, LSB/MSB, ch 0 */
diff --git a/include/asm-x86_64/hw_irq.h b/include/asm-x86_64/hw_irq.h
index 6153ae5..09dfc18 100644
--- a/include/asm-x86_64/hw_irq.h
+++ b/include/asm-x86_64/hw_irq.h
@@ -95,6 +95,26 @@


#ifndef __ASSEMBLY__
+
+/* Interrupt handlers registered during init_IRQ */
+void apic_timer_interrupt(void);
+void spurious_interrupt(void);
+void error_interrupt(void);
+void reschedule_interrupt(void);
+void call_function_interrupt(void);
+void irq_move_cleanup_interrupt(void);
+void invalidate_interrupt0(void);
+void invalidate_interrupt1(void);
+void invalidate_interrupt2(void);
+void invalidate_interrupt3(void);
+void invalidate_interrupt4(void);
+void invalidate_interrupt5(void);
+void invalidate_interrupt6(void);
+void invalidate_interrupt7(void);
+void thermal_interrupt(void);
+void threshold_interrupt(void);
+void i8254_timer_resume(void);
+
typedef int vector_irq_t[NR_VECTORS];
DECLARE_PER_CPU(vector_irq_t, vector_irq);
extern void __setup_vector_irq(int cpu);

---

Attachments:

(No filename) (404.00 B)
irq.patch (1.85 kB)
Download all attachments

2007-06-21 15:39:24

by Randy Dunlap

[permalink] [raw]

Subject: Re: [PATCH] Move functions declarations to header file

---

On Thu, 21 Jun 2007 11:54:11 -0300 Glauber de Oliveira Costa wrote:

> Some interrupt entry points are currently defined in i8259.c
> They probably belong in a header. Right now, their only user is
> init_IRQ, justifying their declaration in-file. But when virtualization
> comes in, we may be interested in using that functions in late
> initializations.
>
> Signed-off-by: Glauber de Oliveira Costa <[email protected]>

Patch is OK with me, but please insert patches inline in emails.
Lots of people who use mutt do this, so it must work and is the
preferred way.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***