2007-09-26 00:02:11

by Arthur Kepner

Subject: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

Introduce the dma_flags_set_dmaflush() interface and give it
a default no-op implementation.

Signed-off-by: Arthur Kepner <[email protected]>
--

dma-mapping.h | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 2dc21cb..a0f27b9 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -99,4 +99,11 @@ static inline void dmam_release_declared_memory(struct device *dev)
}
#endif /* ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY */

+#ifndef ARCH_CAN_REORDER_DMA
+static inline int
+dma_flags_set_dmaflush(int dir) {
+ return (dir);
+}
+#endif /* ARCH_CAN_REORDER_DMA */
+
#endif

2007-09-26 05:14:19

by Randy Dunlap

Subject: Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

On Tue, 25 Sep 2007 17:00:57 -0700 [email protected] wrote:

[adding James Bottomley to cc: since I think he's interested in
all of these patches]


> Introduce the dma_flags_set_dmaflush() interface and give it
> a default no-op implementation.
>
> Signed-off-by: Arthur Kepner <[email protected]>
> --
>
> dma-mapping.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 2dc21cb..a0f27b9 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -99,4 +99,11 @@ static inline void dmam_release_declared_memory(struct device *dev)
> }
> #endif /* ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY */
>
> +#ifndef ARCH_CAN_REORDER_DMA
> +static inline int
> +dma_flags_set_dmaflush(int dir) {
> + return (dir);
> +}
> +#endif /* ARCH_CAN_REORDER_DMA */
> +
> #endif


1. Function signature should be on one line if possible (and it is).
Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
Well, it's undesirable, so please don't propagate it.

2. No parens on return: it's not a function.

static inline int dma_flags_set_dmaflush(int dir)
{
return dir;
}


Similar comments for patch 2/4: sn-ia64.

---
~Randy
Phaedrus says that Quality is about caring.

2007-09-28 00:21:29

by Arthur Kepner

Subject: Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

On Tue, Sep 25, 2007 at 10:13:33PM -0700, Randy Dunlap wrote:
> On Tue, 25 Sep 2007 17:00:57 -0700 [email protected] wrote:
> ......
> 1. Function signature should be on one line if possible (and it is).
> Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
> Well, it's undesirable, so please don't propagate it.
>
> 2. No parens on return: it's not a function.
>
> static inline int dma_flags_set_dmaflush(int dir)
> {
> return dir;
> }
>
>
> Similar comments for patch 2/4: sn-ia64.
>

Both fixed in next version. Thanks, Randy.

--
Arthur