2007-10-29 13:29:21

by Dirk Hohndel

Subject: [PATCH] pciserial_resume_one ignored return value of pci_enable_device

[PATCH] pciserial_resume_one ignored return value of pci_enable_device

Signed-off-by: Dirk Hohndel <[email protected]>

---
drivers/serial/8250_pci.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c
index 0e35756..ceb03c9 100644
--- a/drivers/serial/8250_pci.c
+++ b/drivers/serial/8250_pci.c
@@ -1986,6 +1986,7 @@ static int pciserial_suspend_one(struct pci_dev *dev, pm_message_t state)

static int pciserial_resume_one(struct pci_dev *dev)
{
+ int err;
struct serial_private *priv = pci_get_drvdata(dev);

pci_set_power_state(dev, PCI_D0);
@@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct pci_dev *dev)
/*
* The device may have been disabled. Re-enable it.
*/
- pci_enable_device(dev);
+ err = pci_enable_device(dev);
+ if (err)
+ return err;

pciserial_resume_ports(priv);
}
--
gitgui.0.8.4.g8d863

2007-10-29 13:48:18

by Alan

Subject: Re: [PATCH] pciserial_resume_one ignored return value of pci_enable_device

On Mon, 29 Oct 2007 06:28:17 -0700
Dirk Hohndel <[email protected]> wrote:

> [PATCH] pciserial_resume_one ignored return value of pci_enable_device
>
> Signed-off-by: Dirk Hohndel <[email protected]>

Acked-by: Alan Cox <[email protected]>

Not sure its worth the hassle but I guess someone could pull a hotplug
PCI serial card and then resume.

2007-10-29 14:46:55

by Jeff Garzik

Subject: Re: [PATCH] pciserial_resume_one ignored return value of pci_enable_device

Dirk Hohndel wrote:
> [PATCH] pciserial_resume_one ignored return value of pci_enable_device
>
> Signed-off-by: Dirk Hohndel <[email protected]>
>
> ---
> drivers/serial/8250_pci.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c
> index 0e35756..ceb03c9 100644
> --- a/drivers/serial/8250_pci.c
> +++ b/drivers/serial/8250_pci.c
> @@ -1986,6 +1986,7 @@ static int pciserial_suspend_one(struct pci_dev *dev, pm_message_t state)
>
> static int pciserial_resume_one(struct pci_dev *dev)
> {
> + int err;
> struct serial_private *priv = pci_get_drvdata(dev);
>
> pci_set_power_state(dev, PCI_D0);
> @@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct pci_dev *dev)
> /*
> * The device may have been disabled. Re-enable it.
> */
> - pci_enable_device(dev);
> + err = pci_enable_device(dev);
> + if (err)
> + return err;

ACK