LinuxLists.cc - mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build fails on powerpc

[email protected] wrote:
> powerpc-move-_rtc_time-routines-under-config_adb_cuda.patch

CC net/9p/error.o
arch/powerpc/platforms/powermac/time.c:168: error: implicit declaration of function ?from_rtc_time?
arch/powerpc/platforms/powermac/time.c:225: error: implicit declaration of function ?to_rtc_time?
make[2]: *** [arch/powerpc/platforms/powermac/time.o] Error 1
make[1]: *** [arch/powerpc/platforms/powermac] Error 2
make: *** [arch/powerpc/platforms] Error 2

The above patch causes the build failure, because the from_rtc_time() and to_rtc_time() are
moved under the ifdef CONFIG_ADB_CUDA, but they are begin called in the pmu_set_rtc_time() and
pmac_get_rtc_time() under CONFIG_ADB_PMU.

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

2007-11-06 13:18:15

by Frederik Deweerdt

[permalink] [raw]

Subject: [-mm patch] fix getblk_slow "integer constant is too large" warning

On Tue, Nov 06, 2007 at 02:33:53AM -0800, [email protected] wrote:
> The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz
>
> It contains the following patches against 2.6.24-rc1:
>
[...]
> getblk-handle-2tb-devices.patch
[...]
0xffffffff00000000 is unsigned long long on 32 bits
fs/buffer.c: In function '__getblk_slow':
fs/buffer.c:1126: warning: integer constant is too large for 'unsigned long' type

Regards,
Frederik

Signed-off-by: Frederik Deweerdt <[email protected]>

diff --git a/fs/buffer.c b/fs/buffer.c
index ca713df..795fe86 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1123,7 +1123,7 @@ __getblk_slow(struct block_device *bdev, sector_t block, int size)

#if (BITS_PER_LONG == 32) && defined(CONFIG_LBD)
if ((block >> (PAGE_CACHE_SHIFT - bdev->bd_inode->i_blkbits)) &
- 0xffffffff00000000UL) {
+ 0xffffffff00000000ULL) {
/*
* We'll fail because the block is outside the range
* which a 32-bit pagecache index can address

2007-11-06 13:51:48

by Gabriel C

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

[email protected] wrote:
> The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz
>

Some warnings ( still building :) )

..

arch/x86/Kconfig.i386:178:warning: 'select' used by config symbol 'X86_RDC321X' refers to undefined symbol 'GENERIC_GPIO'

...

...

fs/buffer.c: In function '__getblk_slow':
fs/buffer.c:1126: warning: integer constant is too large for 'unsigned long' type

that is :

#if (BITS_PER_LONG == 32) && defined(CONFIG_LBD)
if ((block >> (PAGE_CACHE_SHIFT - bdev->bd_inode->i_blkbits)) &
0xffffffff00000000UL) { <-- ULL ?

...

...

fs/reiser4/tree.c: In function 'check_tree_pointer':
fs/reiser4/tree.c:807: warning: passing argument 1 of 'coord_clear_iplug' discards qualifiers from pointer target type
fs/reiser4/export_ops.c:25: warning: 'object_on_wire_done' defined but not used
fs/reiser4/export_ops.c:36: warning: 'decode_inode' defined but not used
fs/reiser4/export_ops.c:69: warning: 'reiser4_decode_fh' defined but not used
fs/reiser4/export_ops.c:261: warning: 'reiser4_get_dentry' defined but not used
fs/reiser4/plugin/file/cryptcompress.c: In function 'align_or_cut_overhead':
fs/reiser4/plugin/file/cryptcompress.c:847: warning: 'oh' may be used uninitialized in this function
fs/reiser4/plugin/item/item.c: In function 'obtain_item_plugin':
fs/reiser4/plugin/item/item.c:70: warning: passing argument 1 of 'coord_set_iplug' discards qualifiers from pointer target type

...

Some more but the rest exist in Linus git so I assume these are known.

Regards,

Gabriel C

2007-11-06 15:10:47

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails

Hi Andrew,

The build fails on the S390x with

CC drivers/s390/char/sclp_cpi_sys.o
drivers/s390/char/sclp_cpi_sys.c:242: error: variable `system_name_attr' has initializer but incomplete type
drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `attr' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:243: error: extra brace group at end of initializer
drivers/s390/char/sclp_cpi_sys.c:243: error: (near initialization for `system_name_attr')
drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr')
drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `show' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr')
drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `store' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr')
drivers/s390/char/sclp_cpi_sys.c:264: error: variable `sysplex_name_attr' has initializer but incomplete type
drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `attr' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:265: error: extra brace group at end of initializer
drivers/s390/char/sclp_cpi_sys.c:265: error: (near initialization for `sysplex_name_attr')
drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr')
drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `show' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr')
drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `store' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr')
drivers/s390/char/sclp_cpi_sys.c:287: error: variable `system_type_attr' has initializer but incomplete type
drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `attr' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:288: error: extra brace group at end of initializer
drivers/s390/char/sclp_cpi_sys.c:288: error: (near initialization for `system_type_attr')
drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr')
drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `show' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr')
drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `store' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr')
drivers/s390/char/sclp_cpi_sys.c:317: error: variable `system_level_attr' has initializer but incomplete type
drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `attr' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:318: error: extra brace group at end of initializer
drivers/s390/char/sclp_cpi_sys.c:318: error: (near initialization for `system_level_attr')
drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr')
drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `show' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr')
drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `store' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr')
drivers/s390/char/sclp_cpi_sys.c:333: error: variable `set_attr' has initializer but incomplete type
drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `attr' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:334: error: extra brace group at end of initializer
drivers/s390/char/sclp_cpi_sys.c:334: error: (near initialization for `set_attr')
drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr')
drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `show' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr')
drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `store' specified in initializer
drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer
drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr')
drivers/s390/char/sclp_cpi_sys.c:337: error: invalid use of undefined type `struct subsys_attribute'
drivers/s390/char/sclp_cpi_sys.c:337: error: initializer element is not constant
drivers/s390/char/sclp_cpi_sys.c:337: error: (near initialization for `cpi_attrs[0]')
drivers/s390/char/sclp_cpi_sys.c:338: error: invalid use of undefined type `struct subsys_attribute'
drivers/s390/char/sclp_cpi_sys.c:338: error: initializer element is not constant
drivers/s390/char/sclp_cpi_sys.c:338: error: (near initialization for `cpi_attrs[1]')
drivers/s390/char/sclp_cpi_sys.c:339: error: invalid use of undefined type `struct subsys_attribute'
drivers/s390/char/sclp_cpi_sys.c:339: error: initializer element is not constant
drivers/s390/char/sclp_cpi_sys.c:339: error: (near initialization for `cpi_attrs[2]')
drivers/s390/char/sclp_cpi_sys.c:340: error: invalid use of undefined type `struct subsys_attribute'
drivers/s390/char/sclp_cpi_sys.c:340: error: initializer element is not constant
drivers/s390/char/sclp_cpi_sys.c:340: error: (near initialization for `cpi_attrs[3]')
drivers/s390/char/sclp_cpi_sys.c:341: error: invalid use of undefined type `struct subsys_attribute'
drivers/s390/char/sclp_cpi_sys.c:341: error: initializer element is not constant
drivers/s390/char/sclp_cpi_sys.c:341: error: (near initialization for `cpi_attrs[4]')
drivers/s390/char/sclp_cpi_sys.c:349: error: syntax error before '(' token
drivers/s390/char/sclp_cpi_sys.c: In function `cpi_init':
drivers/s390/char/sclp_cpi_sys.c:379: error: implicit declaration of function `firmware_register'
drivers/s390/char/sclp_cpi_sys.c:379: error: `cpi_subsys' undeclared (first use in this function)
drivers/s390/char/sclp_cpi_sys.c:379: error: (Each undeclared identifier is reported only once
drivers/s390/char/sclp_cpi_sys.c:379: error: for each function it appears in.)
drivers/s390/char/sclp_cpi_sys.c:385: error: implicit declaration of function `firmware_unregister'
drivers/s390/char/sclp_cpi_sys.c: At top level:
drivers/s390/char/sclp_cpi_sys.c:242: error: storage size of `system_name_attr' isn't known
drivers/s390/char/sclp_cpi_sys.c:264: error: storage size of `sysplex_name_attr' isn't known
drivers/s390/char/sclp_cpi_sys.c:287: error: storage size of `system_type_attr' isn't known
drivers/s390/char/sclp_cpi_sys.c:317: error: storage size of `system_level_attr' isn't known
drivers/s390/char/sclp_cpi_sys.c:333: error: storage size of `set_attr' isn't known
make[2]: *** [drivers/s390/char/sclp_cpi_sys.o] Error 1
make[1]: *** [drivers/s390/char] Error 2
make: *** [drivers/s390] Error 2

The patch git-s390.patch is causing this failure.
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

2007-11-06 15:30:29

by Cornelia Huck

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails

On Tue, 06 Nov 2007 20:40:02 +0530,
Kamalesh Babulal <[email protected]> wrote:

> Hi Andrew,
>
> The build fails on the S390x with
>
> CC drivers/s390/char/sclp_cpi_sys.o
> drivers/s390/char/sclp_cpi_sys.c:242: error: variable `system_name_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:243: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:243: error: (near initialization for `system_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:264: error: variable `sysplex_name_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:265: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:265: error: (near initialization for `sysplex_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:287: error: variable `system_type_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:288: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:288: error: (near initialization for `system_type_attr')
> drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr')
> drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr')
> drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr')
> drivers/s390/char/sclp_cpi_sys.c:317: error: variable `system_level_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:318: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:318: error: (near initialization for `system_level_attr')
> drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr')
> drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr')
> drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr')
> drivers/s390/char/sclp_cpi_sys.c:333: error: variable `set_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:334: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:334: error: (near initialization for `set_attr')
> drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr')
> drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr')
> drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr')
> drivers/s390/char/sclp_cpi_sys.c:337: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:337: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:337: error: (near initialization for `cpi_attrs[0]')
> drivers/s390/char/sclp_cpi_sys.c:338: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:338: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:338: error: (near initialization for `cpi_attrs[1]')
> drivers/s390/char/sclp_cpi_sys.c:339: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:339: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:339: error: (near initialization for `cpi_attrs[2]')
> drivers/s390/char/sclp_cpi_sys.c:340: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:340: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:340: error: (near initialization for `cpi_attrs[3]')
> drivers/s390/char/sclp_cpi_sys.c:341: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:341: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:341: error: (near initialization for `cpi_attrs[4]')
> drivers/s390/char/sclp_cpi_sys.c:349: error: syntax error before '(' token
> drivers/s390/char/sclp_cpi_sys.c: In function `cpi_init':
> drivers/s390/char/sclp_cpi_sys.c:379: error: implicit declaration of function `firmware_register'
> drivers/s390/char/sclp_cpi_sys.c:379: error: `cpi_subsys' undeclared (first use in this function)
> drivers/s390/char/sclp_cpi_sys.c:379: error: (Each undeclared identifier is reported only once
> drivers/s390/char/sclp_cpi_sys.c:379: error: for each function it appears in.)
> drivers/s390/char/sclp_cpi_sys.c:385: error: implicit declaration of function `firmware_unregister'
> drivers/s390/char/sclp_cpi_sys.c: At top level:
> drivers/s390/char/sclp_cpi_sys.c:242: error: storage size of `system_name_attr' isn't known
> drivers/s390/char/sclp_cpi_sys.c:264: error: storage size of `sysplex_name_attr' isn't known
> drivers/s390/char/sclp_cpi_sys.c:287: error: storage size of `system_type_attr' isn't known
> drivers/s390/char/sclp_cpi_sys.c:317: error: storage size of `system_level_attr' isn't known
> drivers/s390/char/sclp_cpi_sys.c:333: error: storage size of `set_attr' isn't known
> make[2]: *** [drivers/s390/char/sclp_cpi_sys.o] Error 1
> make[1]: *** [drivers/s390/char] Error 2
> make: *** [drivers/s390] Error 2
>
> The patch git-s390.patch is causing this failure.

That's a clash between git-s390 and the recent kset cleanup.

sclp_cpi_sys.c needs to be converted from firmware_register() to the
new dynamic kset allocation (kset_create_and_register()) and the
subsys_attributes to kobj_attributes (I may look at it later if I find
some time).

2007-11-06 15:34:46

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs

Hi Andrew,

The build fails with following error

CC drivers/pci/hotplug/rpadlpar_sysfs.o
drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj.parent')
drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj')
drivers/pci/hotplug/rpadlpar_sysfs.c:134: error: unknown field `ktype' specified in initializer
drivers/pci/hotplug/rpadlpar_sysfs.c:134: warning: initialization from incompatible pointer type
make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
make[2]: *** [drivers/pci/hotplug] Error 2
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2

The patch, gregkh-driver-kset-convert-pci-hotplug-to-use-kset_create_and_register.patch
is causing the build failure.
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

2007-11-06 15:55:28

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build fails on powerpc

On Tue, 2007-11-06 at 18:27 +0530, Kamalesh Babulal wrote:
> [email protected] wrote:
> > powerpc-move-_rtc_time-routines-under-config_adb_cuda.patch
>
> CC net/9p/error.o
> arch/powerpc/platforms/powermac/time.c:168: error: implicit declaration of function ‘from_rtc_time’
> arch/powerpc/platforms/powermac/time.c:225: error: implicit declaration of function ‘to_rtc_time’
> make[2]: *** [arch/powerpc/platforms/powermac/time.o] Error 1
> make[1]: *** [arch/powerpc/platforms/powermac] Error 2
> make: *** [arch/powerpc/platforms] Error 2
>
> The above patch causes the build failure, because the from_rtc_time() and to_rtc_time() are
> moved under the ifdef CONFIG_ADB_CUDA, but they are begin called in the pmu_set_rtc_time() and
> pmac_get_rtc_time() under CONFIG_ADB_PMU.

Yes. My fault. This patch needs to be dropped. Sorry.

Thanks,
Badari

2007-11-06 16:42:31

by Cornelia Huck

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails

On Tue, 6 Nov 2007 16:29:39 +0100,
Cornelia Huck <[email protected]> wrote:

> That's a clash between git-s390 and the recent kset cleanup.
>
> sclp_cpi_sys.c needs to be converted from firmware_register() to the
> new dynamic kset allocation (kset_create_and_register()) and the
> subsys_attributes to kobj_attributes (I may look at it later if I find
> some time).

Adapt sclp_cpi_sys.c to the dynamic kset changes.

Signed-off-by: Cornelia Huck <[email protected]>

---
drivers/s390/char/sclp_cpi_sys.c | 58 ++++++++++++++++++++++-----------------
1 files changed, 33 insertions(+), 25 deletions(-)

Index: linux-2.6/drivers/s390/char/sclp_cpi_sys.c
===================================================================
--- linux-2.6.orig/drivers/s390/char/sclp_cpi_sys.c 2007-11-06 17:08:59.000000000 +0100
+++ linux-2.6/drivers/s390/char/sclp_cpi_sys.c 2007-11-06 17:30:09.000000000 +0100
@@ -220,13 +220,15 @@ static void set_string(char *attr, const
}
}

-static ssize_t system_name_show(struct kset *kset, char *page)
+static ssize_t system_name_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *page)
{
return snprintf(page, PAGE_SIZE, "%s\n", system_name);
}

-static ssize_t system_name_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t system_name_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf,
+ size_t len)
{
int rc;

@@ -239,16 +241,18 @@ static ssize_t system_name_store(struct
return len;
}

-static struct subsys_attribute system_name_attr =
+static struct kobj_attribute system_name_attr =
__ATTR(system_name, 0644, system_name_show, system_name_store);

-static ssize_t sysplex_name_show(struct kset *kset, char *page)
+static ssize_t sysplex_name_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *page)
{
return snprintf(page, PAGE_SIZE, "%s\n", sysplex_name);
}

-static ssize_t sysplex_name_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t sysplex_name_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf,
+ size_t len)
{
int rc;

@@ -261,17 +265,19 @@ static ssize_t sysplex_name_store(struct
return len;
}

-static struct subsys_attribute sysplex_name_attr =
+static struct kobj_attribute sysplex_name_attr =
__ATTR(sysplex_name, 0644, sysplex_name_show,
sysplex_name_store);

-static ssize_t system_type_show(struct kset *kset, char *page)
+static ssize_t system_type_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *page)
{
return snprintf(page, PAGE_SIZE, "%s\n", system_type);
}

-static ssize_t system_type_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t system_type_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf,
+ size_t len)
{
int rc;

@@ -284,18 +290,20 @@ static ssize_t system_type_store(struct
return len;
}

-static struct subsys_attribute system_type_attr =
+static struct kobj_attribute system_type_attr =
__ATTR(system_type, 0644, system_type_show, system_type_store);

-static ssize_t system_level_show(struct kset *kset, char *page)
+static ssize_t system_level_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *page)
{
unsigned long long level = system_level;

return snprintf(page, PAGE_SIZE, "%#018llx\n", level);
}

-static ssize_t system_level_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t system_level_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf,
+ size_t len)
{
unsigned long long level;
char *endp;
@@ -314,12 +322,12 @@ static ssize_t system_level_store(struct
return len;
}

-static struct subsys_attribute system_level_attr =
+static struct kobj_attribute system_level_attr =
__ATTR(system_level, 0644, system_level_show,
system_level_store);

-static ssize_t set_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t set_store(struct kobject *kobj, struct kobj_attribute *attr,
+ const char *buf, size_t len)
{
int rc;

@@ -330,7 +338,7 @@ static ssize_t set_store(struct kset *ks
return len;
}

-static struct subsys_attribute set_attr =
+static struct kobj_attribute set_attr =
__ATTR(set, 0200, NULL, set_store);

static struct attribute *cpi_attrs[] = {
@@ -346,7 +354,7 @@ static struct attribute_group cpi_attr_g
.attrs = cpi_attrs,
};

-static decl_subsys(cpi, NULL, NULL);
+static struct kset *cpi_kset;

int sclp_cpi_set_data(const char *system, const char *sysplex, const char *type,
const u64 level)
@@ -376,13 +384,13 @@ static int __init cpi_init(void)
{
int rc;

- rc = firmware_register(&cpi_subsys);
- if (rc)
- return rc;
+ cpi_kset = kset_create_and_register("cpi", NULL, NULL, firmware_kset);
+ if (IS_ERR(cpi_kset))
+ return PTR_ERR(cpi_kset);

- rc = sysfs_create_group(&cpi_subsys.kobj, &cpi_attr_group);
+ rc = sysfs_create_group(&cpi_kset->kobj, &cpi_attr_group);
if (rc)
- firmware_unregister(&cpi_subsys);
+ kset_unregister(cpi_kset);

return rc;
}

2007-11-06 17:17:17

by Balbir Singh

[permalink] [raw]

Subject: Re: [BUG] mm snapshot broken-out-2007-11-06-02-32.tar.gz - soft lockup

Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel is stuck at soft lockup while booting, with following
> call trace
>
> BUG: soft lockup - CPU#1 stuck for 11s! [mount:959]
>
> Pid: 959, comm: mount Not tainted (2.6.24-rc1-mm1-autokern1 #1)
> EIP: 0060:[<c1067b81>] EFLAGS: 00000206 CPU: 1
> EIP is at shrink_dcache_sb+0x4c/0xd1
> EAX: c132fe80 EBX: c1c21248 ECX: c1985000 EDX: fffffff3
> ESI: c1c21248 EDI: c1985000 EBP: c181a000 ESP: c2695e94
> DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
> CR0: 8005003b CR2: 09dc8000 CR3: 02675000 CR4: 000002f0
> DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
> DR6: ffff0ff0 DR7: 00000400
> [<c105b871>] do_remount_sb+0x2c/0xa4
> [<c108f0c0>] sysfs_fill_super+0x0/0x85
> [<c105bc7d>] get_sb_single+0x71/0x88
> [<c108f157>] sysfs_get_sb+0x12/0x17
> [<c108f0c0>] sysfs_fill_super+0x0/0x85
> [<c105bccb>] vfs_kern_mount+0x37/0x6e
> [<c106c7ec>] do_new_mount+0x86/0x109
> [<c106ce4b>] do_mount+0x18b/0x1a5
> [<c1002c84>] apic_timer_interrupt+0x28/0x30
> [<c106cc1e>] exact_copy_from_user+0x44/0x4f
> [<c106d0b7>] sys_mount+0x6f/0xad
> [<c100221e>] syscall_call+0x7/0xb
> [<c1200000>] svcauth_unix_set_client+0xc/0x14d
> =======================
>

Kamalesh,

sysrq output would be really nice. sysrq-t, sysrq-d, sysrq-m.
Please see Documentation/sysrq.txt for details on how to use
sysrq.

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL

2007-11-06 17:27:58

[permalink] [raw]

Subject: [BUG] mm snapshot broken-out-2007-11-06-02-32.tar.gz - soft lockup

Hi Andrew,

The kernel is stuck at soft lockup while booting, with following
call trace

BUG: soft lockup - CPU#1 stuck for 11s! [mount:959]

Pid: 959, comm: mount Not tainted (2.6.24-rc1-mm1-autokern1 #1)
EIP: 0060:[<c1067b81>] EFLAGS: 00000206 CPU: 1
EIP is at shrink_dcache_sb+0x4c/0xd1
EAX: c132fe80 EBX: c1c21248 ECX: c1985000 EDX: fffffff3
ESI: c1c21248 EDI: c1985000 EBP: c181a000 ESP: c2695e94
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
CR0: 8005003b CR2: 09dc8000 CR3: 02675000 CR4: 000002f0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c105b871>] do_remount_sb+0x2c/0xa4
[<c108f0c0>] sysfs_fill_super+0x0/0x85
[<c105bc7d>] get_sb_single+0x71/0x88
[<c108f157>] sysfs_get_sb+0x12/0x17
[<c108f0c0>] sysfs_fill_super+0x0/0x85
[<c105bccb>] vfs_kern_mount+0x37/0x6e
[<c106c7ec>] do_new_mount+0x86/0x109
[<c106ce4b>] do_mount+0x18b/0x1a5
[<c1002c84>] apic_timer_interrupt+0x28/0x30
[<c106cc1e>] exact_copy_from_user+0x44/0x4f
[<c106d0b7>] sys_mount+0x6f/0xad
[<c100221e>] syscall_call+0x7/0xb
[<c1200000>] svcauth_unix_set_client+0xc/0x14d
=======================

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Attachments:

config-autobench-2.6.24-rc1-mm1-autokern1 (27.61 kB)

2007-11-06 17:28:30

[permalink] [raw]

Subject: [BUG] mm snapshot broken-out-2007-11-06-02-32 - kernel oops

Hi Andrew,

Kernel bug, followed by soft lockup is hit, while booting in to 2.6.24-rc1 mm1
broken-out

BUG: unable to handle kernel NULL pointer dereference at virtual address 00000004
printing eip: c10675eb *pdpt = 000000000290c001 *pde = 0000000000000000
Oops: 0002 [#1] SMP
last sysfs file:
Modules linked in:

Pid: 1164, comm: mount Not tainted (2.6.24-rc1-mm1-autokern1 #1)
EIP: 0060:[<c10675eb>] EFLAGS: 00010202 CPU: 9
EIP is at d_kill+0xd/0x41
EAX: 00000000 EBX: c1c32088 ECX: c1c320b8 EDX: c1067509
ESI: c1c320b0 EDI: c1c32088 EBP: c22a5a00 ESP: c22b1ed0
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process mount (pid: 1164, ti=c22b0000 task=c29fa000 task.ti=c22b0000)
Stack: c1c32088 c1c320b0 c1067949 c1c320b0 c1067ba9 c22b1f34 c22a5a00 c2923000
c22a5a00 c105b839 00000001 c22b1f34 00000001 00000001 c106c4aa 00000000
00000080 c2870000 00000001 00000080 c22b1f34 c106cdb1 c2923000 00000000
Call Trace:
[<c1067949>] prune_one_dentry+0x30/0xa6
[<c1067ba9>] shrink_dcache_sb+0xa8/0xd1
[<c105b839>] do_remount_sb+0x2c/0xa4
[<c106c4aa>] do_remount+0x77/0xae
[<c106cdb1>] do_mount+0x131/0x1a5
[<c103c517>] __alloc_pages+0x45/0x2be
[<c106d077>] sys_mount+0x6f/0xad
[<c100221e>] syscall_call+0x7/0xb
[<c1200000>] unix_gid_parse+0x213/0x297
=======================
Code: f2 89 d8 ff d1 eb 14 5b 89 f0 5e e9 1c 29 00 00 c6 40 08 01 c6 05 80 fe 32 c1 01 5b 5e c3 56 8d 48 30 53 8b 51 04 89 c3 8b 40 30 <89> 50 04 89 02 89 d8 c7 43 30 00 01 10 00 c7 41 04 00 02 20 00
EIP: [<c10675eb>] d_kill+0xd/0x41 SS:ESP 0068:c22b1ed0
BUG: soft lockup - CPU#9 stuck for 11s! [mount:1164]

Pid: 1164, comm: mount Tainted: G D (2.6.24-rc1-mm1-autokern1 #1)
EIP: 0060:[<c1206684>] EFLAGS: 00000286 CPU: 9
EIP is at _spin_lock+0x5/0xf
EAX: c132fe80 EBX: c1c25e58 ECX: 00000000 EDX: 00000000
ESI: c132fe80 EDI: c1c20404 EBP: c1c25e58 ESP: c22b1dd4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: 00000004 CR3: 01370000 CR4: 000006f0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c10fe3be>] _atomic_dec_and_lock+0x2a/0x58
[<c1067687>] dput+0x68/0x114
[<c105ad44>] __fput+0x1b3/0x1d6
[<c1047a99>] remove_vma+0x25/0x42
[<c104952e>] exit_mmap+0xb6/0xcc
[<c10176c1>] mmput+0x36/0xa1
[<c101bc51>] do_exit+0x1db/0x28c
[<c10032e7>] die+0x1ac/0x1b1
[<c100f68a>] do_page_fault+0x5d1/0x6c3
[<c100f0b9>] do_page_fault+0x0/0x6c3
[<c120683a>] error_code+0x72/0x78
[<c1067509>] d_callback+0x0/0x5
[<c10f007b>] md4_transform+0x4a7/0x520
[<c10600d8>] __link_path_walk+0x1a1/0x99f
[<c10675eb>] d_kill+0xd/0x41
[<c1067949>] prune_one_dentry+0x30/0xa6
[<c1067ba9>] shrink_dcache_sb+0xa8/0xd1
[<c105b839>] do_remount_sb+0x2c/0xa4
[<c106c4aa>] do_remount+0x77/0xae
[<c106cdb1>] do_mount+0x131/0x1a5
[<c103c517>] __alloc_pages+0x45/0x2be
[<c106d077>] sys_mount+0x6f/0xad
[<c100221e>] syscall_call+0x7/0xb
[<c1200000>] unix_gid_parse+0x213/0x297
=======================
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Attachments:

config-autobench-2.6.24-rc1-mm1-autokern1 (27.61 kB)

2007-11-06 18:18:45

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs

On Tue, 2007-11-06 at 21:04 +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The build fails with following error
>
> CC drivers/pci/hotplug/rpadlpar_sysfs.o
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj.parent')
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj')
> drivers/pci/hotplug/rpadlpar_sysfs.c:134: error: unknown field `ktype' specified in initializer
> drivers/pci/hotplug/rpadlpar_sysfs.c:134: warning: initialization from incompatible pointer type
> make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
> make[2]: *** [drivers/pci/hotplug] Error 2
> make[1]: *** [drivers/pci] Error 2
> make: *** [drivers] Error 2
>
> The patch, gregkh-driver-kset-convert-pci-hotplug-to-use-kset_create_and_register.patch
> is causing the build failure.

Here is the fix (against 24-rc1 mm-brokenout). Can you try it ?

Thanks,
Badari

Signed-off-by: Badari Pulavarty <[email protected]>
---
drivers/pci/hotplug/rpadlpar_sysfs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6.24-rc1/drivers/pci/hotplug/rpadlpar_sysfs.c
===================================================================
--- linux-2.6.24-rc1.orig/drivers/pci/hotplug/rpadlpar_sysfs.c 2007-11-06 10:09:10.000000000 -0800
+++ linux-2.6.24-rc1/drivers/pci/hotplug/rpadlpar_sysfs.c 2007-11-06 10:11:33.000000000 -0800
@@ -129,14 +129,13 @@ struct kobj_type ktype_dlpar_io = {
};

struct kset dlpar_io_kset = {
- .kobj = {.ktype = &ktype_dlpar_io,
- .parent = &pci_hotplug_slots_kset->kobj},
- .ktype = &ktype_dlpar_io,
+ .kobj = {.ktype = &ktype_dlpar_io},
};

int dlpar_sysfs_init(void)
{
kobject_set_name(&dlpar_io_kset.kobj, DLPAR_KOBJ_NAME);
+ dlpar_io_kset.kobj.parent = &pci_hotplug_slots_kset->kobj;
if (kset_register(&dlpar_io_kset)) {
printk(KERN_ERR "rpadlpar_io: cannot register kset for %s\n",
kobject_name(&dlpar_io_kset.kobj));

2007-11-06 18:36:03

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

On Tue, 2007-11-06 at 02:33 -0800, [email protected] wrote:
> The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz
>

> gregkh-driver-kset-convert-sys-devices-to-use-kset_create.patch

Above patch renamed devices_subsys to devices_kset to catch all users of
the variable. Need fixes to vio.

# make -j8 zImage
CHK include/linux/version.h
CHK include/linux/utsrelease.h
CALL scripts/checksyscalls.sh
<stdin>:1389:2: warning: #warning syscall revokeat not implemented
<stdin>:1393:2: warning: #warning syscall frevoke not implemented
CHK include/linux/compile.h
GEN .version
CHK include/linux/compile.h
UPD include/linux/compile.h
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
arch/powerpc/kernel/built-in.o(.toc+0x1548): undefined reference to
`devices_subsys'
make: *** [.tmp_vmlinux1] Error 1

Here is the patch, Is this correct usage ?

Thanks,
Badari

---
arch/powerpc/kernel/vio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.24-rc1/arch/powerpc/kernel/vio.c
===================================================================
--- linux-2.6.24-rc1.orig/arch/powerpc/kernel/vio.c 2007-10-23 20:50:57.000000000 -0700
+++ linux-2.6.24-rc1/arch/powerpc/kernel/vio.c 2007-11-06 10:31:56.000000000 -0800
@@ -37,7 +37,7 @@
#include <asm/iseries/hv_call_xm.h>
#include <asm/iseries/iommu.h>

-extern struct kset devices_subsys; /* needed for vio_find_name() */
+extern struct kset *devices_kset; /* needed for vio_find_name() */

static struct bus_type vio_bus_type;

@@ -369,7 +369,7 @@ static struct vio_dev *vio_find_name(con
{
struct kobject *found;

- found = kset_find_obj(&devices_subsys, kobj_name);
+ found = kset_find_obj(devices_kset, kobj_name);
if (!found)
return NULL;

2007-11-06 18:45:46

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 - powerpc link failure

Hi Andrew,

The kernel linking fails on the powerpc, with following error message

CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
arch/powerpc/kernel/built-in.o(.toc+0x1550): undefined reference to `devices_subsys'
make: *** [.tmp_vmlinux1] Error 1

~ # gcc -v
Reading specs from /usr/lib/gcc-lib/powerpc-suse-linux/3.3.3/specs
Configured with: ../configure --enable-threads=posix --prefix=/usr --with-local-prefix=/usr/local --infodir=/usr/share/info --mandir=/usr/share/man --enable-languages=c,c++,f77,objc,java,ada --disable-checking --libdir=/usr/lib --enable-libgcj --with-gxx-include-dir=/usr/include/g++ --with-slibdir=/lib --with-system-zlib --enable-shared --enable-__cxa_atexit --host=powerpc-suse-linux --build=powerpc-suse-linux --target=powerpc-suse-linux --enable-targets=powerpc64-suse-linux --enable-biarch
Thread model: posix
gcc version 3.3.3 (SuSE Linux)

~ # ld -v
GNU ld version 2.15.90.0.1.1 20040303 (SuSE Linux)

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Attachments:

dotconfig (27.59 kB)

2007-11-06 18:59:31

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 - powerpc link failure

On Tue, 2007-11-06 at 23:47 +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel linking fails on the powerpc, with following error message
>
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> arch/powerpc/kernel/built-in.o(.toc+0x1550): undefined reference to `devices_subsys'
> make: *** [.tmp_vmlinux1] Error 1

I sent a fix for this 30 minutes ago ..

Here it is anyway.

Thanks,
Badari

---
arch/powerpc/kernel/vio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.24-rc1/arch/powerpc/kernel/vio.c
===================================================================
--- linux-2.6.24-rc1.orig/arch/powerpc/kernel/vio.c 2007-10-23 20:50:57.000000000 -0700
+++ linux-2.6.24-rc1/arch/powerpc/kernel/vio.c 2007-11-06 10:31:56.000000000 -0800
@@ -37,7 +37,7 @@
#include <asm/iseries/hv_call_xm.h>
#include <asm/iseries/iommu.h>

-extern struct kset devices_subsys; /* needed for vio_find_name() */
+extern struct kset *devices_kset; /* needed for vio_find_name() */

static struct bus_type vio_bus_type;

@@ -369,7 +369,7 @@ static struct vio_dev *vio_find_name(con
{
struct kobject *found;

- found = kset_find_obj(&devices_subsys, kobj_name);
+ found = kset_find_obj(devices_kset, kobj_name);
if (!found)
return NULL;

2007-11-06 19:32:34

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs

On Tue, Nov 06, 2007 at 09:04:02PM +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The build fails with following error
>
> CC drivers/pci/hotplug/rpadlpar_sysfs.o
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj.parent')
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj')
> drivers/pci/hotplug/rpadlpar_sysfs.c:134: error: unknown field `ktype' specified in initializer
> drivers/pci/hotplug/rpadlpar_sysfs.c:134: warning: initialization from incompatible pointer type
> make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
> make[2]: *** [drivers/pci/hotplug] Error 2
> make[1]: *** [drivers/pci] Error 2
> make: *** [drivers] Error 2
>
> The patch, gregkh-driver-kset-convert-pci-hotplug-to-use-kset_create_and_register.patch
> is causing the build failure.

Ah, thanks, I'll go fix that up right now, that was due to the ktype
being removed from the kset. If you comment out the line:
.ktype = &ktype_dlpar_io,

it should build properly, right?

thanks,

greg k-h

2007-11-06 19:46:54

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs

On Tue, Nov 06, 2007 at 10:19:28AM -0800, Badari Pulavarty wrote:
> On Tue, 2007-11-06 at 21:04 +0530, Kamalesh Babulal wrote:
> > Hi Andrew,
> >
> > The build fails with following error
> >
> > CC drivers/pci/hotplug/rpadlpar_sysfs.o
> > drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
> > drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj.parent')
> > drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
> > drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj')
> > drivers/pci/hotplug/rpadlpar_sysfs.c:134: error: unknown field `ktype' specified in initializer
> > drivers/pci/hotplug/rpadlpar_sysfs.c:134: warning: initialization from incompatible pointer type
> > make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
> > make[2]: *** [drivers/pci/hotplug] Error 2
> > make[1]: *** [drivers/pci] Error 2
> > make: *** [drivers] Error 2
> >
> > The patch, gregkh-driver-kset-convert-pci-hotplug-to-use-kset_create_and_register.patch
> > is causing the build failure.
>
> Here is the fix (against 24-rc1 mm-brokenout). Can you try it ?
>
> Thanks,
> Badari

Hi Badari,

This patch fixes the buidl failure.

Tested-by: Kamalesh Babulal <[email protected]>
Signed-off-by: Badari Pulavarty <[email protected]>
---
drivers/pci/hotplug/rpadlpar_sysfs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6.24-rc1/drivers/pci/hotplug/rpadlpar_sysfs.c
===================================================================
--- linux-2.6.24-rc1.orig/drivers/pci/hotplug/rpadlpar_sysfs.c 2007-11-06 10:09:10.000000000 -0800
+++ linux-2.6.24-rc1/drivers/pci/hotplug/rpadlpar_sysfs.c 2007-11-06 10:11:33.000000000 -0800
@@ -129,14 +129,13 @@ struct kobj_type ktype_dlpar_io = {
};

struct kset dlpar_io_kset = {
- .kobj = {.ktype = &ktype_dlpar_io,
- .parent = &pci_hotplug_slots_kset->kobj},
- .ktype = &ktype_dlpar_io,
+ .kobj = {.ktype = &ktype_dlpar_io},
};

int dlpar_sysfs_init(void)
{
kobject_set_name(&dlpar_io_kset.kobj, DLPAR_KOBJ_NAME);
+ dlpar_io_kset.kobj.parent = &pci_hotplug_slots_kset->kobj;
if (kset_register(&dlpar_io_kset)) {
printk(KERN_ERR "rpadlpar_io: cannot register kset for %s\n",
kobject_name(&dlpar_io_kset.kobj));

2007-11-06 19:47:20

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs

On Tue, Nov 06, 2007 at 09:04:02PM +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The build fails with following error
>
> CC drivers/pci/hotplug/rpadlpar_sysfs.o
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj.parent')
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not constant
> drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for `dlpar_io_kset.kobj')
> drivers/pci/hotplug/rpadlpar_sysfs.c:134: error: unknown field `ktype' specified in initializer
> drivers/pci/hotplug/rpadlpar_sysfs.c:134: warning: initialization from incompatible pointer type
> make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
> make[2]: *** [drivers/pci/hotplug] Error 2
> make[1]: *** [drivers/pci] Error 2
> make: *** [drivers] Error 2
>
> The patch, gregkh-driver-kset-convert-pci-hotplug-to-use-kset_create_and_register.patch
> is causing the build failure.

Actually, in looking at that file some more, the whole way that file
creates sysfs files and uses them is so messed up it's not funny (get
the return value of writing to a file by reading from it? WTF?)

I'll go clean up all this crap now that we can do simple kobject
attributes easier...

thanks,

greg k-h

2007-11-06 19:50:32

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

On Tue, Nov 06, 2007 at 10:36:58AM -0800, Badari Pulavarty wrote:
> On Tue, 2007-11-06 at 02:33 -0800, [email protected] wrote:
> > The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz
> >
>
> > gregkh-driver-kset-convert-sys-devices-to-use-kset_create.patch
>
> Above patch renamed devices_subsys to devices_kset to catch all users of
> the variable. Need fixes to vio.
>
>
> # make -j8 zImage
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CALL scripts/checksyscalls.sh
> <stdin>:1389:2: warning: #warning syscall revokeat not implemented
> <stdin>:1393:2: warning: #warning syscall frevoke not implemented
> CHK include/linux/compile.h
> GEN .version
> CHK include/linux/compile.h
> UPD include/linux/compile.h
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> arch/powerpc/kernel/built-in.o(.toc+0x1548): undefined reference to
> `devices_subsys'
> make: *** [.tmp_vmlinux1] Error 1
>
>
> Here is the patch, Is this correct usage ?

Yes, but, what is this file doing mucking around in a "private" variable
to the driver core? No wonder I never caught this, as it's one
reference away from being declared static.

Please fix this file up properly, like the comment in vio.c shows:
* XXX once vio_bus_type.devices is actually used as a kset in
* drivers/base/bus.c, this function should be removed in favor of
* "device_find(kobj_name, &vio_bus_type)"

The fact that this function works at all is so tenous and scary that I
would never trust it on a running system. Let alone something so
"enterprise" as a pseries box...

thanks,

greg k-h

2007-11-06 20:02:37

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails

On Tue, Nov 06, 2007 at 05:42:08PM +0100, Cornelia Huck wrote:
> On Tue, 6 Nov 2007 16:29:39 +0100,
> Cornelia Huck <[email protected]> wrote:
>
> > That's a clash between git-s390 and the recent kset cleanup.
> >
> > sclp_cpi_sys.c needs to be converted from firmware_register() to the
> > new dynamic kset allocation (kset_create_and_register()) and the
> > subsys_attributes to kobj_attributes (I may look at it later if I find
> > some time).
>
> Adapt sclp_cpi_sys.c to the dynamic kset changes.

Hi Cornelia,

Thanks, the patch fixes the build failure.

Tested-by: Kamalesh Babulal <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>

---
drivers/s390/char/sclp_cpi_sys.c | 58 ++++++++++++++++++++++-----------------
1 files changed, 33 insertions(+), 25 deletions(-)

Index: linux-2.6/drivers/s390/char/sclp_cpi_sys.c
===================================================================
--- linux-2.6.orig/drivers/s390/char/sclp_cpi_sys.c 2007-11-06 17:08:59.000000000 +0100
+++ linux-2.6/drivers/s390/char/sclp_cpi_sys.c 2007-11-06 17:30:09.000000000 +0100
@@ -220,13 +220,15 @@ static void set_string(char *attr, const
}
}

-static ssize_t system_name_show(struct kset *kset, char *page)
+static ssize_t system_name_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *page)
{
return snprintf(page, PAGE_SIZE, "%s\n", system_name);
}

-static ssize_t system_name_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t system_name_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf,
+ size_t len)
{
int rc;

@@ -239,16 +241,18 @@ static ssize_t system_name_store(struct
return len;
}

-static struct subsys_attribute system_name_attr =
+static struct kobj_attribute system_name_attr =
__ATTR(system_name, 0644, system_name_show, system_name_store);

-static ssize_t sysplex_name_show(struct kset *kset, char *page)
+static ssize_t sysplex_name_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *page)
{
return snprintf(page, PAGE_SIZE, "%s\n", sysplex_name);
}

-static ssize_t sysplex_name_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t sysplex_name_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf,
+ size_t len)
{
int rc;

@@ -261,17 +265,19 @@ static ssize_t sysplex_name_store(struct
return len;
}

-static struct subsys_attribute sysplex_name_attr =
+static struct kobj_attribute sysplex_name_attr =
__ATTR(sysplex_name, 0644, sysplex_name_show,
sysplex_name_store);

-static ssize_t system_type_show(struct kset *kset, char *page)
+static ssize_t system_type_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *page)
{
return snprintf(page, PAGE_SIZE, "%s\n", system_type);
}

-static ssize_t system_type_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t system_type_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf,
+ size_t len)
{
int rc;

@@ -284,18 +290,20 @@ static ssize_t system_type_store(struct
return len;
}

-static struct subsys_attribute system_type_attr =
+static struct kobj_attribute system_type_attr =
__ATTR(system_type, 0644, system_type_show, system_type_store);

-static ssize_t system_level_show(struct kset *kset, char *page)
+static ssize_t system_level_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *page)
{
unsigned long long level = system_level;

return snprintf(page, PAGE_SIZE, "%#018llx\n", level);
}

-static ssize_t system_level_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t system_level_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf,
+ size_t len)
{
unsigned long long level;
char *endp;
@@ -314,12 +322,12 @@ static ssize_t system_level_store(struct
return len;
}

-static struct subsys_attribute system_level_attr =
+static struct kobj_attribute system_level_attr =
__ATTR(system_level, 0644, system_level_show,
system_level_store);

-static ssize_t set_store(struct kset *kset, const char *buf,
- size_t len)
+static ssize_t set_store(struct kobject *kobj, struct kobj_attribute *attr,
+ const char *buf, size_t len)
{
int rc;

@@ -330,7 +338,7 @@ static ssize_t set_store(struct kset *ks
return len;
}

-static struct subsys_attribute set_attr =
+static struct kobj_attribute set_attr =
__ATTR(set, 0200, NULL, set_store);

static struct attribute *cpi_attrs[] = {
@@ -346,7 +354,7 @@ static struct attribute_group cpi_attr_g
.attrs = cpi_attrs,
};

-static decl_subsys(cpi, NULL, NULL);
+static struct kset *cpi_kset;

int sclp_cpi_set_data(const char *system, const char *sysplex, const char *type,
const u64 level)
@@ -376,13 +384,13 @@ static int __init cpi_init(void)
{
int rc;

- rc = firmware_register(&cpi_subsys);
- if (rc)
- return rc;
+ cpi_kset = kset_create_and_register("cpi", NULL, NULL, firmware_kset);
+ if (IS_ERR(cpi_kset))
+ return PTR_ERR(cpi_kset);

- rc = sysfs_create_group(&cpi_subsys.kobj, &cpi_attr_group);
+ rc = sysfs_create_group(&cpi_kset->kobj, &cpi_attr_group);
if (rc)
- firmware_unregister(&cpi_subsys);
+ kset_unregister(cpi_kset);

return rc;
}

2007-11-06 20:15:21

by Gabriel C

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

After some hours uptime I got the following Oops :

[15745.009673] BUG: unable to handle kernel paging request at virtual address 63383166
[15745.009683] printing eip: c01c50a2 *pde = 00000000
[15745.009692] Oops: 0002 [#1] SMP
[15745.009699] last sysfs file: /sys/devices/pci0000:00/0000:00:1e.0/0000:04:0b.0/irq
[15745.009705] Modules linked in: fuse pc87360 hwmon_vid eeprom adm1021 ext4dev jbd2 crc16 loop lp intel_agp sr_mod agpgart 3c59x parport_pc iTCO_wdt mii parport iTCO_vendor_support cdrom i82860_edac watchdog_core edac_core dcdbas pcspkr i2c_i801 watchdog_dev shpchp evdev pci_hotplug
[15745.009742]
[15745.009746] Pid: 6277, comm: su Not tainted (2.6.24-rc1-mm1 #2)
[15745.009751] EIP: 0060:[<c01c50a2>] EFLAGS: 00210206 CPU: 1
[15745.009761] EIP is at kobject_add+0xae/0x160
[15745.009765] EAX: c186c300 EBX: cf81a0b0 ECX: 63383166 EDX: cf81a0b8
[15745.009769] ESI: cf81a0b0 EDI: cf81a0d0 EBP: c03b4bcc ESP: cfa37f40
[15745.009773] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
[15745.009778] Process su (pid: 6277, ti=cfa36000 task=c354c000 task.ti=cfa36000)
[15745.009781] Stack: fffffffe c186c30c cf81a080 cf81a0b0 cf81a0d0 c03b4bcc c011fba1 cf81a0b0
[15745.009793] c0368fd1 00000013 cf81a080 cf81a080 00000013 00000000 c011fe94 00000013
[15745.009804] 00000013 00000001 00000000 c0122e0d 00000013 00000000 09756508 c0124688
[15745.009815] Call Trace:
[15745.009820] [<c011fba1>] uids_user_create+0x41/0x5a
[15745.009833] [<c011fe94>] alloc_uid+0xad/0x121
[15745.009840] [<c0122e0d>] set_user+0x1d/0x93
[15745.009847] [<c0124688>] sys_setuid+0x47/0xc5
[15745.009855] [<c0103d32>] sysenter_past_esp+0x5f/0x85
[15745.009868] =======================
[15745.009870] Code: d4 13 00 83 7c 24 04 00 75 0f 8b 43 14 83 c0 0c e8 fc fb ff ff 89 44 24 04 8b 43 14 8b 48 04 8d 53 08 89 50 04 89 43 08 89 4b 0c <89> 11 8b 43 14 83 c0 08 c6 00 01 8b 44 24 04 89 43 10 c7 04 24
[15745.009928] EIP: [<c01c50a2>] kobject_add+0xae/0x160 SS:ESP 0068:cfa37f40

Regards,

Gabriel

2007-11-06 20:16:53

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails

> On Tue, 06 Nov 2007 20:40:02 +0530 Kamalesh Babulal <[email protected]> wrote:
> Hi Andrew,
>
> The build fails on the S390x with
>
> CC drivers/s390/char/sclp_cpi_sys.o
> drivers/s390/char/sclp_cpi_sys.c:242: error: variable `system_name_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:243: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:243: error: (near initialization for `system_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:264: error: variable `sysplex_name_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:265: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:265: error: (near initialization for `sysplex_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr')
> drivers/s390/char/sclp_cpi_sys.c:287: error: variable `system_type_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:288: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:288: error: (near initialization for `system_type_attr')
> drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr')
> drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr')
> drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr')
> drivers/s390/char/sclp_cpi_sys.c:317: error: variable `system_level_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:318: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:318: error: (near initialization for `system_level_attr')
> drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr')
> drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr')
> drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr')
> drivers/s390/char/sclp_cpi_sys.c:333: error: variable `set_attr' has initializer but incomplete type
> drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `attr' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:334: error: extra brace group at end of initializer
> drivers/s390/char/sclp_cpi_sys.c:334: error: (near initialization for `set_attr')
> drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr')
> drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `show' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr')
> drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `store' specified in initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer
> drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr')
> drivers/s390/char/sclp_cpi_sys.c:337: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:337: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:337: error: (near initialization for `cpi_attrs[0]')
> drivers/s390/char/sclp_cpi_sys.c:338: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:338: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:338: error: (near initialization for `cpi_attrs[1]')
> drivers/s390/char/sclp_cpi_sys.c:339: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:339: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:339: error: (near initialization for `cpi_attrs[2]')
> drivers/s390/char/sclp_cpi_sys.c:340: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:340: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:340: error: (near initialization for `cpi_attrs[3]')
> drivers/s390/char/sclp_cpi_sys.c:341: error: invalid use of undefined type `struct subsys_attribute'
> drivers/s390/char/sclp_cpi_sys.c:341: error: initializer element is not constant
> drivers/s390/char/sclp_cpi_sys.c:341: error: (near initialization for `cpi_attrs[4]')
> drivers/s390/char/sclp_cpi_sys.c:349: error: syntax error before '(' token
> drivers/s390/char/sclp_cpi_sys.c: In function `cpi_init':
> drivers/s390/char/sclp_cpi_sys.c:379: error: implicit declaration of function `firmware_register'
> drivers/s390/char/sclp_cpi_sys.c:379: error: `cpi_subsys' undeclared (first use in this function)
> drivers/s390/char/sclp_cpi_sys.c:379: error: (Each undeclared identifier is reported only once
> drivers/s390/char/sclp_cpi_sys.c:379: error: for each function it appears in.)
> drivers/s390/char/sclp_cpi_sys.c:385: error: implicit declaration of function `firmware_unregister'
> drivers/s390/char/sclp_cpi_sys.c: At top level:
> drivers/s390/char/sclp_cpi_sys.c:242: error: storage size of `system_name_attr' isn't known
> drivers/s390/char/sclp_cpi_sys.c:264: error: storage size of `sysplex_name_attr' isn't known
> drivers/s390/char/sclp_cpi_sys.c:287: error: storage size of `system_type_attr' isn't known
> drivers/s390/char/sclp_cpi_sys.c:317: error: storage size of `system_level_attr' isn't known
> drivers/s390/char/sclp_cpi_sys.c:333: error: storage size of `set_attr' isn't known
> make[2]: *** [drivers/s390/char/sclp_cpi_sys.o] Error 1
> make[1]: *** [drivers/s390/char] Error 2
> make: *** [drivers/s390] Error 2
>
> The patch git-s390.patch is causing this failure.

git-s390 newly adds that file. I suspect that this code works OK for the
s390 guys (they're using Linux). But Greg's driver tree basically ports
their driver to Gregnux, in which nothing works any more.

Greg, this is turning into a bit of a trainwreck. Can you please have a
think about how we can provide a bit of back-compatibility to ease this
transition rather than just trashing everything?

2007-11-06 20:30:41

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

On Tue, 2007-11-06 at 02:33 -0800, [email protected] wrote:
> The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz
>
> It contains the following patches against 2.6.24-rc1:

Getting OOPS on shutdown.

Unable to handle kernel paging request for data at address 0x600000040
Faulting instruction address: 0xc000000000341a68
Oops: Kernel access of bad area, sig: 11 [#1]
SMP NR_CPUS=32 NUMA pSeries
Modules linked in:
NIP: c000000000341a68 LR: c000000000341ab4 CTR: c0000000002e8904
REGS: c000000008403910 TRAP: 0300 Not tainted (2.6.24-rc1-mm1)
MSR: 8000000000009032 <EE,ME,IR,DR> CR: 24002444 XER: 20000001
DAR: 0000000600000040, DSISR: 0000000040000000
TASK = c00000000dff12a0[12966] 'reboot' THREAD: c000000008400000 CPU: 3
GPR00: c000000003131480 c000000008403b90 c00000000071cb38 c00000000331c000
GPR04: 0000000000000001 0000000000000000 c0000000007dac20 c00000000000f528
GPR08: c0000000031310a8 0000000600000000 c0000000031311a8 c00000000077c760
GPR12: 0000000044002428 c000000000648c80 0000000000000001 0000000000000000
GPR16: 000000001009ba50 0000000000000000 0000000010070000 0000000000000000
GPR20: 0000000000000000 0000000000000001 0000000000000000 0000000000000000
GPR24: 0000000000000001 0000000000000000 0000000000000000 0000000000004000
GPR28: 00000000fee1dead 0000000028121969 c0000000006b2368 c000000000621bd0
NIP [c000000000341a68] .device_shutdown+0x4c/0xd4
LR [c000000000341ab4] .device_shutdown+0x98/0xd4
Call Trace:
[c000000008403b90] [c000000000341ab4] .device_shutdown+0x98/0xd4 (unreliable)
[c000000008403c10] [c000000000067780] .kernel_restart+0x40/0x98
[c000000008403c90] [c0000000000679f4] .sys_reboot+0x214/0x25c
[c000000008403e30] [c00000000000852c] syscall_exit+0x0/0x40
Instruction dump:
60000000 60000000 e9690000 e92b0008 3909ff00 7fa95800 e9280108 3be9ff00
419e0080 e9280178 2fa90000 419e0014 <e9290040> 7d034378 2fa90000 409e0020

2007-11-06 20:40:58

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

> On Tue, 06 Nov 2007 21:14:58 +0100 Gabriel C <[email protected]> wrote:
> After some hours uptime I got the following Oops :
>
> [15745.009673] BUG: unable to handle kernel paging request at virtual address 63383166

An all-ascii address: "c81f".

> [15745.009683] printing eip: c01c50a2 *pde = 00000000
> [15745.009692] Oops: 0002 [#1] SMP
> [15745.009699] last sysfs file: /sys/devices/pci0000:00/0000:00:1e.0/0000:04:0b.0/irq
> [15745.009705] Modules linked in: fuse pc87360 hwmon_vid eeprom adm1021 ext4dev jbd2 crc16 loop lp intel_agp sr_mod agpgart 3c59x parport_pc iTCO_wdt mii parport iTCO_vendor_support cdrom i82860_edac watchdog_core edac_core dcdbas pcspkr i2c_i801 watchdog_dev shpchp evdev pci_hotplug
> [15745.009742]
> [15745.009746] Pid: 6277, comm: su Not tainted (2.6.24-rc1-mm1 #2)
> [15745.009751] EIP: 0060:[<c01c50a2>] EFLAGS: 00210206 CPU: 1
> [15745.009761] EIP is at kobject_add+0xae/0x160
> [15745.009765] EAX: c186c300 EBX: cf81a0b0 ECX: 63383166 EDX: cf81a0b8
> [15745.009769] ESI: cf81a0b0 EDI: cf81a0d0 EBP: c03b4bcc ESP: cfa37f40
> [15745.009773] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
> [15745.009778] Process su (pid: 6277, ti=cfa36000 task=c354c000 task.ti=cfa36000)
> [15745.009781] Stack: fffffffe c186c30c cf81a080 cf81a0b0 cf81a0d0 c03b4bcc c011fba1 cf81a0b0
> [15745.009793] c0368fd1 00000013 cf81a080 cf81a080 00000013 00000000 c011fe94 00000013
> [15745.009804] 00000013 00000001 00000000 c0122e0d 00000013 00000000 09756508 c0124688
> [15745.009815] Call Trace:
> [15745.009820] [<c011fba1>] uids_user_create+0x41/0x5a
> [15745.009833] [<c011fe94>] alloc_uid+0xad/0x121
> [15745.009840] [<c0122e0d>] set_user+0x1d/0x93
> [15745.009847] [<c0124688>] sys_setuid+0x47/0xc5
> [15745.009855] [<c0103d32>] sysenter_past_esp+0x5f/0x85
> [15745.009868] =======================
> [15745.009870] Code: d4 13 00 83 7c 24 04 00 75 0f 8b 43 14 83 c0 0c e8 fc fb ff ff 89 44 24 04 8b 43 14 8b 48 04 8d 53 08 89 50 04 89 43 08 89 4b 0c <89> 11 8b 43 14 83 c0 08 c6 00 01 8b 44 24 04 89 43 10 c7 04 24
> [15745.009928] EIP: [<c01c50a2>] kobject_add+0xae/0x160 SS:ESP 0068:cfa37f40
>

Don't knowm sorry - we'll need to wait until someone can hit it more
reliably :(

2007-11-06 21:06:22

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs

2007-11-06 21:08:43

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

On Tue, Nov 06, 2007 at 01:40:52PM -0800, Andrew Morton wrote:
> > On Tue, 06 Nov 2007 21:14:58 +0100 Gabriel C <[email protected]> wrote:
> > After some hours uptime I got the following Oops :
> >
> > [15745.009673] BUG: unable to handle kernel paging request at virtual address 63383166
>
> An all-ascii address: "c81f".
>
> > [15745.009683] printing eip: c01c50a2 *pde = 00000000
> > [15745.009692] Oops: 0002 [#1] SMP
> > [15745.009699] last sysfs file: /sys/devices/pci0000:00/0000:00:1e.0/0000:04:0b.0/irq
> > [15745.009705] Modules linked in: fuse pc87360 hwmon_vid eeprom adm1021 ext4dev jbd2 crc16 loop lp intel_agp sr_mod agpgart 3c59x parport_pc iTCO_wdt mii parport iTCO_vendor_support cdrom i82860_edac watchdog_core edac_core dcdbas pcspkr i2c_i801 watchdog_dev shpchp evdev pci_hotplug
> > [15745.009742]
> > [15745.009746] Pid: 6277, comm: su Not tainted (2.6.24-rc1-mm1 #2)
> > [15745.009751] EIP: 0060:[<c01c50a2>] EFLAGS: 00210206 CPU: 1
> > [15745.009761] EIP is at kobject_add+0xae/0x160
> > [15745.009765] EAX: c186c300 EBX: cf81a0b0 ECX: 63383166 EDX: cf81a0b8
> > [15745.009769] ESI: cf81a0b0 EDI: cf81a0d0 EBP: c03b4bcc ESP: cfa37f40
> > [15745.009773] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
> > [15745.009778] Process su (pid: 6277, ti=cfa36000 task=c354c000 task.ti=cfa36000)
> > [15745.009781] Stack: fffffffe c186c30c cf81a080 cf81a0b0 cf81a0d0 c03b4bcc c011fba1 cf81a0b0
> > [15745.009793] c0368fd1 00000013 cf81a080 cf81a080 00000013 00000000 c011fe94 00000013
> > [15745.009804] 00000013 00000001 00000000 c0122e0d 00000013 00000000 09756508 c0124688
> > [15745.009815] Call Trace:
> > [15745.009820] [<c011fba1>] uids_user_create+0x41/0x5a
> > [15745.009833] [<c011fe94>] alloc_uid+0xad/0x121
> > [15745.009840] [<c0122e0d>] set_user+0x1d/0x93
> > [15745.009847] [<c0124688>] sys_setuid+0x47/0xc5
> > [15745.009855] [<c0103d32>] sysenter_past_esp+0x5f/0x85
> > [15745.009868] =======================
> > [15745.009870] Code: d4 13 00 83 7c 24 04 00 75 0f 8b 43 14 83 c0 0c e8 fc fb ff ff 89 44 24 04 8b 43 14 8b 48 04 8d 53 08 89 50 04 89 43 08 89 4b 0c <89> 11 8b 43 14 83 c0 08 c6 00 01 8b 44 24 04 89 43 10 c7 04 24
> > [15745.009928] EIP: [<c01c50a2>] kobject_add+0xae/0x160 SS:ESP 0068:cfa37f40
> >
>
> Don't knowm sorry - we'll need to wait until someone can hit it more
> reliably :(

Ah, I have a fix for that, Kay found it. Do you want an add-on to your
tree, or a whole new version of one of the patches?

And it's pretty easy to hit, just start printing a lot of individual
files with a local printer to cups. My daughter showed me in painful
detail how easy it was... :)

thanks,

greg k-h

2007-11-06 21:14:40

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails

On Tue, Nov 06, 2007 at 01:10:37PM -0800, Andrew Morton wrote:
> > On Tue, 06 Nov 2007 20:40:02 +0530 Kamalesh Babulal <[email protected]> wrote:
> > drivers/s390/char/sclp_cpi_sys.c:242: error: storage size of `system_name_attr' isn't known
> > drivers/s390/char/sclp_cpi_sys.c:264: error: storage size of `sysplex_name_attr' isn't known
> > drivers/s390/char/sclp_cpi_sys.c:287: error: storage size of `system_type_attr' isn't known
> > drivers/s390/char/sclp_cpi_sys.c:317: error: storage size of `system_level_attr' isn't known
> > drivers/s390/char/sclp_cpi_sys.c:333: error: storage size of `set_attr' isn't known
> > make[2]: *** [drivers/s390/char/sclp_cpi_sys.o] Error 1
> > make[1]: *** [drivers/s390/char] Error 2
> > make: *** [drivers/s390] Error 2
> >
> > The patch git-s390.patch is causing this failure.
>
> git-s390 newly adds that file. I suspect that this code works OK for the
> s390 guys (they're using Linux). But Greg's driver tree basically ports
> their driver to Gregnux, in which nothing works any more.
>
> Greg, this is turning into a bit of a trainwreck. Can you please have a
> think about how we can provide a bit of back-compatibility to ease this
> transition rather than just trashing everything?

It's _always_ a trainwreck when I touch anything in the driver core,
look at how many individual patches it took to do a lot of this work
(50+ and still growing). My method is to introduce the new api, convert
everyone over to it, and then remove the old crappy one.

Now for dealing with external trees, I have _no_ visiblity into them for
the most part. I can't build s390 stuff (no cross compiler), so I can't
even test their changes.

But, there really should not be that many places that are touching these
types of things that I am currently changing (ksets and ktypes and
subsystems.)

So, how do I do this? Do I just not let my changes trickle into your
tree, and hold off until I merge them with Linus, hoping that me and Kay
have tested everything good enough? That way, no build ever should
break, but functionality might not be all working as well as it could
be.

Or we live with some breakage as you pull my stuff into your tree.

Either way, I'm glad to help fix the broken stuff, and I'm also glad to
take the responsibility for getting this all right the first time it
goes to Linus.

What do you think is best to do?

thanks,

greg k-h

2007-11-06 21:15:27

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

> On Tue, 6 Nov 2007 13:07:12 -0800 Greg KH <[email protected]> wrote:
> > > [15745.009868] =======================
> > > [15745.009870] Code: d4 13 00 83 7c 24 04 00 75 0f 8b 43 14 83 c0 0c e8 fc fb ff ff 89 44 24 04 8b 43 14 8b 48 04 8d 53 08 89 50 04 89 43 08 89 4b 0c <89> 11 8b 43 14 83 c0 08 c6 00 01 8b 44 24 04 89 43 10 c7 04 24
> > > [15745.009928] EIP: [<c01c50a2>] kobject_add+0xae/0x160 SS:ESP 0068:cfa37f40
> > >
> >
> > Don't knowm sorry - we'll need to wait until someone can hit it more
> > reliably :(
>
> Ah, I have a fix for that, Kay found it. Do you want an add-on to your
> tree, or a whole new version of one of the patches?

Is OK, it looks like I need to resync everyone and undrop various
trees. A fix for perfmon would be nice.

It took five solid hours to get this lot vaguely compiling. 20-30
fix patches needed, several trees dropped, 5-10 patches dropped.

It is an altogether unimpressive performance.

2007-11-06 21:18:12

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

On Tue, Nov 06, 2007 at 11:32:29AM -0800, Badari Pulavarty wrote:
> On Tue, 2007-11-06 at 02:33 -0800, [email protected] wrote:
> > The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz
> >
> > It contains the following patches against 2.6.24-rc1:
>
>
> Getting OOPS on shutdown.

Yes, Corneila also reported this and I can duplicate it here. Am
working on narrowing it down...

thanks,

greg k-h

2007-11-06 21:34:17

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

On Tue, Nov 06, 2007 at 02:15:09PM -0800, Andrew Morton wrote:
> > On Tue, 6 Nov 2007 13:07:12 -0800 Greg KH <[email protected]> wrote:
> > > > [15745.009868] =======================
> > > > [15745.009870] Code: d4 13 00 83 7c 24 04 00 75 0f 8b 43 14 83 c0 0c e8 fc fb ff ff 89 44 24 04 8b 43 14 8b 48 04 8d 53 08 89 50 04 89 43 08 89 4b 0c <89> 11 8b 43 14 83 c0 08 c6 00 01 8b 44 24 04 89 43 10 c7 04 24
> > > > [15745.009928] EIP: [<c01c50a2>] kobject_add+0xae/0x160 SS:ESP 0068:cfa37f40
> > > >
> > >
> > > Don't knowm sorry - we'll need to wait until someone can hit it more
> > > reliably :(
> >
> > Ah, I have a fix for that, Kay found it. Do you want an add-on to your
> > tree, or a whole new version of one of the patches?
>
> Is OK, it looks like I need to resync everyone and undrop various
> trees. A fix for perfmon would be nice.
>
> It took five solid hours to get this lot vaguely compiling. 20-30
> fix patches needed, several trees dropped, 5-10 patches dropped.

Let me regenerate my tree, drop the block-device patch that you hate so
much, and then attack the perfmon code. Should be done in a few hours.

Sound ok?

thanks,

greg k-h

2007-11-06 21:34:52

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails

> On Tue, 6 Nov 2007 13:13:45 -0800 Greg KH <[email protected]> wrote:
> On Tue, Nov 06, 2007 at 01:10:37PM -0800, Andrew Morton wrote:
> > > On Tue, 06 Nov 2007 20:40:02 +0530 Kamalesh Babulal <[email protected]> wrote:
> > > drivers/s390/char/sclp_cpi_sys.c:242: error: storage size of `system_name_attr' isn't known
> > > drivers/s390/char/sclp_cpi_sys.c:264: error: storage size of `sysplex_name_attr' isn't known
> > > drivers/s390/char/sclp_cpi_sys.c:287: error: storage size of `system_type_attr' isn't known
> > > drivers/s390/char/sclp_cpi_sys.c:317: error: storage size of `system_level_attr' isn't known
> > > drivers/s390/char/sclp_cpi_sys.c:333: error: storage size of `set_attr' isn't known
> > > make[2]: *** [drivers/s390/char/sclp_cpi_sys.o] Error 1
> > > make[1]: *** [drivers/s390/char] Error 2
> > > make: *** [drivers/s390] Error 2
> > >
> > > The patch git-s390.patch is causing this failure.
> >
> > git-s390 newly adds that file. I suspect that this code works OK for the
> > s390 guys (they're using Linux). But Greg's driver tree basically ports
> > their driver to Gregnux, in which nothing works any more.
> >
> > Greg, this is turning into a bit of a trainwreck. Can you please have a
> > think about how we can provide a bit of back-compatibility to ease this
> > transition rather than just trashing everything?
>
> It's _always_ a trainwreck when I touch anything in the driver core,
> look at how many individual patches it took to do a lot of this work
> (50+ and still growing). My method is to introduce the new api, convert
> everyone over to it, and then remove the old crappy one.
>
> Now for dealing with external trees, I have _no_ visiblity into them for
> the most part. I can't build s390 stuff (no cross compiler), so I can't
> even test their changes.
>
> But, there really should not be that many places that are touching these
> types of things that I am currently changing (ksets and ktypes and
> subsystems.)
>
> So, how do I do this? Do I just not let my changes trickle into your
> tree, and hold off until I merge them with Linus, hoping that me and Kay
> have tested everything good enough? That way, no build ever should
> break, but functionality might not be all working as well as it could
> be.
>
> Or we live with some breakage as you pull my stuff into your tree.
>
> Either way, I'm glad to help fix the broken stuff, and I'm also glad to
> take the responsibility for getting this all right the first time it
> goes to Linus.
>
> What do you think is best to do?
>

Leave the old interfaces in place, deprecate them, remove them later. If
at all possible.

2007-11-06 21:40:26

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails

On Tue, Nov 06, 2007 at 02:33:44PM -0800, Andrew Morton wrote:
> > On Tue, 6 Nov 2007 13:13:45 -0800 Greg KH <[email protected]> wrote:
> > On Tue, Nov 06, 2007 at 01:10:37PM -0800, Andrew Morton wrote:
> > > > On Tue, 06 Nov 2007 20:40:02 +0530 Kamalesh Babulal <[email protected]> wrote:
> > > > drivers/s390/char/sclp_cpi_sys.c:242: error: storage size of `system_name_attr' isn't known
> > > > drivers/s390/char/sclp_cpi_sys.c:264: error: storage size of `sysplex_name_attr' isn't known
> > > > drivers/s390/char/sclp_cpi_sys.c:287: error: storage size of `system_type_attr' isn't known
> > > > drivers/s390/char/sclp_cpi_sys.c:317: error: storage size of `system_level_attr' isn't known
> > > > drivers/s390/char/sclp_cpi_sys.c:333: error: storage size of `set_attr' isn't known
> > > > make[2]: *** [drivers/s390/char/sclp_cpi_sys.o] Error 1
> > > > make[1]: *** [drivers/s390/char] Error 2
> > > > make: *** [drivers/s390] Error 2
> > > >
> > > > The patch git-s390.patch is causing this failure.
> > >
> > > git-s390 newly adds that file. I suspect that this code works OK for the
> > > s390 guys (they're using Linux). But Greg's driver tree basically ports
> > > their driver to Gregnux, in which nothing works any more.
> > >
> > > Greg, this is turning into a bit of a trainwreck. Can you please have a
> > > think about how we can provide a bit of back-compatibility to ease this
> > > transition rather than just trashing everything?
> >
> > It's _always_ a trainwreck when I touch anything in the driver core,
> > look at how many individual patches it took to do a lot of this work
> > (50+ and still growing). My method is to introduce the new api, convert
> > everyone over to it, and then remove the old crappy one.
> >
> > Now for dealing with external trees, I have _no_ visiblity into them for
> > the most part. I can't build s390 stuff (no cross compiler), so I can't
> > even test their changes.
> >
> > But, there really should not be that many places that are touching these
> > types of things that I am currently changing (ksets and ktypes and
> > subsystems.)
> >
> > So, how do I do this? Do I just not let my changes trickle into your
> > tree, and hold off until I merge them with Linus, hoping that me and Kay
> > have tested everything good enough? That way, no build ever should
> > break, but functionality might not be all working as well as it could
> > be.
> >
> > Or we live with some breakage as you pull my stuff into your tree.
> >
> > Either way, I'm glad to help fix the broken stuff, and I'm also glad to
> > take the responsibility for getting this all right the first time it
> > goes to Linus.
> >
> > What do you think is best to do?
> >
>
> Leave the old interfaces in place, deprecate them, remove them later. If
> at all possible.

It's usually not a matter of them being "interfaces" but structure
changes. The only way to slim these things down into something that
works properly (ksets being dynamic instead of static), and changing
the majority of these ksets into kobjects as ksets is not the correct
usage, doesn't lend themselves to being able to keep the old stuff
around anymore.

Almost all of these build problems are a simple one-line change in the
offending code, so it's not a tough change for me to do on stuff in your
tree.

thanks,

greg k-h

2007-11-06 21:41:26

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 - ACPI functions broken

Hi Andrew,

The kernel build fails, on powerpc while compiling the kernel with allyesconfig option

drivers/hwmon/w83627hf.c:1631: error: implicit declaration of function ?acpi_check_resource_conflict?
make[2]: *** [drivers/hwmon/w83627hf.o] Error 1
make[1]: *** [drivers/hwmon] Error 2
make: *** [drivers] Error 2
CC fs/xfs/xfs_error.o
drivers/hwmon/w83627hf.c:1631: error: implicit declaration of function ?acpi_check_resource_conflict?
make[2]: *** [drivers/hwmon/w83627hf.o] Error 1
make[1]: *** [drivers/hwmon] Error 2
make: *** [drivers] Error 2
drivers/i2c/busses/i2c-ali1535.c:163: error: implicit declaration of function ?acpi_check_region?
make[3]: *** [drivers/i2c/busses/i2c-ali1535.o] Error 1
make[2]: *** [drivers/i2c/busses] Error 2
make[1]: *** [drivers/i2c] Error 2
drivers/hwmon/dme1737.c:2231: error: implicit declaration of function ?acpi_check_resource_conflict?
make[2]: *** [drivers/hwmon/dme1737.o] Error 1
make[1]: *** [drivers/hwmon] Error 2
make: *** [drivers] Error 2

The patches check-for-acpi-resource-conflicts-in-hwmon-drivers and
check-for-acpi-resource-conflicts-in-i2c-bus-drivers.patch, causes this build failure.
The declaration of the functions are under ifdef CONFIG_ACPI.

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Attachments:

config (76.12 kB)

2007-11-06 21:41:47

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

> On Tue, 6 Nov 2007 13:33:26 -0800 Greg KH <[email protected]> wrote:
> On Tue, Nov 06, 2007 at 02:15:09PM -0800, Andrew Morton wrote:
> > > On Tue, 6 Nov 2007 13:07:12 -0800 Greg KH <[email protected]> wrote:
> > > > > [15745.009868] =======================
> > > > > [15745.009870] Code: d4 13 00 83 7c 24 04 00 75 0f 8b 43 14 83 c0 0c e8 fc fb ff ff 89 44 24 04 8b 43 14 8b 48 04 8d 53 08 89 50 04 89 43 08 89 4b 0c <89> 11 8b 43 14 83 c0 08 c6 00 01 8b 44 24 04 89 43 10 c7 04 24
> > > > > [15745.009928] EIP: [<c01c50a2>] kobject_add+0xae/0x160 SS:ESP 0068:cfa37f40
> > > > >
> > > >
> > > > Don't knowm sorry - we'll need to wait until someone can hit it more
> > > > reliably :(
> > >
> > > Ah, I have a fix for that, Kay found it. Do you want an add-on to your
> > > tree, or a whole new version of one of the patches?
> >
> > Is OK, it looks like I need to resync everyone and undrop various
> > trees. A fix for perfmon would be nice.
> >
> > It took five solid hours to get this lot vaguely compiling. 20-30
> > fix patches needed, several trees dropped, 5-10 patches dropped.
>
> Let me regenerate my tree, drop the block-device patch that you hate so
> much,

I don't "hate" it. It's just that it makes my ydl4.1 G5 no longer boot.
This is not an unreasonable objection...

> and then attack the perfmon code.

Would be good, thanks - I'll send you a diff.

> Should be done in a few hours.

I won't be pulling the trees again until Friday.

> Sound ok?
>

Thanks.

2007-11-06 21:51:53

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

On Tue, Nov 06, 2007 at 02:41:04PM -0800, Andrew Morton wrote:
> > On Tue, 6 Nov 2007 13:33:26 -0800 Greg KH <[email protected]> wrote:
> > On Tue, Nov 06, 2007 at 02:15:09PM -0800, Andrew Morton wrote:
> > > > On Tue, 6 Nov 2007 13:07:12 -0800 Greg KH <[email protected]> wrote:
> > > > > > [15745.009868] =======================
> > > > > > [15745.009870] Code: d4 13 00 83 7c 24 04 00 75 0f 8b 43 14 83 c0 0c e8 fc fb ff ff 89 44 24 04 8b 43 14 8b 48 04 8d 53 08 89 50 04 89 43 08 89 4b 0c <89> 11 8b 43 14 83 c0 08 c6 00 01 8b 44 24 04 89 43 10 c7 04 24
> > > > > > [15745.009928] EIP: [<c01c50a2>] kobject_add+0xae/0x160 SS:ESP 0068:cfa37f40
> > > > > >
> > > > >
> > > > > Don't knowm sorry - we'll need to wait until someone can hit it more
> > > > > reliably :(
> > > >
> > > > Ah, I have a fix for that, Kay found it. Do you want an add-on to your
> > > > tree, or a whole new version of one of the patches?
> > >
> > > Is OK, it looks like I need to resync everyone and undrop various
> > > trees. A fix for perfmon would be nice.
> > >
> > > It took five solid hours to get this lot vaguely compiling. 20-30
> > > fix patches needed, several trees dropped, 5-10 patches dropped.
> >
> > Let me regenerate my tree, drop the block-device patch that you hate so
> > much,
>
> I don't "hate" it. It's just that it makes my ydl4.1 G5 no longer boot.
> This is not an unreasonable objection...

Yes, fair enough, sorry :)

> > and then attack the perfmon code.
>
> Would be good, thanks - I'll send you a diff.

Got it, thanks.

> > Should be done in a few hours.
>
> I won't be pulling the trees again until Friday.

Ok, thanks for the warning.

greg k-h

2007-11-07 12:28:18

by Jean Delvare

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 - ACPI functions broken

Hi Kamalesh,

Le mardi 06 novembre 2007, Kamalesh Babulal a écrit :
> Hi Andrew,
>
> The kernel build fails, on powerpc while compiling the kernel with allyesconfig option
>
> drivers/hwmon/w83627hf.c:1631: error: implicit declaration of function ‘acpi_check_resource_conflict’
> make[2]: *** [drivers/hwmon/w83627hf.o] Error 1
> make[1]: *** [drivers/hwmon] Error 2
> make: *** [drivers] Error 2
> CC fs/xfs/xfs_error.o
> drivers/hwmon/w83627hf.c:1631: error: implicit declaration of function ‘acpi_check_resource_conflict’
> make[2]: *** [drivers/hwmon/w83627hf.o] Error 1
> make[1]: *** [drivers/hwmon] Error 2
> make: *** [drivers] Error 2
> drivers/i2c/busses/i2c-ali1535.c:163: error: implicit declaration of function ‘acpi_check_region’
> make[3]: *** [drivers/i2c/busses/i2c-ali1535.o] Error 1
> make[2]: *** [drivers/i2c/busses] Error 2
> make[1]: *** [drivers/i2c] Error 2
> drivers/hwmon/dme1737.c:2231: error: implicit declaration of function ‘acpi_check_resource_conflict’
> make[2]: *** [drivers/hwmon/dme1737.o] Error 1
> make[1]: *** [drivers/hwmon] Error 2
> make: *** [drivers] Error 2

Odd. Thanks for reporting.

> The patches check-for-acpi-resource-conflicts-in-hwmon-drivers and
> check-for-acpi-resource-conflicts-in-i2c-bus-drivers.patch, causes this build failure.
> The declaration of the functions are under ifdef CONFIG_ACPI.

There's an #else after that, and the functions are defined as inlines
doing nothing in the non-ACPI case. The code looks OK to me, but I can
reproduce the problem on x86_64 with CONFIG_ACPI=n.

Aha, I see it now, there are nested #ifdef CONFIG_ACPI in acpi.h,
so the inner one is a no-op (and its #else counterpart is never
evaluated.) That's pretty confusing, I'll send a patch fixing this.

In the meantime, here's a quick fix so that you can go on testing
the mm snapshot. Apply this at the top of the series:

Fix the <linux/acpi.h> breakage for CONFIG_ACPI=n.

Signed-off-by: Jean Delvare <[email protected]>
---
include/linux/acpi.h | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)

--- linux-2.6.24-rc1.orig/include/linux/acpi.h 2007-11-07 12:45:47.000000000 +0100
+++ linux-2.6.24-rc1/include/linux/acpi.h 2007-11-07 13:23:06.000000000 +0100
@@ -26,6 +26,7 @@
#define _LINUX_ACPI_H

+#include <linux/ioport.h>
#ifdef CONFIG_ACPI

#ifndef _LINUX
@@ -134,17 +135,6 @@ int acpi_check_mem_region(resource_size_

#define acpi_mp_config 0

-static inline int acpi_check_resource_conflict(struct resource *res)
-{ return 0; }
-
-static inline int acpi_check_region(resource_size_t start, resource_size_t n,
- const char *name)
-{ return 0; }
-
-static inline int acpi_check_mem_region(resource_size_t start,
- resource_size_t n, const char *name)
-{ return 0; }
-
#endif /* !CONFIG_ACPI */

int acpi_register_gsi (u32 gsi, int triggering, int polarity);
@@ -239,5 +229,16 @@ static inline int acpi_boot_table_init(v
return 0;
}

+static inline int acpi_check_resource_conflict(struct resource *res)
+{ return 0; }
+
+static inline int acpi_check_region(resource_size_t start, resource_size_t n,
+ const char *name)
+{ return 0; }
+
+static inline int acpi_check_mem_region(resource_size_t start,
+ resource_size_t n, const char *name)
+{ return 0; }
+
#endif /* CONFIG_ACPI */
#endif /*_LINUX_ACPI_H*/

--
Jean Delvare
Suse L3

2007-11-07 17:14:13

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 - ACPI functions broken

Jean Delvare wrote:
> Hi Kamalesh,
>
> Le mardi 06 novembre 2007, Kamalesh Babulal a écrit :
>> Hi Andrew,
>>
>> The kernel build fails, on powerpc while compiling the kernel with allyesconfig option
>>
>> drivers/hwmon/w83627hf.c:1631: error: implicit declaration of function ‘acpi_check_resource_conflict’
>> make[2]: *** [drivers/hwmon/w83627hf.o] Error 1
>> make[1]: *** [drivers/hwmon] Error 2
>> make: *** [drivers] Error 2
>> CC fs/xfs/xfs_error.o
>> drivers/hwmon/w83627hf.c:1631: error: implicit declaration of function ‘acpi_check_resource_conflict’
>> make[2]: *** [drivers/hwmon/w83627hf.o] Error 1
>> make[1]: *** [drivers/hwmon] Error 2
>> make: *** [drivers] Error 2
>> drivers/i2c/busses/i2c-ali1535.c:163: error: implicit declaration of function ‘acpi_check_region’
>> make[3]: *** [drivers/i2c/busses/i2c-ali1535.o] Error 1
>> make[2]: *** [drivers/i2c/busses] Error 2
>> make[1]: *** [drivers/i2c] Error 2
>> drivers/hwmon/dme1737.c:2231: error: implicit declaration of function ‘acpi_check_resource_conflict’
>> make[2]: *** [drivers/hwmon/dme1737.o] Error 1
>> make[1]: *** [drivers/hwmon] Error 2
>> make: *** [drivers] Error 2
>
> Odd. Thanks for reporting.
>
>> The patches check-for-acpi-resource-conflicts-in-hwmon-drivers and
>> check-for-acpi-resource-conflicts-in-i2c-bus-drivers.patch, causes this build failure.
>> The declaration of the functions are under ifdef CONFIG_ACPI.
>
> There's an #else after that, and the functions are defined as inlines
> doing nothing in the non-ACPI case. The code looks OK to me, but I can
> reproduce the problem on x86_64 with CONFIG_ACPI=n.
>
> Aha, I see it now, there are nested #ifdef CONFIG_ACPI in acpi.h,
> so the inner one is a no-op (and its #else counterpart is never
> evaluated.) That's pretty confusing, I'll send a patch fixing this.
>
> In the meantime, here's a quick fix so that you can go on testing
> the mm snapshot. Apply this at the top of the series:
>
> Fix the <linux/acpi.h> breakage for CONFIG_ACPI=n.
>
> Signed-off-by: Jean Delvare <[email protected]>
> ---
> include/linux/acpi.h | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> --- linux-2.6.24-rc1.orig/include/linux/acpi.h 2007-11-07 12:45:47.000000000 +0100
> +++ linux-2.6.24-rc1/include/linux/acpi.h 2007-11-07 13:23:06.000000000 +0100
> @@ -26,6 +26,7 @@
> #define _LINUX_ACPI_H
>
>
> +#include <linux/ioport.h>
> #ifdef CONFIG_ACPI
>
> #ifndef _LINUX
> @@ -134,17 +135,6 @@ int acpi_check_mem_region(resource_size_
>
> #define acpi_mp_config 0
>
> -static inline int acpi_check_resource_conflict(struct resource *res)
> -{ return 0; }
> -
> -static inline int acpi_check_region(resource_size_t start, resource_size_t n,
> - const char *name)
> -{ return 0; }
> -
> -static inline int acpi_check_mem_region(resource_size_t start,
> - resource_size_t n, const char *name)
> -{ return 0; }
> -
> #endif /* !CONFIG_ACPI */
>
> int acpi_register_gsi (u32 gsi, int triggering, int polarity);
> @@ -239,5 +229,16 @@ static inline int acpi_boot_table_init(v
> return 0;
> }
>
> +static inline int acpi_check_resource_conflict(struct resource *res)
> +{ return 0; }
> +
> +static inline int acpi_check_region(resource_size_t start, resource_size_t n,
> + const char *name)
> +{ return 0; }
> +
> +static inline int acpi_check_mem_region(resource_size_t start,
> + resource_size_t n, const char *name)
> +{ return 0; }
> +
> #endif /* CONFIG_ACPI */
> #endif /*_LINUX_ACPI_H*/
>
>
Hi Jean,

Thanks for the quick fix.

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

2007-11-07 18:38:52

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 build failure init/do_mount

Hi Andrew,

The kernel build fails with randconfig, with folllowing error

init/do_mounts.c: In function ?name_to_dev_t?:
init/do_mounts.c:110: error: implicit declaration of function ?blk_lookup_devt?
make[1]: *** [init/do_mounts.o] Error 1
make: *** [init] Error 2

This is caused by gregkh-driver-block-device.patch, where the function
blk_lookup_devt is declared within #ifdef CONFIG_BLOCK and randconfig has
not set the CONFIG_BLOCK it.

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

2007-11-07 19:57:18

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 build failure !CONFIG_PCI

Hi Andrew,

The kernel build fails with randconfig, with following error

CC drivers/video/chipsfb.o
drivers/video/chipsfb.c: In function ?chipsfb_pci_init?:
drivers/video/chipsfb.c:378: error: implicit declaration of function ?pci_request_region?
drivers/video/chipsfb.c:435: error: implicit declaration of function ?pci_release_region?
make[2]: *** [drivers/video/chipsfb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

!CONFIG_PCI causes the build to fail.

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Attachments:

config (23.70 kB)

2007-11-07 20:22:26

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 powerpc - axon_msi build faliure

Hi Andrew,

The kernel build fails with randconfig, with folllowing error

CC arch/powerpc/platforms/cell/axon_msi.o
arch/powerpc/platforms/cell/axon_msi.c:69: error: expected specifier-qualifier-list before ?dcr_host_t?
arch/powerpc/platforms/cell/axon_msi.c: In function ?msic_dcr_write?:
arch/powerpc/platforms/cell/axon_msi.c:80: error: implicit declaration of function ?dcr_write?
arch/powerpc/platforms/cell/axon_msi.c:80: error: ?struct axon_msic? has no member named ?dcr_host?
arch/powerpc/platforms/cell/axon_msi.c: In function ?axon_msi_cascade?:
arch/powerpc/platforms/cell/axon_msi.c:89: error: implicit declaration of function ?dcr_read?
arch/powerpc/platforms/cell/axon_msi.c:89: error: ?struct axon_msic? has no member named ?dcr_host?
arch/powerpc/platforms/cell/axon_msi.c:95: error: ?struct axon_msic? has no member named ?read_offset?
arch/powerpc/platforms/cell/axon_msi.c:96: error: ?struct axon_msic? has no member named ?read_offset?
arch/powerpc/platforms/cell/axon_msi.c:101: error: ?struct axon_msic? has no member named ?read_offset?
arch/powerpc/platforms/cell/axon_msi.c:103: error: ?struct axon_msic? has no member named ?read_offset?
arch/powerpc/platforms/cell/axon_msi.c:104: error: ?struct axon_msic? has no member named ?read_offset?
arch/powerpc/platforms/cell/axon_msi.c: In function ?axon_msi_notify_reboot?:
arch/powerpc/platforms/cell/axon_msi.c:301: error: ?struct axon_msic? has no member named ?list?
arch/powerpc/platforms/cell/axon_msi.c:301: warning: type defaults to ?int? in declaration of ?__mptr?
arch/powerpc/platforms/cell/axon_msi.c:301: warning: initialization from incompatible pointer type
arch/powerpc/platforms/cell/axon_msi.c:301: error: ?struct axon_msic? has no member named ?list?
arch/powerpc/platforms/cell/axon_msi.c:301: error: ?struct axon_msic? has no member named ?list?
arch/powerpc/platforms/cell/axon_msi.c:301: error: ?struct axon_msic? has no member named ?list?
arch/powerpc/platforms/cell/axon_msi.c:301: error: ?struct axon_msic? has no member named ?list?
arch/powerpc/platforms/cell/axon_msi.c:301: warning: type defaults to ?int? in declaration of ?__mptr?
arch/powerpc/platforms/cell/axon_msi.c:301: error: ?struct axon_msic? has no member named ?list?
arch/powerpc/platforms/cell/axon_msi.c:301: error: ?struct axon_msic? has no member named ?list?
arch/powerpc/platforms/cell/axon_msi.c:304: error: ?struct axon_msic? has no member named ?dcr_host?
arch/powerpc/platforms/cell/axon_msi.c: In function ?axon_msi_setup_one?:
arch/powerpc/platforms/cell/axon_msi.c:332: error: implicit declaration of function ?dcr_resource_start?
arch/powerpc/platforms/cell/axon_msi.c:333: error: implicit declaration of function ?dcr_resource_len?
arch/powerpc/platforms/cell/axon_msi.c:342: error: ?struct axon_msic? has no member named ?dcr_host?
arch/powerpc/platforms/cell/axon_msi.c:342: error: implicit declaration of function ?dcr_map?
arch/powerpc/platforms/cell/axon_msi.c:343: error: implicit declaration of function ?DCR_MAP_OK?
arch/powerpc/platforms/cell/axon_msi.c:343: error: ?struct axon_msic? has no member named ?dcr_host?
arch/powerpc/platforms/cell/axon_msi.c:388: error: ?struct axon_msic? has no member named ?list?
make[2]: *** [arch/powerpc/platforms/cell/axon_msi.o] Error 1
make[1]: *** [arch/powerpc/platforms/cell] Error 2
make: *** [arch/powerpc/platforms] Error 2

This is because of the #ifdef CONFIG_PPC_DCR in the asm-powerpc/dcr.h.

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

2007-11-07 20:30:25

by Benjamin Herrenschmidt

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 powerpc - axon_msi build faliure

On Thu, 2007-11-08 at 01:22 +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel build fails with randconfig, with folllowing error

Why cares about randconfig crap ? I don't much. Especially not if you
don't provide the actual config that triggered the error.

> CC arch/powerpc/platforms/cell/axon_msi.o
> arch/powerpc/platforms/cell/axon_msi.c:69: error: expected specifier-qualifier-list before ‘dcr_host_t’
> arch/powerpc/platforms/cell/axon_msi.c: In function ‘msic_dcr_write’:
> arch/powerpc/platforms/cell/axon_msi.c:80: error: implicit declaration of function ‘dcr_write’
> arch/powerpc/platforms/cell/axon_msi.c:80: error: ‘struct axon_msic’ has no member named ‘dcr_host’
> arch/powerpc/platforms/cell/axon_msi.c: In function ‘axon_msi_cascade’:
> arch/powerpc/platforms/cell/axon_msi.c:89: error: implicit declaration of function ‘dcr_read’
> arch/powerpc/platforms/cell/axon_msi.c:89: error: ‘struct axon_msic’ has no member named ‘dcr_host’
> arch/powerpc/platforms/cell/axon_msi.c:95: error: ‘struct axon_msic’ has no member named ‘read_offset’
> arch/powerpc/platforms/cell/axon_msi.c:96: error: ‘struct axon_msic’ has no member named ‘read_offset’
> arch/powerpc/platforms/cell/axon_msi.c:101: error: ‘struct axon_msic’ has no member named ‘read_offset’
> arch/powerpc/platforms/cell/axon_msi.c:103: error: ‘struct axon_msic’ has no member named ‘read_offset’
> arch/powerpc/platforms/cell/axon_msi.c:104: error: ‘struct axon_msic’ has no member named ‘read_offset’
> arch/powerpc/platforms/cell/axon_msi.c: In function ‘axon_msi_notify_reboot’:
> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
> arch/powerpc/platforms/cell/axon_msi.c:301: warning: type defaults to ‘int’ in declaration of ‘__mptr’
> arch/powerpc/platforms/cell/axon_msi.c:301: warning: initialization from incompatible pointer type
> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
> arch/powerpc/platforms/cell/axon_msi.c:301: warning: type defaults to ‘int’ in declaration of ‘__mptr’
> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
> arch/powerpc/platforms/cell/axon_msi.c:304: error: ‘struct axon_msic’ has no member named ‘dcr_host’
> arch/powerpc/platforms/cell/axon_msi.c: In function ‘axon_msi_setup_one’:
> arch/powerpc/platforms/cell/axon_msi.c:332: error: implicit declaration of function ‘dcr_resource_start’
> arch/powerpc/platforms/cell/axon_msi.c:333: error: implicit declaration of function ‘dcr_resource_len’
> arch/powerpc/platforms/cell/axon_msi.c:342: error: ‘struct axon_msic’ has no member named ‘dcr_host’
> arch/powerpc/platforms/cell/axon_msi.c:342: error: implicit declaration of function ‘dcr_map’
> arch/powerpc/platforms/cell/axon_msi.c:343: error: implicit declaration of function ‘DCR_MAP_OK’
> arch/powerpc/platforms/cell/axon_msi.c:343: error: ‘struct axon_msic’ has no member named ‘dcr_host’
> arch/powerpc/platforms/cell/axon_msi.c:388: error: ‘struct axon_msic’ has no member named ‘list’
> make[2]: *** [arch/powerpc/platforms/cell/axon_msi.o] Error 1
> make[1]: *** [arch/powerpc/platforms/cell] Error 2
> make: *** [arch/powerpc/platforms] Error 2
>
> This is because of the #ifdef CONFIG_PPC_DCR in the asm-powerpc/dcr.h.
>

2007-11-07 20:35:53

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 powerpc - axon_msi build faliure

Benjamin Herrenschmidt wrote:
> On Thu, 2007-11-08 at 01:22 +0530, Kamalesh Babulal wrote:
>> Hi Andrew,
>>
>> The kernel build fails with randconfig, with folllowing error
>
> Why cares about randconfig crap ? I don't much. Especially not if you
> don't provide the actual config that triggered the error.

Sorry, for not attaching, the file. Have attached the .config file.
>
>> CC arch/powerpc/platforms/cell/axon_msi.o
>> arch/powerpc/platforms/cell/axon_msi.c:69: error: expected specifier-qualifier-list before ‘dcr_host_t’
>> arch/powerpc/platforms/cell/axon_msi.c: In function ‘msic_dcr_write’:
>> arch/powerpc/platforms/cell/axon_msi.c:80: error: implicit declaration of function ‘dcr_write’
>> arch/powerpc/platforms/cell/axon_msi.c:80: error: ‘struct axon_msic’ has no member named ‘dcr_host’
>> arch/powerpc/platforms/cell/axon_msi.c: In function ‘axon_msi_cascade’:
>> arch/powerpc/platforms/cell/axon_msi.c:89: error: implicit declaration of function ‘dcr_read’
>> arch/powerpc/platforms/cell/axon_msi.c:89: error: ‘struct axon_msic’ has no member named ‘dcr_host’
>> arch/powerpc/platforms/cell/axon_msi.c:95: error: ‘struct axon_msic’ has no member named ‘read_offset’
>> arch/powerpc/platforms/cell/axon_msi.c:96: error: ‘struct axon_msic’ has no member named ‘read_offset’
>> arch/powerpc/platforms/cell/axon_msi.c:101: error: ‘struct axon_msic’ has no member named ‘read_offset’
>> arch/powerpc/platforms/cell/axon_msi.c:103: error: ‘struct axon_msic’ has no member named ‘read_offset’
>> arch/powerpc/platforms/cell/axon_msi.c:104: error: ‘struct axon_msic’ has no member named ‘read_offset’
>> arch/powerpc/platforms/cell/axon_msi.c: In function ‘axon_msi_notify_reboot’:
>> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
>> arch/powerpc/platforms/cell/axon_msi.c:301: warning: type defaults to ‘int’ in declaration of ‘__mptr’
>> arch/powerpc/platforms/cell/axon_msi.c:301: warning: initialization from incompatible pointer type
>> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
>> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
>> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
>> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
>> arch/powerpc/platforms/cell/axon_msi.c:301: warning: type defaults to ‘int’ in declaration of ‘__mptr’
>> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
>> arch/powerpc/platforms/cell/axon_msi.c:301: error: ‘struct axon_msic’ has no member named ‘list’
>> arch/powerpc/platforms/cell/axon_msi.c:304: error: ‘struct axon_msic’ has no member named ‘dcr_host’
>> arch/powerpc/platforms/cell/axon_msi.c: In function ‘axon_msi_setup_one’:
>> arch/powerpc/platforms/cell/axon_msi.c:332: error: implicit declaration of function ‘dcr_resource_start’
>> arch/powerpc/platforms/cell/axon_msi.c:333: error: implicit declaration of function ‘dcr_resource_len’
>> arch/powerpc/platforms/cell/axon_msi.c:342: error: ‘struct axon_msic’ has no member named ‘dcr_host’
>> arch/powerpc/platforms/cell/axon_msi.c:342: error: implicit declaration of function ‘dcr_map’
>> arch/powerpc/platforms/cell/axon_msi.c:343: error: implicit declaration of function ‘DCR_MAP_OK’
>> arch/powerpc/platforms/cell/axon_msi.c:343: error: ‘struct axon_msic’ has no member named ‘dcr_host’
>> arch/powerpc/platforms/cell/axon_msi.c:388: error: ‘struct axon_msic’ has no member named ‘list’
>> make[2]: *** [arch/powerpc/platforms/cell/axon_msi.o] Error 1
>> make[1]: *** [arch/powerpc/platforms/cell] Error 2
>> make: *** [arch/powerpc/platforms] Error 2
>>
>> This is because of the #ifdef CONFIG_PPC_DCR in the asm-powerpc/dcr.h.
>>
>

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Attachments:

config (28.16 kB)

2007-11-07 20:38:17

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 build failure init/do_mount

On Thu, Nov 08, 2007 at 12:07:06AM +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel build fails with randconfig, with folllowing error
>
> init/do_mounts.c: In function ‘name_to_dev_t’:
> init/do_mounts.c:110: error: implicit declaration of function ‘blk_lookup_devt’
> make[1]: *** [init/do_mounts.o] Error 1
> make: *** [init] Error 2
>
> This is caused by gregkh-driver-block-device.patch, where the function
> blk_lookup_devt is declared within #ifdef CONFIG_BLOCK and randconfig has
> not set the CONFIG_BLOCK it.

That patch has been pulled for the next -mm releases.

thanks,

greg k-h

2007-11-07 20:57:56

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 build failure - !CONFIG_PPC_ISERIES

Hi Andrew,

The kernel build fails with randconfig, with following error

CC arch/powerpc/platforms/celleb/setup.o
arch/powerpc/platforms/celleb/setup.c:151: error: ?generic_calibrate_decr? undeclared here (not in a function)
make[2]: *** [arch/powerpc/platforms/celleb/setup.o] Error 1
make[1]: *** [arch/powerpc/platforms/celleb] Error 2
make: *** [arch/powerpc/platforms] Error 2

This is caused by the include file asm-powerpc/time.h, where the function
goes missing when the CONFIG_PPC_ISERIES option is disabled.
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Attachments:

config (28.16 kB)

2007-11-07 21:12:33

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 make header check fails

Hi Andrew,

The build fails with error

CHECK include/asm-generic/siginfo.h
CHECK include/asm-generic/resource.h
CHECK include/asm-generic/statfs.h
CHECK include/asm-generic/signal.h
CHECK include/asm-generic/poll.h
CHECK include/asm-generic/mman.h
CHECK include/asm-generic/ioctl.h
CHECK include/asm-generic/fcntl.h
CHECK include/asm-generic/errno.h
CHECK include/asm-generic/errno-base.h
CHECK include/asm/cputable.h
CHECK include/asm/byteorder.h
CHECK include/asm/bootx.h
CHECK include/asm/auxvec.h
CHECK include/asm/asm-compat.h
CHECK include/asm/a.out.h
CHECK include/asm/ucontext.h
CHECK include/asm/ps3fb.h
CHECK include/asm/linkage.h
CHECK include/asm/elf.h
/home/test/kernels/linux-2.6.24-rc1/patches/linux-2.6.24-rc1/usr/include/asm/elf.h requires asm/page.h, which does not exist in exported headers
make[3]: *** [/home/test/kernels/linux-2.6.24-rc1/patches/linux-2.6.24-rc1/usr/include/asm/.check.elf.h] Error 1
make[2]: *** [asm-powerpc] Error 2
make[1]: *** [headers_check] Error 2
make: *** [vmlinux] Error 2

The patch unexport-asm-pageh.patch might be causing the failure.
This one was discussed on http://lkml.org/lkml/2007/1/4/336
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

2007-11-07 21:17:52

by Randy Dunlap

[permalink] [raw]

Subject: [PATCH] chipsfb: uses/depends on PCI

From: Randy Dunlap <[email protected]>

chipsfb uses PCI interfaces and should depend on PCI.

CC drivers/video/chipsfb.o
drivers/video/chipsfb.c: In function 'chipsfb_pci_init':
drivers/video/chipsfb.c:378: error: implicit declaration of function 'pci_request_region'
drivers/video/chipsfb.c:435: error: implicit declaration of function 'pci_release_region'
make[2]: *** [drivers/video/chipsfb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

!CONFIG_PCI causes the build to fail.

Signed-off-by: Randy Dunlap <[email protected]>
---
drivers/video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2624-rc1-mmbo.orig/drivers/video/Kconfig
+++ linux-2624-rc1-mmbo/drivers/video/Kconfig
@@ -503,7 +503,7 @@ config FB_VALKYRIE

config FB_CT65550
bool "Chips 65550 display support"
- depends on (FB = y) && PPC32
+ depends on (FB = y) && PPC32 && PCI
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT

2007-11-07 21:56:59

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 make header check fails

> On Thu, 08 Nov 2007 02:12:40 +0530 Kamalesh Babulal <[email protected]> wrote:
> Hi Andrew,
>
> The build fails with error
>
> CHECK include/asm-generic/siginfo.h
> CHECK include/asm-generic/resource.h
> CHECK include/asm-generic/statfs.h
> CHECK include/asm-generic/signal.h
> CHECK include/asm-generic/poll.h
> CHECK include/asm-generic/mman.h
> CHECK include/asm-generic/ioctl.h
> CHECK include/asm-generic/fcntl.h
> CHECK include/asm-generic/errno.h
> CHECK include/asm-generic/errno-base.h
> CHECK include/asm/cputable.h
> CHECK include/asm/byteorder.h
> CHECK include/asm/bootx.h
> CHECK include/asm/auxvec.h
> CHECK include/asm/asm-compat.h
> CHECK include/asm/a.out.h
> CHECK include/asm/ucontext.h
> CHECK include/asm/ps3fb.h
> CHECK include/asm/linkage.h
> CHECK include/asm/elf.h
> /home/test/kernels/linux-2.6.24-rc1/patches/linux-2.6.24-rc1/usr/include/asm/elf.h requires asm/page.h, which does not exist in exported headers
> make[3]: *** [/home/test/kernels/linux-2.6.24-rc1/patches/linux-2.6.24-rc1/usr/include/asm/.check.elf.h] Error 1
> make[2]: *** [asm-powerpc] Error 2
> make[1]: *** [headers_check] Error 2
> make: *** [vmlinux] Error 2
>

I am going to guess that you're building for powerpc here.

It looks like ia64 broke too. I'll drop the patch, thanks.

2007-11-08 02:27:50

by Tony Breeds

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32 build failure - !CONFIG_PPC_ISERIES

On Thu, Nov 08, 2007 at 02:27:07AM +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel build fails with randconfig, with following error
>
> CC arch/powerpc/platforms/celleb/setup.o
> arch/powerpc/platforms/celleb/setup.c:151: error: ‘generic_calibrate_decr’ undeclared here (not in a function)
> make[2]: *** [arch/powerpc/platforms/celleb/setup.o] Error 1
> make[1]: *** [arch/powerpc/platforms/celleb] Error 2
> make: *** [arch/powerpc/platforms] Error 2

I think you need this patch:
http://patchwork.ozlabs.org/linuxppc/patch?q=Tony%20Breeds&id=14462

Yours Tony

linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!

2007-11-12 20:17:46

by Serge E. Hallyn

[permalink] [raw]

Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

Quoting Greg KH ([email protected]):
> On Tue, Nov 06, 2007 at 01:40:52PM -0800, Andrew Morton wrote:
> > > On Tue, 06 Nov 2007 21:14:58 +0100 Gabriel C <[email protected]> wrote:
> > > After some hours uptime I got the following Oops :
> > >
> > > [15745.009673] BUG: unable to handle kernel paging request at virtual address 63383166
> >
> > An all-ascii address: "c81f".
> >
> > > [15745.009683] printing eip: c01c50a2 *pde = 00000000
> > > [15745.009692] Oops: 0002 [#1] SMP
> > > [15745.009699] last sysfs file: /sys/devices/pci0000:00/0000:00:1e.0/0000:04:0b.0/irq
> > > [15745.009705] Modules linked in: fuse pc87360 hwmon_vid eeprom adm1021 ext4dev jbd2 crc16 loop lp intel_agp sr_mod agpgart 3c59x parport_pc iTCO_wdt mii parport iTCO_vendor_support cdrom i82860_edac watchdog_core edac_core dcdbas pcspkr i2c_i801 watchdog_dev shpchp evdev pci_hotplug
> > > [15745.009742]
> > > [15745.009746] Pid: 6277, comm: su Not tainted (2.6.24-rc1-mm1 #2)
> > > [15745.009751] EIP: 0060:[<c01c50a2>] EFLAGS: 00210206 CPU: 1
> > > [15745.009761] EIP is at kobject_add+0xae/0x160
> > > [15745.009765] EAX: c186c300 EBX: cf81a0b0 ECX: 63383166 EDX: cf81a0b8
> > > [15745.009769] ESI: cf81a0b0 EDI: cf81a0d0 EBP: c03b4bcc ESP: cfa37f40
> > > [15745.009773] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
> > > [15745.009778] Process su (pid: 6277, ti=cfa36000 task=c354c000 task.ti=cfa36000)
> > > [15745.009781] Stack: fffffffe c186c30c cf81a080 cf81a0b0 cf81a0d0 c03b4bcc c011fba1 cf81a0b0
> > > [15745.009793] c0368fd1 00000013 cf81a080 cf81a080 00000013 00000000 c011fe94 00000013
> > > [15745.009804] 00000013 00000001 00000000 c0122e0d 00000013 00000000 09756508 c0124688
> > > [15745.009815] Call Trace:
> > > [15745.009820] [<c011fba1>] uids_user_create+0x41/0x5a
> > > [15745.009833] [<c011fe94>] alloc_uid+0xad/0x121
> > > [15745.009840] [<c0122e0d>] set_user+0x1d/0x93
> > > [15745.009847] [<c0124688>] sys_setuid+0x47/0xc5
> > > [15745.009855] [<c0103d32>] sysenter_past_esp+0x5f/0x85
> > > [15745.009868] =======================
> > > [15745.009870] Code: d4 13 00 83 7c 24 04 00 75 0f 8b 43 14 83 c0 0c e8 fc fb ff ff 89 44 24 04 8b 43 14 8b 48 04 8d 53 08 89 50 04 89 43 08 89 4b 0c <89> 11 8b 43 14 83 c0 08 c6 00 01 8b 44 24 04 89 43 10 c7 04 24
> > > [15745.009928] EIP: [<c01c50a2>] kobject_add+0xae/0x160 SS:ESP 0068:cfa37f40
> > >
> >
> > Don't knowm sorry - we'll need to wait until someone can hit it more
> > reliably :(
>
> Ah, I have a fix for that, Kay found it. Do you want an add-on to your

(Sorry, it feels like there must be an obvious place to look for it, but
I can't seem to find it...)

Was the fix ever posted? If it isn't completely obsolete could you
please send it?

> tree, or a whole new version of one of the patches?
>
> And it's pretty easy to hit, just start printing a lot of individual
> files with a local printer to cups. My daughter showed me in painful
> detail how easy it was... :)

thanks,
-serge

2007-11-16 21:05:34