2007-12-25 21:50:26

by Erez Zadok

Subject: checkpatch false ERROR: trailing statements should be on next line

Using v2.6.24-rc6-125-g5356f66, code such as this:

if (is_file) /* dirs can be unlinked but chdir'ed to */
err = -ESTALE;

produces this false checkpatch error:

foo.c:947: ERROR: trailing statements should be on next line

I think comments such as the above should be allowed (plus a comment isn't a
statement). It's often very useful to put them right on the affected line.

Thanks,
Erez.

2007-12-26 13:02:37

by Andy Whitcroft

Subject: Re: checkpatch false ERROR: trailing statements should be on next line

On Tue, Dec 25, 2007 at 04:50:04PM -0500, Erez Zadok wrote:
> Using v2.6.24-rc6-125-g5356f66, code such as this:
>
> if (is_file) /* dirs can be unlinked but chdir'ed to */
> err = -ESTALE;
>
> produces this false checkpatch error:
>
> foo.c:947: ERROR: trailing statements should be on next line
>
> I think comments such as the above should be allowed (plus a comment isn't a
> statement). It's often very useful to put them right on the affected line.

Agreed. checkpatch 0.13 already ignores these as statements. A
positive side effect of other changes in this area.

Thanks for the report.

-apw