2008-01-08 08:55:28

by Alexey Dobriyan

[permalink] [raw]
Subject: [PATCH -mm 2/4] hifn_795x: fixup container_of() usage

[PATCH -mm 2/4] hifn_795x: fixup container_of() usage

Signed-off-by: Alexey Dobriyan <[email protected]>
---

drivers/crypto/hifn_795x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -664,7 +664,7 @@ struct hifn_context
atomic_t sg_num;
};

-#define crypto_alg_to_hifn(alg) container_of(alg, struct hifn_crypto_alg, alg)
+#define crypto_alg_to_hifn(a) container_of(a, struct hifn_crypto_alg, alg)

static inline u32 hifn_read_0(struct hifn_device *dev, u32 reg)
{


2008-01-08 14:54:45

by Evgeniy Polyakov

[permalink] [raw]
Subject: Re: [PATCH -mm 2/4] hifn_795x: fixup container_of() usage

Hi.

On Tue, Jan 08, 2008 at 11:44:34AM +0300, Alexey Dobriyan ([email protected]) wrote:
> [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
>
> Signed-off-by: Alexey Dobriyan <[email protected]>

Well, I have no problem with the patch, although do not see any gain
in it :)
I usually prefer to call members the same in container usage, since I
always forget where each one should be placed.

--
Evgeniy Polyakov

2008-01-08 20:48:22

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH -mm 2/4] hifn_795x: fixup container_of() usage

On Tue, Jan 08, 2008 at 11:44:34AM +0300, Alexey Dobriyan wrote:
> [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
>
> Signed-off-by: Alexey Dobriyan <[email protected]>

Patch applied. Thanks.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt