In C, signed 1-bit bitfields can only take the values 0 and -1, only
0 and 1 are ever assigned in current code. Make them unsigned
bitfields.
Fixes the (repeated) sparse errors:
drivers/mtd/ubi/ubi.h:220:15: error: dubious one-bit signed bitfield
drivers/mtd/ubi/ubi.h:221:17: error: dubious one-bit signed bitfield
drivers/mtd/ubi/ubi.h:222:18: error: dubious one-bit signed bitfield
drivers/mtd/ubi/ubi.h:223:16: error: dubious one-bit signed bitfield
drivers/mtd/ubi/ubi.h:224:20: error: dubious one-bit signed bitfield
Signed-off-by: Harvey Harrison <[email protected]>
---
Sorry, not sure who to CC on this.
drivers/mtd/ubi/ubi.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
index 4577106..a548c1d 100644
--- a/drivers/mtd/ubi/ubi.h
+++ b/drivers/mtd/ubi/ubi.h
@@ -217,11 +217,11 @@ struct ubi_volume {
void *upd_buf;
int *eba_tbl;
- int checked:1;
- int corrupted:1;
- int upd_marker:1;
- int updating:1;
- int changing_leb:1;
+ unsigned int checked:1;
+ unsigned int corrupted:1;
+ unsigned int upd_marker:1;
+ unsigned int updating:1;
+ unsigned int changing_leb:1;
#ifdef CONFIG_MTD_UBI_GLUEBI
/*
--
1.5.4.1.1278.gc75be
On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote:
> In C, signed 1-bit bitfields can only take the values 0 and -1, only
> 0 and 1 are ever assigned in current code. Make them unsigned
> bitfields.
>
> Fixes the (repeated) sparse errors:
> drivers/mtd/ubi/ubi.h:220:15: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:221:17: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:222:18: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:223:16: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:224:20: error: dubious one-bit signed bitfield
>
> Signed-off-by: Harvey Harrison <[email protected]>
> ---
> Sorry, not sure who to CC on this.
IIRC: Artem Bityutskiy <[email protected]>
--
Ben ([email protected], http://www.fluff.org/)
'a smiley only costs 4 bytes'
On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote:
> In C, signed 1-bit bitfields can only take the values 0 and -1, only
> 0 and 1 are ever assigned in current code. Make them unsigned
> bitfields.
>
> Fixes the (repeated) sparse errors:
> drivers/mtd/ubi/ubi.h:220:15: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:221:17: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:222:18: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:223:16: error: dubious one-bit signed bitfield
> drivers/mtd/ubi/ubi.h:224:20: error: dubious one-bit signed bitfield
>
> Signed-off-by: Harvey Harrison <[email protected]>
> ---
> Sorry, not sure who to CC on this.
>...
$ grep UBI MAINTAINERS
UNSORTED BLOCK IMAGES (UBI)
$
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Thu, 2008-02-14 at 23:56 +0000, Ben Dooks wrote:
> On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote:
> > In C, signed 1-bit bitfields can only take the values 0 and -1, only
> > 0 and 1 are ever assigned in current code. Make them unsigned
> > bitfields.
> >
> > Fixes the (repeated) sparse errors:
> > drivers/mtd/ubi/ubi.h:220:15: error: dubious one-bit signed bitfield
> > drivers/mtd/ubi/ubi.h:221:17: error: dubious one-bit signed bitfield
> > drivers/mtd/ubi/ubi.h:222:18: error: dubious one-bit signed bitfield
> > drivers/mtd/ubi/ubi.h:223:16: error: dubious one-bit signed bitfield
> > drivers/mtd/ubi/ubi.h:224:20: error: dubious one-bit signed bitfield
> >
> > Signed-off-by: Harvey Harrison <[email protected]>
> > ---
> > Sorry, not sure who to CC on this.
>
> IIRC: Artem Bityutskiy <[email protected]>
UNSORTED BLOCK IMAGES (UBI)
P: Artem Bityutskiy
M: [email protected]
W: http://www.linux-mtd.infradead.org/
L: [email protected]
T: git git://git.infradead.org/~dedekind/ubi-2.6.git
S: Maintained
F: drivers/mtd/ubi
F: include/linux/mtd/ubi.h
F: include/mtd/ubi-*